Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v6]

2023-06-02 Thread Valerie Peng
On Thu, 1 Jun 2023 22:06:47 GMT, Francisco Ferrari Bihurriet wrote: >> @valeriepeng: I agree, `DEFAULT_ITERATIONS` should be used here and only >> here, so we consistently initialize any defaults in a single place. We'll >> update that. > > There are cases in which _salt_ and _iteration count_

Re: RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v6]

2023-06-02 Thread Valerie Peng
On Fri, 2 Jun 2023 00:33:21 GMT, Francisco Ferrari Bihurriet wrote: >> As someone who is familiar with the Cipher convention, it's clearer to apply >> the Cipher convention across the board, i.e. for Mac and SecretKeyFactory >> too. >> For example: For SecretKeyFactory.PBEWithHmacSHA1AndAES_1

Re: RFR: 8308592: Framework for CA interoperability testing [v9]

2023-06-02 Thread Rajan Halade
> The new approach uses test URLs directly to verify interoperability with CA > infrastructure. This would help us avoid having regular test fixes to update > test artifacts as long as CAs keep test domains up to date. Rajan Halade has updated the pull request incrementally with one additional

Re: RFR: 8308592: Framework for CA interoperability testing [v8]

2023-06-02 Thread Rajan Halade
> The new approach uses test URLs directly to verify interoperability with CA > infrastructure. This would help us avoid having regular test fixes to update > test artifacts as long as CAs keep test domains up to date. Rajan Halade has updated the pull request incrementally with one additional

Re: RFR: 8309330: Allow java.security to be extended via a properties directory [v2]

2023-06-02 Thread Alexey Bakhtin
On Fri, 2 Jun 2023 12:58:36 GMT, Andrew John Hughes wrote: >> Currently, security properties are held within the `java.security` file in >> the JDK tree for each installed JDK. The system property >> `java.security.properties` can be used to point to a file containing >> additional properties.

Re: RFR: 8308592: Framework for CA interoperability testing [v7]

2023-06-02 Thread Sean Mullan
On Thu, 1 Jun 2023 21:46:25 GMT, Rajan Halade wrote: >> The new approach uses test URLs directly to verify interoperability with CA >> infrastructure. This would help us avoid having regular test fixes to update >> test artifacts as long as CAs keep test domains up to date. > > Rajan Halade has

Integrated: 8296411: AArch64: Accelerated Poly1305 intrinsics

2023-06-02 Thread Andrew Haley
On Mon, 22 May 2023 14:23:15 GMT, Andrew Haley wrote: > This provides a solid speedup of about 3-4x over the Java implementation. > > I have a vectorized version of this which uses a bunch of tricks to speed it > up, but it's complex and can still be improved. We're getting close to ramp > dow

Re: RFR: 8309330: Allow java.security to be extended via a properties directory [v2]

2023-06-02 Thread Andrew John Hughes
> Currently, security properties are held within the `java.security` file in > the JDK tree for each installed JDK. The system property > `java.security.properties` can be used to point to a file containing > additional properties. These can be appended to the existing set or override > all exi

Re: RFR: 8309330: Allow java.security to be extended via a properties directory

2023-06-02 Thread Andrew John Hughes
On Fri, 2 Jun 2023 11:54:00 GMT, Weijun Wang wrote: >> Currently, security properties are held within the `java.security` file in >> the JDK tree for each installed JDK. The system property >> `java.security.properties` can be used to point to a file containing >> additional properties. These

Re: RFR: 8309330: Allow java.security to be extended via a properties directory

2023-06-02 Thread Andrew John Hughes
On Fri, 2 Jun 2023 02:01:00 GMT, Alexey Bakhtin wrote: >> Currently, security properties are held within the `java.security` file in >> the JDK tree for each installed JDK. The system property >> `java.security.properties` can be used to point to a file containing >> additional properties. The

Re: RFR: 8309330: Allow java.security to be extended via a properties directory

2023-06-02 Thread Weijun Wang
On Fri, 2 Jun 2023 00:57:49 GMT, Andrew John Hughes wrote: > Currently, security properties are held within the `java.security` file in > the JDK tree for each installed JDK. The system property > `java.security.properties` can be used to point to a file containing > additional properties. The

Re: RFR: 8296411: AArch64: Accelerated Poly1305 intrinsics [v4]

2023-06-02 Thread Andrew Dinn
On Fri, 2 Jun 2023 09:58:59 GMT, Andrew Dinn wrote: >> Yes, of course, you are right that 0<= U_2 < 6 at the point where that >> second multiply by 5 occurs (i.e. after the loop). >> >> I believe it is safe to use the same optimization inside the loop for >> reasons given below. Of course it

Re: RFR: 8296411: AArch64: Accelerated Poly1305 intrinsics [v4]

2023-06-02 Thread Andrew Dinn
On Fri, 2 Jun 2023 09:51:57 GMT, Andrew Dinn wrote: >>> This comment and the next one both need correcting. They mention U_0HI and >>> U_1HI and, as the previous comment says, those registers are dead. >>> >>> What actually happens here is best summarized as >>> >>> // U_2:U_1:U_0 += (U2 >> 2) *

Re: RFR: 8296411: AArch64: Accelerated Poly1305 intrinsics [v4]

2023-06-02 Thread Andrew Dinn
On Thu, 1 Jun 2023 16:06:40 GMT, Andrew Haley wrote: >> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 7135: >> >>> 7133: regs = (regs.remaining() + U_0HI + U_1HI).begin(); >>> 7134: >>> 7135: // U_2:U_1:U_0 += (U_1HI >> 2) >> >> This comment and the next one both need corr

Re: RFR: 8296411: AArch64: Accelerated Poly1305 intrinsics [v5]

2023-06-02 Thread Andrew Dinn
On Thu, 1 Jun 2023 16:16:32 GMT, Andrew Haley wrote: >> This provides a solid speedup of about 3-4x over the Java implementation. >> >> I have a vectorized version of this which uses a bunch of tricks to speed it >> up, but it's complex and can still be improved. We're getting close to ramp >>

Integrated: 8308711: Develop additional Tests for KEM implementation

2023-06-02 Thread Sibabrata Sahoo
On Wed, 24 May 2023 07:02:55 GMT, Sibabrata Sahoo wrote: > Additional Tests for KEM API. This pull request has now been integrated. Changeset: aeb53e67 Author:Sibabrata Sahoo URL: https://git.openjdk.org/jdk/commit/aeb53e67f944da17d806212b32444ebb4ce2c02e Stats: 542 lines in 3 f

RFR: JDK-8309340: Provide sctpHandleSocketErrorWithMessage

2023-06-02 Thread Matthias Baesken
There are cases in the sctp coding where a function sctpHandleSocketErrorWithMessage would be beneficial (similar to existing handleSocketErrorWithMessage) to provide more detail what failed. Additionally sctpHandleSocketErrorWithMessage was a bit modified (added errno handling for ENOTCONN fro