Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base [v2]

2023-06-26 Thread Anthony Scarpino
> Hi, > > I need a code review for moving the contents of the jdk.crypto.ec module into > java.base. This moves the SunEC JCE Provider (Elliptic Curve) into > java.base. EC has always been separate from the base module/pkg because of > its dependence on a native library. That library was rem

Re: There is unnecessary resource consumption in `SecureRandom.getInstance()`.

2023-06-26 Thread 구태진
I understood what you said. And thank you for forwarding this mail to security-dev. If it is decided to fix this issue and this issue is not as much work as I thought. If you give me the opportunity to change the code via PR, it will be a great honor for a lifetime as a Java developer. Thanks :)

RFR: 8310070: Test: javax/net/ssl/DTLS/DTLSWontNegotiateV10.java timed out

2023-06-26 Thread Matthew Donovan
In this PR, I updated the test to use read time-outs. The test is restarted if the read operations time-out within (default) 30 seconds. The test makes 5 attempts before giving up. - Commit messages: - 8310070: Test: javax/net/ssl/DTLS/DTLSWontNegotiateV10.java timed out Changes:

Re: RFR: 8310901: Convert String::newStringNoRepl with Latin-1 to String::newStringLatin1NoRepl [v3]

2023-06-26 Thread Glavo
> Added a new method `newStringLatin1NoRepl` to the `JavaLangAccess`. > > Reasons: > > * Most use cases of `newStringNoRepl` use `ISO_8859_1` as the charset, > creating a new shortcut can make writing shorter; > * Since all possible values of `byte` are legal Latin-1 characters, > `newStringLat

Re: RFR: 8310901: Convert String::newStringNoRepl with Latin-1 to String::newStringLatin1NoRepl [v2]

2023-06-26 Thread Glavo
On Mon, 26 Jun 2023 16:02:57 GMT, Chen Liang wrote: > This is just a copycat of the original newStringNoRepl, which should be > fixed; newStringUTF8NoRepl has no such issue. Unfortunately, the behavior of `newStringUTF8NoRepl` is not the same as that of `newStringNoRepl`, as it actually always

Re: RFR: 8310901: Convert String::newStringNoRepl with Latin-1 to String::newStringLatin1NoRepl [v2]

2023-06-26 Thread Glavo
> Added a new method `newStringLatin1NoRepl` to the `JavaLangAccess`. > > Reasons: > > * Most use cases of `newStringNoRepl` use `ISO_8859_1` as the charset, > creating a new shortcut can make writing shorter; > * Since all possible values of `byte` are legal Latin-1 characters, > `newStringLat

RFR: 8310901: Convert String::newStringNoRepl with Latin-1 to String::newStringLatin1NoRepl

2023-06-26 Thread Glavo
Added a new method `newStringLatin1NoRepl` to the `JavaLangAccess`. Reasons: * Most use cases of `newStringNoRepl` use `ISO_8859_1` as the charset, creating a new shortcut can make writing shorter; * Since all possible values of `byte` are legal Latin-1 characters, `newStringLatin1NoRepl` **wil

Re: RFR: 8310901: Convert String::newStringNoRepl with Latin-1 to String::newStringLatin1NoRepl

2023-06-26 Thread Chen Liang
On Mon, 26 Jun 2023 15:25:08 GMT, Glavo wrote: > Added a new method `newStringLatin1NoRepl` to the `JavaLangAccess`. > > Reasons: > > * Most use cases of `newStringNoRepl` use `ISO_8859_1` as the charset, > creating a new shortcut can make writing shorter; > * Since all possible values of `byt

Re: RFR: 8310901: Convert String::newStringNoRepl with Latin-1 to String::newStringLatin1NoRepl

2023-06-26 Thread Chen Liang
On Mon, 26 Jun 2023 15:25:08 GMT, Glavo wrote: > Added a new method `newStringLatin1NoRepl` to the `JavaLangAccess`. > > Reasons: > > * Most use cases of `newStringNoRepl` use `ISO_8859_1` as the charset, > creating a new shortcut can make writing shorter; > * Since all possible values of `byt

Integrated: 8308540: On Kerberos TGT referral, if krb5.conf is missing realm, bad exception message

2023-06-26 Thread Weijun Wang
On Mon, 22 May 2023 15:03:15 GMT, Weijun Wang wrote: > Add realm name to the exception message, and make it the primary exception > (retry exception added suppressed). This pull request has now been integrated. Changeset: e624484e Author:Weijun Wang URL: https://git.openjdk.org/jdk

Re: RFR: 8308540: On Kerberos TGT referral, if krb5.conf is missing realm, bad exception message

2023-06-26 Thread Xue-Lei Andrew Fan
On Mon, 22 May 2023 15:03:15 GMT, Weijun Wang wrote: > Add realm name to the exception message, and make it the primary exception > (retry exception added suppressed). Marked as reviewed by xuelei (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14086#pullrequestreview-14

Re: RFR: 8308540: On Kerberos TGT referral, if krb5.conf is missing realm, bad exception message

2023-06-26 Thread Weijun Wang
On Mon, 22 May 2023 15:03:15 GMT, Weijun Wang wrote: > Add realm name to the exception message, and make it the primary exception > (retry exception added suppressed). Still worth fixing. - PR Comment: https://git.openjdk.org/jdk/pull/14086#issuecomment-1607442146