On Fri, 7 Jul 2023 18:58:02 GMT, Justin Lu wrote:
> Please review this PR which addresses `KeytoolReaderP12Test.java` failing for
> non-English locale users.
>
> This test checks output from keytool, but fails on finding the value 'alias
> name' for non-English locale users. This is because 'a
> Please review this PR to use modern APIs and language features to simplify
> `equals` and `hashCode` in security area.
>
> I understand that security area is sensitive and a non-expert, such as
> myself, should tread carefully; so below are my notes to assist the review.
>
> * Unlike `hashCod
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Sean Coffey has updated the pull request incrementally with two additional
commits since the last revision:
- Harden code to report lack of SSL support
- Testcase correction
On Fri, 7 Jul 2023 19:19:03 GMT, Sean Mullan wrote:
> Took another pass at this, looks good, but I would like to take another last
> look and make sure that changing the hash code for some of the classes like
> X509CRL is a benign change.
Thanks, Sean. Take your time, you're an expert in this
On Thu, 6 Jul 2023 19:10:14 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> `equals` and `hashCode` in security area.
>>
>> I understand that security area is sensitive and a non-expert, such as
>> myself, should tread carefully; so belo
On Fri, 7 Jul 2023 18:58:02 GMT, Justin Lu wrote:
> Please review this PR which addresses `KeytoolReaderP12Test.java` failing for
> non-English locale users.
>
> This test checks output from keytool, but fails on finding the value 'alias
> name' for non-English locale users. This is because 'a
On Thu, 6 Jul 2023 19:10:14 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> `equals` and `hashCode` in security area.
>>
>> I understand that security area is sensitive and a non-expert, such as
>> myself, should tread carefully; so belo
Please review this PR which addresses `KeytoolReaderP12Test.java` failing for
non-English locale users.
This test checks output from keytool, but fails on finding the value 'alias
name' for non-English locale users. This is because 'alias name' is a localized
value. (For example, in `ja` this i
On Wed, 5 Jul 2023 20:25:26 GMT, Kevin Driver wrote:
> JDK-8295068: an NPE is thrown when an invalid `id` is found to match up a
> `ClientCertificateType`; rather than throwing the `NPE`, we now ignore an
> `id` which does match a `ClientCertificateType`.
This pull request has now been integra
On Fri, 7 Jul 2023 13:40:53 GMT, Sean Coffey wrote:
>> src/java.base/share/classes/sun/launcher/SecuritySettings.java line 123:
>>
>>> 121: }
>>> 122:
>>> 123: ostream.println(INDENT + "Security TLS configuration:");
>>
>> What about also noting the name of the TLS/JSSE provide
On Thu, 6 Jul 2023 14:03:12 GMT, Sean Mullan wrote:
>> Sean Coffey has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 15 additional
>> commits sinc
On Thu, 6 Jul 2023 18:43:41 GMT, Roger Riggs wrote:
>> Sean Coffey has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 15 additional
>> commits sinc
On Thu, 6 Jul 2023 17:15:20 GMT, Mandy Chung wrote:
> > The changes make me wonder if `-XshowSetting:aardvark` should be an error
> > rather than default to print all settings. Something we should look at
> > again. Same thing for `-XshowSettings:system` on non-Linux, probably should
> > have
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Sean Coffey has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The
14 matches
Mail list logo
