Hi,
This fix eliminates needless exceptions each time the EC key size is obtained
through AlgorithmParameters on third party providers. These providers throw an
InvalidParameterSpecException as `sun.security.util.KeyUtil.getKey()` sends an
internal `sun.security.util.ECKeySizeParameterSpec`.
On Thu, 20 Jul 2023 09:29:50 GMT, John Jiang wrote:
> sun.security codes should use `toLowerCase(Locale.ROOT)` instead of
> `toLowerCase()`.
> In addition, no `toUpperCase()` was found in this code scope.
@XueleiFan
Thanks for your review!
-
PR Comment: https://git.openjdk.org/jd
On Thu, 20 Jul 2023 09:29:50 GMT, John Jiang wrote:
> sun.security codes should use `toLowerCase(Locale.ROOT)` instead of
> `toLowerCase()`.
> In addition, no `toUpperCase()` was found in this code scope.
This pull request has now been integrated.
Changeset: 4e8f331a
Author:John Jiang
URL
Good to hear that plan,I wonder are there also special considerations for password based algorithms? One of the major annoyances are the different encoding formats (mostly about bytes derived from strings, maybe padding). Would be good if this can be an parameter.In regard
Hi,
This feature had been implemented in OpenSSL [1] and Chrome browser [2] for a
while. Maybe, it is time to pick this request up for further discussion and
review if there are resources available. What do you think?
Best,
Xuelei
[1]: https://github.com/openssl/openssl/issues/13597
[2]: http
On Wed, 19 Jul 2023 12:03:14 GMT, Daniel Jeliński wrote:
> This patch fixes random deadlocks in PKCS11 decryption and encryption code.
>
> The deadlocks were caused by object allocation in `ckAssertReturnValueOK`
> waiting for GC; GC was in turn waiting for `ReleasePrimitiveArrayCritical`,
> w
On Wed, 19 Jul 2023 18:03:06 GMT, Daniel Jeliński wrote:
>> This patch fixes random deadlocks in PKCS11 decryption and encryption code.
>>
>> The deadlocks were caused by object allocation in `ckAssertReturnValueOK`
>> waiting for GC; GC was in turn waiting for `ReleasePrimitiveArrayCritical`,
On Thu, 20 Jul 2023 09:29:50 GMT, John Jiang wrote:
> sun.security codes should use `toLowerCase(Locale.ROOT)` instead of
> `toLowerCase()`.
> In addition, no `toUpperCase()` was found in this code scope.
Looks good to me.
-
Marked as reviewed by xuelei (Reviewer).
PR Review: htt
sun.security codes should use `toLowerCase(Locale.ROOT)` instead of
`toLowerCase()`.
In addition, no `toUpperCase()` was found in this code scope.
-
Commit messages:
- 8312443: sun.security should use toLowerCase(Locale.ROOT)
Changes: https://git.openjdk.org/jdk/pull/14948/files
W
