Re: RFR: 6478546: FileInputStream.read() throws OutOfMemoryError when there is plenty available [v3]

2023-08-02 Thread Brian Burkhalter
On Sun, 30 Jul 2023 13:06:36 GMT, Alan Bateman wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 6478546: Move buffer clamping up to Java layer; correct read behavior to >> match legacy > > src/java.base/share/c

Re: RFR: 8313206: PKCS11 tests silently skip execution [v3]

2023-08-02 Thread Rajan Halade
> I have updated PKCS11Test.java to mark test as skipped only when all > testDefault, testNSS, and testDeimos tests are skipped. This file also > includes new trace messages, code cleanup and format change. Some other test > files are updated to mark as skipped as they use TestNG framework to ex

Re: RFR: 8313206: PKCS11 tests silently skip execution [v2]

2023-08-02 Thread Rajan Halade
> I have updated PKCS11Test.java to mark test as skipped only when all > testDefault, testNSS, and testDeimos tests are skipped. This file also > includes new trace messages, code cleanup and format change. Some other test > files are updated to mark as skipped as they use TestNG framework to ex

Re: RFR: 8308995: Update Network IO JFR events to be static mirror events [v4]

2023-08-02 Thread Erik Gahlin
On Wed, 28 Jun 2023 18:53:12 GMT, Tim Prinzing wrote: >> The socket read/write JFR events currently use instrumentation of java.base >> code using templates in the jdk.jfr modules. This results in some java.base >> code residing in the jdk.jfr module which is undesirable. >> >> JDK19 added sta

Re: RFR: 8308995: Update Network IO JFR events to be static mirror events [v4]

2023-08-02 Thread Alan Bateman
On Wed, 2 Aug 2023 18:19:27 GMT, Tim Prinzing wrote: > I believe this has all requested changes or has separate bug reports to > address changes yet needing to be made. > https://bugs.openjdk.org/browse/JDK-8310979 - better exception handling > https://bugs.openjdk.org/browse/JDK-8310978 - mis

Re: RFR: 8308995: Update Network IO JFR events to be static mirror events [v4]

2023-08-02 Thread Tim Prinzing
On Wed, 28 Jun 2023 18:53:12 GMT, Tim Prinzing wrote: >> The socket read/write JFR events currently use instrumentation of java.base >> code using templates in the jdk.jfr modules. This results in some java.base >> code residing in the jdk.jfr module which is undesirable. >> >> JDK19 added sta

RFR: 8313206: PKCS11 tests silently skip execution

2023-08-02 Thread Rajan Halade
I have updated PKCS11Test.java to mark test as skipped only when all testDefault, testNSS, and testDeimos tests are skipped. This file also includes new trace messages, code cleanup and format change. Some other test files are updated to mark as skipped as they use TestNG framework to execute.

Re: RFR: 8312259: StatusResponseManager unused code clean up [v3]

2023-08-02 Thread Jamil Nimeh
On Wed, 2 Aug 2023 00:45:36 GMT, Xue-Lei Andrew Fan wrote: >> I think @jnimeh should review this, as I think these methods were added when >> implementing OCSP Stapling, and it would be good for him to make sure they >> are no longer needed.. > >> I think @jnimeh should review this, as I think

Re: RFR: 8252204: AArch64: Implement SHA3 accelerator/intrinsic [v11]

2023-08-02 Thread Yudi Zheng
On Wed, 2 Aug 2023 12:33:43 GMT, Ferenc Rakoczi wrote: >> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 3473: >> >>> 3471: __ bcax(v24, __ T16B, v24, v8, v31); >>> 3472: >>> 3473: __ ld1r(v31, __ T2D, __ post(rscratch1, 8)); >> >> is it intentional to load 16 bytes and post-i

Re: RFR: 8252204: AArch64: Implement SHA3 accelerator/intrinsic [v11]

2023-08-02 Thread Ferenc Rakoczi
On Wed, 2 Aug 2023 11:02:07 GMT, Yudi Zheng wrote: >> Fei Yang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add if (isJDK16OrHigher()) check for SHA3 in CheckGraalIntrinsics.java > > src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp l

Re: RFR: 8252204: AArch64: Implement SHA3 accelerator/intrinsic [v11]

2023-08-02 Thread Yudi Zheng
On Wed, 21 Oct 2020 23:42:33 GMT, Fei Yang wrote: >> Contributed-by: ard.biesheu...@linaro.org, dong...@huawei.com >> >> This added an intrinsic for SHA3 using aarch64 v8.2 SHA3 Crypto Extensions. >> Reference implementation for core SHA-3 transform using ARMv8.2 Crypto >> Extensions: >> https:

Re: [jdk21] RFR: 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails

2023-08-02 Thread Matthias Baesken
On Wed, 2 Aug 2023 06:42:29 GMT, Christoph Langer wrote: > Hi all, > > This pull request contains a backport of > [JDK-8309088](https://bugs.openjdk.org/browse/JDK-8309088), commit > [4c2e54fb](https://github.com/openjdk/jdk/commit/4c2e54fb055bee0af5cd838fdd32a0f7902d51e3) > from the [openjdk