On Tue, 8 Aug 2023 19:52:08 GMT, Thomas Stuefe wrote:
>> I just checked and the value of the sentinel is ultimately the prvalue 88. I
>> don't know if we'd want to replace all the weird char usages here with
>> explicit values of 0 (and 88 for the sentinel). Maybe future reviews can
>> help wi
On Mon, 7 Aug 2023 06:42:41 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done
>> with some effort, given that the signific
On Wed, 9 Aug 2023 04:00:03 GMT, Julian Waters wrote:
>> src/hotspot/os/windows/os_windows.cpp line 2888:
>>
>>> 2886: LONG WINAPI topLevelUnhandledExceptionFilter(struct
>>> _EXCEPTION_POINTERS* exceptionInfo) {
>>> 2887: if (!InterceptOSException) {
>>> 2888: DWORD exception_code =
>>>
I would like to put some attention on JDK-8170813 "TLS session cache access".
It has been open for almost seven years now, and there is still no good
solution.
On the contrary, the workarounds provided in the linked issue from Apache
Commons NET are becoming more difficult with newer Java versi
On Tue, 8 Aug 2023 19:56:24 GMT, Thomas Stuefe wrote:
>> Julian Waters has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 22 additional
>> commits
On Tue, 8 Aug 2023 20:53:19 GMT, Thomas Stuefe wrote:
> I think I see now that the added scopes were to prevent variable life scopes
> from intersecting goto's?
Yes, that's why
-
PR Comment: https://git.openjdk.org/jdk/pull/15096#issuecomment-1670618830
On Fri, 4 Aug 2023 10:48:13 GMT, Matthias Baesken wrote:
> Hi Valerie, we put the PR into our build/test queue to check if it solves
> some errors we currently notice in CertChainRemoval.java .
Sure, thanks! What is the errors that you observed? Are you running against NSS
and which version?
On Tue, 8 Aug 2023 16:17:44 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> `equals` and `hashCode` in security area.
>>
>> I understand that security area is sensitive and a non-expert, such as
>> myself, should tread carefully; so belo
On Mon, 7 Aug 2023 06:42:41 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done
>> with some effort, given that the signific
On Wed, 2 Aug 2023 17:51:31 GMT, Rajan Halade wrote:
> I have updated PKCS11Test.java to mark test as skipped only when all
> testDefault, testNSS, and testDeimos tests are skipped. This file also
> includes new trace messages, code cleanup and format change. Some other test
> files are update
On Mon, 7 Aug 2023 06:42:41 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done
>> with some effort, given that the signific
On Mon, 7 Aug 2023 08:14:41 GMT, Julian Waters wrote:
>> There are currently only 2 possible types of HMODULE and char/uint8_t for T
>> at the moment. Weirdly enough only line 126 errors out without the cast
>> while line 114, despite having the same problem, doesn't, but I added the
>> cast t
> I have updated PKCS11Test.java to mark test as skipped only when all
> testDefault, testNSS, and testDeimos tests are skipped. This file also
> includes new trace messages, code cleanup and format change. Some other test
> files are updated to mark as skipped as they use TestNG framework to ex
On Tue, 8 Aug 2023 17:48:21 GMT, Rajan Halade wrote:
>> I have updated PKCS11Test.java to mark test as skipped only when all
>> testDefault, testNSS, and testDeimos tests are skipped. This file also
>> includes new trace messages, code cleanup and format change. Some other test
>> files are up
On Mon, 7 Aug 2023 06:42:41 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done
>> with some effort, given that the signific
> I have updated PKCS11Test.java to mark test as skipped only when all
> testDefault, testNSS, and testDeimos tests are skipped. This file also
> includes new trace messages, code cleanup and format change. Some other test
> files are updated to mark as skipped as they use TestNG framework to ex
On Tue, 8 Aug 2023 16:17:44 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> `equals` and `hashCode` in security area.
>>
>> I understand that security area is sensitive and a non-expert, such as
>> myself, should tread carefully; so belo
> Please review this PR to use modern APIs and language features to simplify
> `equals` and `hashCode` in security area.
>
> I understand that security area is sensitive and a non-expert, such as
> myself, should tread carefully; so below are my notes to assist the review.
>
> * Unlike `hashCod
On Tue, 8 Aug 2023 11:54:42 GMT, Pavel Rappo wrote:
>> src/java.security.jgss/share/classes/sun/security/krb5/internal/HostAddress.java
>> line 105:
>>
>>> 103: return false;
>>> 104: if (address != null && h.address != null) {
>>> 105: return Arrays.equals(addre
> Please review this PR to use modern APIs and language features to simplify
> `equals` and `hashCode` in security area.
>
> I understand that security area is sensitive and a non-expert, such as
> myself, should tread carefully; so below are my notes to assist the review.
>
> * Unlike `hashCod
On Fri, 4 Aug 2023 21:30:00 GMT, Valerie Peng wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Feedback
>
> src/java.security.jgss/share/classes/sun/security/krb5/internal/HostAddress.java
> line 105:
>
>> 103:
21 matches
Mail list logo
