RFR: 8314240: test/jdk/sun/security/pkcs/pkcs7/SignerOrder.java fails to compile

2023-08-15 Thread Ben Perez
Included `null` as an argument to `pkcs71.verify` in SignerOrder.java - Commit messages: - updated copyright - Fixed SignerOrder test and removed from ProblemList Changes: https://git.openjdk.org/jdk/pull/15296/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15296&range=00

Re: RFR: 8309214: sun/security/pkcs11/KeyStore/CertChainRemoval.java fails after 8301154

2023-08-15 Thread Valerie Peng
On Thu, 3 Aug 2023 20:51:33 GMT, Valerie Peng wrote: > This change addresses the scenario where a certificate is first stored as > part of a certificate chain and then stored again as a certificate > corresponding to a PrivateKey entry. Newer version of NSS errors out with > CKR_GENERAL_ERROR

Re: RFR: 8309214: sun/security/pkcs11/KeyStore/CertChainRemoval.java fails after 8301154

2023-08-15 Thread Valerie Peng
On Fri, 11 Aug 2023 11:53:49 GMT, Matthias Baesken wrote: > Looks okay to me and seems to fix the issues we faced in our test > infrastructure; seems to need backport to jdk21. Would be great to have a > second reviewer who is working more actively in this area of the JDK codebase. Thanks for

Re: RFR: 8293176: SSLEngine handshaker does not send an alert after a bad parameters [v2]

2023-08-15 Thread Matthew Donovan
On Fri, 11 Aug 2023 21:38:04 GMT, Daniel JeliƄski wrote: >> Please review this patch that ensures that all exceptions thrown by >> SSLEngine delegated tasks are translated to alerts. >> >> All exceptions should already be translated to SSLExceptions and alerts by >> the time we exit from conte

Re: RFR: 8175874: Update Security.insertProviderAt to specify behavior when requested position is out of range. [v3]

2023-08-15 Thread Sean Mullan
On Mon, 14 Aug 2023 23:13:25 GMT, Valerie Peng wrote: > Is a CSR needed? Now that we are enhancing existing javadoc for covering > corner case scenarios? Yes, since the proposed wording will become part of the specification, a CSR is required. CSR has already been filed and approved: https://

Re: RFR: 8311943: Cleanup usages of toLowerCase() and toUpperCase() in java.base [v3]

2023-08-15 Thread Glavo
On Tue, 15 Aug 2023 10:48:29 GMT, Glavo wrote: >> Clean up misuses of `toLowerCase()`/`toUpperCase()` in java.base. > > Glavo has updated the pull request with a new target base due to a merge or a > rebase. The pull request now contains four commits: > > - Merge remote-tracking branch 'origin

Re: RFR: 8311943: Cleanup usages of toLowerCase() and toUpperCase() in java.base [v3]

2023-08-15 Thread Glavo
> Clean up misuses of `toLowerCase()`/`toUpperCase()` in java.base. Glavo has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: - Merge remote-tracking branch 'origin/master' into case-conversion-java-base - Revert StreamTok

Re: RFR: 8311943: Cleanup usages of toLowerCase() and toUpperCase() in java.base [v2]

2023-08-15 Thread Alan Bateman
On Wed, 12 Jul 2023 15:06:36 GMT, Glavo wrote: >> Clean up misuses of `toLowerCase()`/`toUpperCase()` in java.base. > > Glavo has updated the pull request incrementally with one additional commit > since the last revision: > > Revert StreamTokenizer.java Now that the incompatible change to S

Re: RFR: JDK-8313764: Offer JVM HS functionality to shared lib load operations done by the JDK codebase

2023-08-15 Thread Matthias Baesken
On Mon, 14 Aug 2023 07:48:00 GMT, Matthias Baesken wrote: > Currently there is a number of functionality that would be interesting to > have for shared lib load operations in the JDK C code. > Some examples : > Events::log_dll_message for hs-err files reporting > JFR event NativeLibraryLoad > Th