On Fri, 8 Sep 2023 19:41:47 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-8296631
Without updating `Secmod/cert9.db` and `Secmod/key4.db`, both
`Secmod/JksSetPrivateKey` and `Secmod/GetPrivateKey` will fail. The old values
must have been incorrect. This was not noticed because
On Fri, 8 Sep 2023 19:41:47 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-8296631
Just curious, there are already test/jdk/sun/security/pkcs11/Secmod/cert9.db
and test/jdk/sun/security/pkcs11/Secmod/key4.db, what are the reasons for
updating them? Since it's binary file, I can'
This PR reverts part of the changes under JDK-8312306 which zero-out the
deserialized key bytes after an internal copy has been made. If considering the
deserialized key bytes as input arguments, such cleaning action may be too
aggressive. Thus, on second thought, I am reverting to earlier behav
On Wed, 20 Sep 2023 19:51:28 GMT, Sean Mullan wrote:
> Please review this change to ensure this test is tested on different TLS
> protocols (1.0, 1.1, 1.2)
>
> I added a protocol parameter to the test arguments so that different
> protocols are tested. I also removed the boolean exportable arg
Please review this change to ensure this test is tested on different TLS
protocols (1.0, 1.1, 1.2)
I added a protocol parameter to the test arguments so that different protocols
are tested. I also removed the boolean exportable argument as it wasn't doing
anything.
-
Commit messag
On Wed, 20 Sep 2023 15:52:26 GMT, Ben Perez wrote:
>> Replaced "jks" with "pkcs12" in both the spec and fallback for
>> `KeyStore.getDefaultType()`
>
> Ben Perez has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Changed test description, fix
I'll look into it. Thanks!
Do you have a patch? :-)
--Max
> On Aug 9, 2023, at 3:30 AM, Osipov, Michael (SMD IT IN)
> wrote:
>
> Folks, Max,
>
> consider the following code snippet configured with the Krb5LoginModule:
>> LoginContext lc = new LoginContext(loginEntryName);
>> lc.login();
>
>
On Wed, 20 Sep 2023 15:40:47 GMT, Ben Perez wrote:
>> test/jdk/java/security/KeyStore/PKCS12/CheckNullDefault.java line 2:
>>
>>> 1: /*
>>> 2: * Copyright (c) 2023 Oracle and/or its affiliates. All rights reserved.
>>
>> Where did you get the copyright from? IIRC, there should be a coma after
On Wed, 20 Sep 2023 15:00:28 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-8315042
test/jdk/sun/security/x509/X509CRLImpl/UnexpectedNPE.java line 2:
> 1: /*
> 2: * Copyright (c) 2004, 2023 Oracle and/or its affiliates. All rights
> reserved.
missing a coma after 2023.
--
Hi,
Working with Java and the JCA KeyStore for many years, I came across
many situations where I thought it would be really convenient to be
able to load private keys and certificates in PEM format directly
using the KeyStore API.
Since I found no implementation I developed my own. You can find it
Relax take it ezzzsy
Le mer. 9 août 2023, 08:57, David Holmes a écrit :
> On Tue, 8 Aug 2023 19:52:08 GMT, Thomas Stuefe wrote:
>
> >> I just checked and the value of the sentinel is ultimately the prvalue
> 88. I don't know if we'd want to replace all the weird char usages here
> with expl
Can you shut the f
Le mer. 9 août 2023, 10:10, Thomas Stuefe a écrit :
> On Wed, 9 Aug 2023 06:53:49 GMT, David Holmes wrote:
>
> >> I wrote this code ages ago. I'm not sure what's weird or suspicious
> about it, though. The comment at the file's beginning explains this code's
> motivation.
> >
Folks, Max,
consider the following code snippet configured with the Krb5LoginModule:
LoginContext lc = new LoginContext(loginEntryName);
lc.login();
then a LoginException is thrown with the following stacktrace:
2023-08-01T00:09:31.601 SCHWERWIEGEND [https-openssl-apr-8444-exec-5417]
net.sf.
On Wed, 20 Sep 2023 06:08:11 GMT, Valerie Peng wrote:
>> Ben Perez has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added test to check that when keystore.type is null it defaults to pkcs12
>
> test/jdk/java/security/KeyStore/PKCS12/Check
> Replaced "jks" with "pkcs12" in both the spec and fallback for
> `KeyStore.getDefaultType()`
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Changed test description, fixed indentation
-
Changes:
- all: https://git.ope
On Wed, 20 Sep 2023 06:02:52 GMT, Valerie Peng wrote:
>> Ben Perez has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added test to check that when keystore.type is null it defaults to pkcs12
>
> test/jdk/java/security/KeyStore/PKCS12/Check
On Tue, 19 Sep 2023 23:55:09 GMT, Valerie Peng wrote:
>> Such a change would apply NSS version number checks to `TestNssDbSqlite`
>> which currently doesn't have them. But wait! If `TestNssDbSqlite` has been
>> running for years on all NSS versions, then it should be safe to make sqlite
>> th
https://bugs.openjdk.org/browse/JDK-8315042
-
Commit messages:
- first iteration
Changes: https://git.openjdk.org/jdk/pull/15844/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15844&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8315042
Stats: 23 lines in 2 files c
On Tue, 6 Jun 2023 19:39:31 GMT, Tim Prinzing wrote:
> The socket read/write JFR events currently use instrumentation of java.base
> code using templates in the jdk.jfr modules. This results in some java.base
> code residing in the jdk.jfr module which is undesirable.
>
> JDK19 added static su
On Wed, 20 Sep 2023 11:21:51 GMT, Daniel Fuchs wrote:
> Thanks Tim. Should 8308995 be listed in the `@bug` clause of these two tests?
I don't think so as these tests are just used to check that changes haven't
broken anything.
-
PR Comment: https://git.openjdk.org/jdk/pull/14342#i
On Tue, 19 Sep 2023 20:51:41 GMT, Tim Prinzing wrote:
> The existing JFR tests TestSocketChannelEvents and TestSocketEvents in
> jdk.jfr.event.io verify the events are still emitted as expected.
Thanks Tim. Should 8308995 be listed in the `@bug` clause of these two tests?
-
PR Com
Hi Tony!
When the PEM API implementation becomes available it would make sense
to use it inside the PEM Keystore implementation. It will reduce the
code (the internal classes PemReader und PemWriter may become
obsolete), but it does not affect the functionality of the PEM
keystore. Users of the P
22 matches
Mail list logo
