Integrated: 8301686: TLS 1.3 handshake fails if server_name doesn't match resuming session

2023-09-28 Thread Jaikiran Pai
On Wed, 26 Apr 2023 10:02:49 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to fix the issue > reported in https://bugs.openjdk.org/browse/JDK-8301686? > > The internal implementation of SSLContext caches SSLSession(s). These > sessions are for a particular

Re: RFR: 8301686: TLS 1.3 handshake fails if server_name doesn't match resuming session [v4]

2023-09-28 Thread Jaikiran Pai
> Can I please get a review of this change which proposes to fix the issue > reported in https://bugs.openjdk.org/browse/JDK-8301686? > > The internal implementation of SSLContext caches SSLSession(s). These > sessions are for a particular combination or peer host and port. When a TLS > handsha

Re: RFR: 8301686: TLS 1.3 handshake fails if server_name doesn't match resuming session [v3]

2023-09-28 Thread Jaikiran Pai
On Thu, 28 Sep 2023 17:53:39 GMT, Bradford Wetmore wrote: >> Jaikiran Pai has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> com

Re: RFR: JDK-8296631 NSS tests failing on OL9 linux-aarch64 hosts [v3]

2023-09-28 Thread Valerie Peng
On Thu, 28 Sep 2023 17:39:05 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-8296631 > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > more sqlite conversion needed Marked as reviewed by valeriep (Reviewer). T

Re: RFR: 8309356: Read files in includedir in alphanumeric order

2023-09-28 Thread Sean Mullan
On Thu, 28 Sep 2023 18:28:13 GMT, Weijun Wang wrote: > > Is there any potential compatibility issue by reading the files in a > > different order? > > There is a behavior change, but I doubt if anyone is using this feature. I'm > following what MIT krb5 has fixed. I can add a release note if n

Re: RFR: 8309356: Read files in includedir in alphanumeric order [v2]

2023-09-28 Thread Sean Mullan
On Thu, 28 Sep 2023 18:49:15 GMT, Weijun Wang wrote: >> Read files in `includedir` in alphanumerical order. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > typo in comment Marked as reviewed by mullan (Reviewer). -

Re: RFR: 8309356: Read files in includedir in alphanumeric order [v2]

2023-09-28 Thread Weijun Wang
> Read files in `includedir` in alphanumerical order. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: typo in comment - Changes: - all: https://git.openjdk.org/jdk/pull/15889/files - new: https://git.openjdk.org/jdk/p

Re: RFR: 8309356: Read files in includedir in alphanumeric order

2023-09-28 Thread Weijun Wang
On Thu, 28 Sep 2023 13:21:57 GMT, Sean Mullan wrote: > Is there any potential compatibility issue by reading the files in a > different order? There is a behavior change, but I doubt if anyone is using this feature. I'm following what MIT krb5 has fixed. I can add a release note if necessary.

Re: RFR: 8301686: TLS 1.3 handshake fails if server_name doesn't match resuming session [v3]

2023-09-28 Thread Bradford Wetmore
On Thu, 28 Sep 2023 01:38:15 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to fix the issue >> reported in https://bugs.openjdk.org/browse/JDK-8301686? >> >> The internal implementation of SSLContext caches SSLSession(s). These >> sessions are for a partic

Re: RFR: 8293176: SSLEngine handshaker does not send an alert after a bad parameters [v2]

2023-09-28 Thread Bradford Wetmore
On Thu, 28 Sep 2023 05:57:58 GMT, Daniel JeliƄski wrote: >> src/java.base/share/classes/sun/security/ssl/SSLEngineImpl.java line 1278: >> >>> 1276: throw >>> context.conContext.fatal(Alert.INTERNAL_ERROR, >>> 1277: "Unhandled excep

Re: RFR: JDK-8296631 NSS tests failing on OL9 linux-aarch64 hosts [v3]

2023-09-28 Thread Mark Powers
> https://bugs.openjdk.org/browse/JDK-8296631 Mark Powers has updated the pull request incrementally with one additional commit since the last revision: more sqlite conversion needed - Changes: - all: https://git.openjdk.org/jdk/pull/15644/files - new: https://git.openjdk.org

Re: RFR: 8295919: java.security.MessageDigest.isEqual does not adhere to @implNote [v2]

2023-09-28 Thread Sean Mullan
On Wed, 27 Sep 2023 20:15:35 GMT, Kevin Driver wrote: >> Fix JDK-8295919 by updating the javadoc to explain that a null or >> zero-length `digestb` will also result in a short-circuit response > > Kevin Driver has updated the pull request incrementally with one additional > commit since the las

Re: RFR: 8309356: Read files in includedir in alphanumeric order

2023-09-28 Thread Sean Mullan
On Fri, 22 Sep 2023 14:00:34 GMT, Weijun Wang wrote: > Read files in `includedir` in alphanumerical order. Is there any potential compatibility issue by reading the files in a different order? test/jdk/sun/security/krb5/config/IncludeDirOrder.java line 61: > 59: write(xdir, i); >