On Fri, 27 Oct 2023 17:05:36 GMT, Anthony Scarpino
wrote:
> I have a few questions:
>
> * The change listed in the bug is not the same as this PR. The bug removes
> the section and leaves only the new ServiceKey(). The condition statement
> left will always be false.
> * This seems like a l
> Modified `getService` method to prevent caching of `ServiceKey`, which was
> negatively impacting multithreaded performance
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
changed fix to align with bug report
-
Changes:
On Fri, 27 Oct 2023 20:19:01 GMT, Weijun Wang wrote:
>> Hmm, but how does this work? The inbound properties override the global
>> property if both are set.
>
> This belongs to the `if (inboundClientLen == null || inboundClientLen < 0)`
> side. The else side stays the same.
Precisely, it's
On Fri, 27 Oct 2023 20:12:44 GMT, Hai-May Chao wrote:
>> Please review the enhancement for JDK-8311596 and its CSR JDK-8313236. Thank
>> you.
>
> Hai-May Chao has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Change maxCertificateChainLength
On Fri, 27 Oct 2023 20:15:41 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/sun/security/ssl/SSLConfiguration.java line 160:
>>
>>> 158: "jdk.tls.server.maxInboundCertificateChainLength");
>>> 159: if (inboundClientLen == null || inboundClientLen < 0) {
>>> 160:
On Fri, 27 Oct 2023 20:07:07 GMT, Weijun Wang wrote:
>> Hai-May Chao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Change property names to clearly indicate client side and server side
>
> src/java.base/share/classes/sun/security/ssl/S
On Thu, 26 Oct 2023 20:44:45 GMT, Hai-May Chao wrote:
>> Please review the enhancement for JDK-8311596 and its CSR JDK-8313236. Thank
>> you.
>
> Hai-May Chao has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Change property names to clearly
> Please review the enhancement for JDK-8311596 and its CSR JDK-8313236. Thank
> you.
Hai-May Chao has updated the pull request incrementally with one additional
commit since the last revision:
Change maxCertificateChainLength to be a local variable
-
Changes:
- all: https://g
On Fri, 27 Oct 2023 19:45:29 GMT, Sean Mullan wrote:
>> Hai-May Chao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Change property names to clearly indicate client side and server side
>
> src/java.base/share/classes/sun/security/ssl/S
On Thu, 26 Oct 2023 20:44:45 GMT, Hai-May Chao wrote:
>> Please review the enhancement for JDK-8311596 and its CSR JDK-8313236. Thank
>> you.
>
> Hai-May Chao has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Change property names to clearly
On Fri, 27 Oct 2023 14:43:56 GMT, Ben Perez wrote:
> Modified `getService` method to prevent caching of `ServiceKey`, which was
> negatively impacting multithreaded performance
I have a few questions:
- The change listed in the bug is not the same as this PR. The bug removes the
section and l
On Fri, 27 Oct 2023 04:21:01 GMT, Kevin Driver wrote:
>> JDK-8308453: JSSE regression test keystore migration from JKS to PKCS12
>
> Kevin Driver has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Security Manager won't let you explicitly set
On Fri, 20 Oct 2023 20:52:13 GMT, Ben Perez wrote:
> Updated the `constrains` method in `DNSName.java` to accept certificates with
> a leading period.
test/jdk/sun/security/x509/DNSName/LeadingPeriod.java line 54:
> 52:
> 53: // generate certification path
> 54: List list = Ar
Modified `getService` method to prevent caching of `ServiceKey`, which was
negatively impacting multithreaded performance
-
Commit messages:
- changed ServiceKey initialization to prevent caching
Changes: https://git.openjdk.org/jdk/pull/16403/files
Webrev: https://webrevs.openjdk
On Fri, 27 Oct 2023 04:21:01 GMT, Kevin Driver wrote:
>> JDK-8308453: JSSE regression test keystore migration from JKS to PKCS12
>
> Kevin Driver has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Security Manager won't let you explicitly set
On Fri, 20 Oct 2023 20:52:13 GMT, Ben Perez wrote:
> Updated the `constrains` method in `DNSName.java` to accept certificates with
> a leading period.
test/jdk/sun/security/x509/DNSName/LeadingPeriod.java line 24:
> 22: */
> 23:
> 24: /* @test
Nit, change to:
/*
* @test
-
P
On Fri, 20 Oct 2023 20:52:13 GMT, Ben Perez wrote:
> Updated the `constrains` method in `DNSName.java` to accept certificates with
> a leading period.
src/java.base/share/classes/sun/security/x509/DNSName.java line 1:
> 1: /*
On line 203, can you modify the comment to:
* RFC 5280: For DNS na
On Wed, 25 Oct 2023 08:44:29 GMT, Leo Korinth wrote:
>> This pull request renames `createJavaProcessBuilder` to
>> `createLimitedTestJavaProcessBuilder` and renames `createTestJvm` to
>> `createTestJavaProcessBuilder`. Both are implemented through a private
>> `createJavaProcessBuilder`. It al
On Mon, 28 Aug 2023 15:54:08 GMT, Leo Korinth wrote:
> This pull request renames `createJavaProcessBuilder` to
> `createLimitedTestJavaProcessBuilder` and renames `createTestJvm` to
> `createTestJavaProcessBuilder`. Both are implemented through a private
> `createJavaProcessBuilder`. It also u
19 matches
Mail list logo
