Withdrawn: 8311532: Option to disable Krb5LoginModule::login method

2023-11-16 Thread duke
On Fri, 11 Aug 2023 23:08:56 GMT, Alexey Bakhtin wrote: > JGSS is implemented in the JVM in 2 levels: the standard Java security > provider for Kerberos in sun.security.jgss.krb5.Krb5MechFactory and the JAAS > login module for Kerberos in com.sun.security.auth.module.Krb5LoginModule. > The pro

Re: JEP draft: PEM API (Preview)

2023-11-16 Thread Bernd Eckenfels
Anthony Scarpino wrote on 16. Nov 2023 23:47 (GMT +01:00): > Hi all, > > We are proposing to add an API for PEM and a foundation for other crypto > encoding. I like the modularity and that you do not try to squeeze it into the existing services. I wonder if you should also allow to set comment

Re: RFR: 8320192: SHAKE256 does not work correctly if n >= 137 [v3]

2023-11-16 Thread Weijun Wang
> When blocksize is less than digest output length, call `keccak` more. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: add comment for squeezeOffset - Changes: - all: https://git.openjdk.org/jdk/pull/16698/files - ne

Re: RFR: 8320192: SHAKE256 does not work correctly if n >= 137 [v2]

2023-11-16 Thread Weijun Wang
> When blocksize is less than digest output length, call `keccak` more. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: fix wording - Changes: - all: https://git.openjdk.org/jdk/pull/16698/files - new: https://git.ope

Re: RFR: 8320192: SHAKE256 does not work correctly if n >= 137

2023-11-16 Thread Mark Powers
On Thu, 16 Nov 2023 20:45:29 GMT, Weijun Wang wrote: > When blocksize is less than digest output length, call `keccak` more. Looks good. I only found trivial things. A comment describing `squeezeOffset` would help. src/java.base/share/classes/sun/security/provider/DigestBase.java line 144: >

JEP draft: PEM API (Preview)

2023-11-16 Thread Anthony Scarpino
Hi all, We are proposing to add an API for PEM and a foundation for other crypto encoding. The draft JEP is located at: https://openjdk.org/jeps/8300911 Feel free to comment here. Thanks Tony

RFR: 8320192: SHAKE256 does not work correctly if n >= 137

2023-11-16 Thread Weijun Wang
When blocksize is less than digest output length, call `keccak` more. - Commit messages: - initial change Changes: https://git.openjdk.org/jdk/pull/16698/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16698&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320192 Sta

Re: RFR: 8319124: Update XML Security for Java to 3.0.3

2023-11-16 Thread Sean Mullan
On Thu, 16 Nov 2023 14:30:31 GMT, Weijun Wang wrote: > Update XMLDsig implementation to match Apache Santuario 3.0.3. > > Changes include (significance in descending order): > > - `SignatureMethod.java`: new signature method URIs defined > - `SignatureBaseRSA.java`: `SignatureBaseRSAPSS` and re

Re: RFR: 8317538: RSA have scalability issue for high vCPU numbers [v3]

2023-11-16 Thread Ben Perez
> Modified `getService` method to prevent caching of `ServiceKey`, which was > negatively impacting multithreaded performance Ben Perez has updated the pull request incrementally with one additional commit since the last revision: changed cache to use threadlocal - Changes: -

Re: RFR: 8302233: HSS/LMS: keytool and jarsigner changes [v3]

2023-11-16 Thread Weijun Wang
On Thu, 16 Nov 2023 16:33:36 GMT, Sean Mullan wrote: >> This internal method was called by `TimestampedSigner` which was removed >> long ago when we removed the support for `ContentSigner` and `jarsigner >> -altsign`. It has been useless for some time and this is just a cleanup. > > Ok, I see.

Re: RFR: 8302233: HSS/LMS: keytool and jarsigner changes [v3]

2023-11-16 Thread Weijun Wang
> Code changes for HSS/LMS that's related to keytool and jarsigner: > > 1. No need to add `-sigalg` for both tools when HSS/LMS key is involved, it > can only be `HSS/LMS`. > 2. The `digestAlgorithm` field in a PKCS7 `SignerInfo`. It must be the same > as the hash algorithm used by the HSS/LMS k

Re: RFR: 8302233: HSS/LMS: keytool and jarsigner changes [v2]

2023-11-16 Thread Weijun Wang
> Code changes for HSS/LMS that's related to keytool and jarsigner: > > 1. No need to add `-sigalg` for both tools when HSS/LMS key is involved, it > can only be `HSS/LMS`. > 2. The `digestAlgorithm` field in a PKCS7 `SignerInfo`. It must be the same > as the hash algorithm used by the HSS/LMS k

Re: RFR: 8302233: HSS/LMS: keytool and jarsigner changes

2023-11-16 Thread Sean Mullan
On Thu, 16 Nov 2023 16:25:33 GMT, Weijun Wang wrote: >> src/java.base/share/classes/sun/security/pkcs/PKCS7.java line 872: >> >>> 870: */ >>> 871: @Deprecated(since="16", forRemoval=true) >>> 872: public static byte[] generateSignedData(byte[] signature, >> >> Are you sure you want

Re: RFR: 8302233: HSS/LMS: keytool and jarsigner changes

2023-11-16 Thread Weijun Wang
On Thu, 16 Nov 2023 15:36:08 GMT, Sean Mullan wrote: >> Code changes for HSS/LMS that's related to keytool and jarsigner: >> >> 1. No need to add `-sigalg` for both tools when HSS/LMS key is involved, it >> can only be `HSS/LMS`. >> 2. The `digestAlgorithm` field in a PKCS7 `SignerInfo`. It mus

Re: RFR: 8320208: Update Public Suffix List to b5bf572

2023-11-16 Thread Mark Powers
On Thu, 16 Nov 2023 14:50:23 GMT, Weijun Wang wrote: > Update `public_suffix_list.dat` to the latest. Looks good to me. I never knew this existed. - PR Comment: https://git.openjdk.org/jdk/pull/16692#issuecomment-1814778083

Re: RFR: 8302233: HSS/LMS: keytool and jarsigner changes

2023-11-16 Thread Weijun Wang
On Thu, 16 Nov 2023 15:45:38 GMT, Sean Mullan wrote: >> Code changes for HSS/LMS that's related to keytool and jarsigner: >> >> 1. No need to add `-sigalg` for both tools when HSS/LMS key is involved, it >> can only be `HSS/LMS`. >> 2. The `digestAlgorithm` field in a PKCS7 `SignerInfo`. It mus

Re: RFR: 8302233: HSS/LMS: keytool and jarsigner changes

2023-11-16 Thread Sean Mullan
On Wed, 31 May 2023 22:38:20 GMT, Weijun Wang wrote: > Code changes for HSS/LMS that's related to keytool and jarsigner: > > 1. No need to add `-sigalg` for both tools when HSS/LMS key is involved, it > can only be `HSS/LMS`. > 2. The `digestAlgorithm` field in a PKCS7 `SignerInfo`. It must be

Re: RFR: 8302233: HSS/LMS: keytool and jarsigner changes

2023-11-16 Thread Sean Mullan
On Wed, 31 May 2023 22:38:20 GMT, Weijun Wang wrote: > Code changes for HSS/LMS that's related to keytool and jarsigner: > > 1. No need to add `-sigalg` for both tools when HSS/LMS key is involved, it > can only be `HSS/LMS`. > 2. The `digestAlgorithm` field in a PKCS7 `SignerInfo`. It must be

RFR: 8320208: Update Public Suffix List to b5bf572

2023-11-16 Thread Weijun Wang
Update `public_suffix_list.dat` to the latest. - Commit messages: - initial change Changes: https://git.openjdk.org/jdk/pull/16692/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16692&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320208 Stats: 3002 lines in 4 fil

RFR: 8319124: Update XML Security for Java to 3.0.3

2023-11-16 Thread Weijun Wang
Update XMLDsig implementation to match Apache Santuario 3.0.3. Changes include (significance in descending order): - `SignatureMethod.java`: new signature method URIs defined - `SignatureBaseRSA.java`: `SignatureBaseRSAPSS` and refactoring - `JCEMapper.java`: use of `ThreadLocal` - `DigestorOutpu

Re: RFR: 8302233: HSS/LMS: keytool and jarsigner changes

2023-11-16 Thread Weijun Wang
On Wed, 31 May 2023 22:38:20 GMT, Weijun Wang wrote: > Code changes for HSS/LMS that's related to keytool and jarsigner: > > 1. No need to add `-sigalg` for both tools when HSS/LMS key is involved, it > can only be `HSS/LMS`. > 2. The `digestAlgorithm` field in a PKCS7 `SignerInfo`. It must be

RFR: 8302233: HSS/LMS: keytool and jarsigner changes

2023-11-16 Thread Weijun Wang
Code changes for HSS/LMS that's related to keytool and jarsigner: 1. No need to add `-sigalg` for both tools when HSS/LMS key is involved, it can only be `HSS/LMS`. 2. The `digestAlgorithm` field in a PKCS7 `SignerInfo`. It must be the same as the hash algorithm used by the HSS/LMS key. This nee