Re: RFR: 8296787: Unify debug printing format of X.509 cert serial numbers [v9]

2023-12-11 Thread Ben Perez
> Updated `X509CertSelector.java`, `SerialNumber.java`, and `SSLLogger` to use > same debug printing format for X.509 serial numbers. The changes are: > - `X509CertSelector` was `SN: 83be056904246b1a1756ac95991c74a` and now is > `Serial number: 08:3B:E0:56:90:42:46:B1:A1:75:6A:C9:59:91:C7:4A`

Re: RFR: 8296787: Unify debug printing format of X.509 cert serial numbers [v8]

2023-12-11 Thread Ben Perez
> Updated `X509CertSelector.java`, `SerialNumber.java`, and `SSLLogger` to use > same debug printing format for X.509 serial numbers. The changes are: > - `X509CertSelector` was `SN: 83be056904246b1a1756ac95991c74a` and now is > `Serial number: 08:3B:E0:56:90:42:46:B1:A1:75:6A:C9:59:91:C7:4A`

RFR: 8202598: [linux] keytool -certreq inconsistent with platform line.separator

2023-12-11 Thread Weijun Wang
Always use CRLF in PEM output. - Commit messages: - the fix Changes: https://git.openjdk.org/jdk/pull/17060/files Webrev: https://webrevs.openjdk.org/?repo=jdk=17060=00 Issue: https://bugs.openjdk.org/browse/JDK-8202598 Stats: 109 lines in 3 files changed: 97 ins; 0 del; 12

Re: RFR: 8296787: Unify debug printing format of X.509 cert serial numbers [v7]

2023-12-11 Thread Sean Coffey
On Fri, 8 Dec 2023 19:07:27 GMT, Ben Perez wrote: >> Updated `X509CertSelector.java`, `SerialNumber.java`, and `SSLLogger` to >> use same debug printing format for X.509 serial numbers. The changes are: >> - `X509CertSelector` was `SN: 83be056904246b1a1756ac95991c74a` and now is >> `Serial

Re: RFR: 8320219: Actually resolve issues with goto labels in sspi [v4]

2023-12-11 Thread Weijun Wang
On Mon, 4 Dec 2023 09:26:57 GMT, Julian Waters wrote: >> I regret not actually addressing the issues with the goto labels in >> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in >> sspi were jumped over by gotos to a certain label. I changed the >> initializations

Re: RFR: 8321713: Harmonize executeTestJvm with create[Limited]TestJavaProcessBuilder [v3]

2023-12-11 Thread Leo Korinth
On Mon, 11 Dec 2023 14:06:43 GMT, Stefan Karlsson wrote: >> [JDK-8315097](https://bugs.openjdk.org/browse/JDK-8315097): 'Rename >> createJavaProcessBuilder' changed the name of the ProcessTools helper >> functions used to create `ProcessBuilder`s used to spawn new java test >> processes. >>

Re: RFR: 8321713: Harmonize executeTestJvm with create[Limited]TestJavaProcessBuilder [v3]

2023-12-11 Thread Stefan Karlsson
> [JDK-8315097](https://bugs.openjdk.org/browse/JDK-8315097): 'Rename > createJavaProcessBuilder' changed the name of the ProcessTools helper > functions used to create `ProcessBuilder`s used to spawn new java test > processes. > > We now have `createTestJavaProcessBuilder` and >

Re: RFR: 8321713: Harmonize executeTestJvm with create[Limited]TestJavaProcessBuilder [v2]

2023-12-11 Thread Stefan Karlsson
> [JDK-8315097](https://bugs.openjdk.org/browse/JDK-8315097): 'Rename > createJavaProcessBuilder' changed the name of the ProcessTools helper > functions used to create `ProcessBuilder`s used to spawn new java test > processes. > > We now have `createTestJavaProcessBuilder` and >

Re: RFR: 8320219: Actually resolve issues with goto labels in sspi [v4]

2023-12-11 Thread Julian Waters
On Tue, 5 Dec 2023 15:07:15 GMT, Weijun Wang wrote: > I still don't like this solution: > > 1. Duplicated lines. > 2. There are other `goto`s in this file. I know they happen to be unaffected, > but if `goto` is not recommended in C++ it looks unfair to remove some and > keep some. > > Can

RFR: 8321713: Harmonize executeTestJvm with create[Limited]TestJavaProcessBuilder

2023-12-11 Thread Stefan Karlsson
[JDK-8315097](https://bugs.openjdk.org/browse/JDK-8315097): 'Rename createJavaProcessBuilder' changed the name of the ProcessTools helper functions used to create `ProcessBuilder`s used to spawn new java test processes. We now have `createTestJavaProcessBuilder` and