Re: RFR: 8320449: ECDHKeyAgreement should validate parameters before using them [v2]

2024-01-12 Thread John Jiang
On Sat, 13 Jan 2024 01:07:20 GMT, Bernd wrote: >> John Jiang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> more assertThrows on doPhase > > test/jdk/sun/security/ec/ECDHKeyAgreementParamValidation.java line 90: > >> 88: KeyAgr

Re: RFR: 8320449: ECDHKeyAgreement should validate parameters before using them [v2]

2024-01-12 Thread John Jiang
> ECDHKeyAgreement should validate the parameters before assigning them to the > fields. John Jiang has updated the pull request incrementally with one additional commit since the last revision: more assertThrows on doPhase - Changes: - all: https://git.openjdk.org/jdk/pull/17

Re: RFR: 8320449: ECDHKeyAgreement should validate parameters before using them

2024-01-12 Thread Bernd
On Thu, 11 Jan 2024 13:33:54 GMT, John Jiang wrote: > ECDHKeyAgreement should validate the parameters before assigning them to the > fields. test/jdk/sun/security/ec/ECDHKeyAgreementParamValidation.java line 90: > 88: KeyAgreement ka = KeyAgreement.getInstance("ECDH"); > 89: ka

Re: RFR: 8320449: ECDHKeyAgreement should validate parameters before using them

2024-01-12 Thread John Jiang
On Fri, 12 Jan 2024 20:51:03 GMT, Sean Mullan wrote: >> ECDHKeyAgreement should validate the parameters before assigning them to the >> fields. > > test/jdk/sun/security/ec/ECDHKeyAgreementParamValidation.java line 28: > >> 26: * @bug 8320449 >> 27: * @summary ECDHKeyAgreement should validate

Re: RFR: 8320449: ECDHKeyAgreement should validate parameters before using them

2024-01-12 Thread Sean Mullan
On Thu, 11 Jan 2024 13:33:54 GMT, John Jiang wrote: > ECDHKeyAgreement should validate the parameters before assigning them to the > fields. test/jdk/sun/security/ec/ECDHKeyAgreementParamValidation.java line 28: > 26: * @bug 8320449 > 27: * @summary ECDHKeyAgreement should validate parameter

Re: RFR: 8320449: ECDHKeyAgreement should validate parameters before using them

2024-01-12 Thread Sean Mullan
On Fri, 12 Jan 2024 15:30:33 GMT, John Jiang wrote: >> src/java.base/share/classes/sun/security/ec/ECDHKeyAgreement.java line 83: >> >>> 81: privateKey = null; >>> 82: privateKeyOps = null; >>> 83: publicKey = null; >> >> The fields should be initialized to null, so I do

Re: RFR: 8275338: Add JFR events for notable serialization situations [v14]

2024-01-12 Thread Roger Riggs
On Wed, 10 Jan 2024 18:56:45 GMT, Raffaello Giulietti wrote: >> Adds serialization misdeclaration events to JFR. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Small space optimization. Thanks for the updates. LG

Re: RFR: 8323624: ProviderList.ServiceList does not need to be a list [v3]

2024-01-12 Thread Weijun Wang
> Re-implement it as an `Iterator` to make sure it can only be iterated once > and make debugger happy. > > No regression, just a refactoring. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: use consistent names - Chang

Re: RFR: 8323624: ProviderList.ServiceList does not need to be a list [v2]

2024-01-12 Thread Weijun Wang
> Re-implement it as an `Iterator` to make sure it can only be iterated once > and make debugger happy. > > No regression, just a refactoring. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: : iterator - Changes: - al

Re: RFR: 8320449: ECDHKeyAgreement should validate parameters before using them

2024-01-12 Thread John Jiang
On Fri, 12 Jan 2024 13:46:43 GMT, Sean Mullan wrote: >> ECDHKeyAgreement should validate the parameters before assigning them to the >> fields. > > src/java.base/share/classes/sun/security/ec/ECDHKeyAgreement.java line 83: > >> 81: privateKey = null; >> 82: privateKeyOps = null;

Re: RFR: 8320449: ECDHKeyAgreement should validate parameters before using them

2024-01-12 Thread Sean Mullan
On Thu, 11 Jan 2024 13:33:54 GMT, John Jiang wrote: > ECDHKeyAgreement should validate the parameters before assigning them to the > fields. src/java.base/share/classes/sun/security/ec/ECDHKeyAgreement.java line 83: > 81: privateKey = null; > 82: privateKeyOps = null; > 83: