Re: RFR: 8320219: Actually resolve issues with goto labels in sspi [v9]

2024-01-18 Thread Julian Waters
> I regret not actually addressing the issues with the goto labels in > https://github.com/openjdk/jdk/pull/15996, where initialization of locals in > sspi were jumped over by gotos to a certain label. I changed the > initializations into split declarations and assignments in > https://github.c

Re: RFR: 8320219: Actually resolve issues with goto labels in sspi [v8]

2024-01-18 Thread Julian Waters
> I regret not actually addressing the issues with the goto labels in > https://github.com/openjdk/jdk/pull/15996, where initialization of locals in > sspi were jumped over by gotos to a certain label. I changed the > initializations into split declarations and assignments in > https://github.c

Re: RFR: 8320219: Actually resolve issues with goto labels in sspi [v7]

2024-01-18 Thread Julian Waters
On Tue, 16 Jan 2024 17:42:43 GMT, Weijun Wang wrote: >> Julian Waters has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix the remaining case in sspi.cpp > > src/java.security.jgss/windows/native/libsspi_bridge/sspi.cpp line 580: > >> 57

Re: RFR: 8320219: Actually resolve issues with goto labels in sspi [v7]

2024-01-18 Thread Julian Waters
On Tue, 16 Jan 2024 17:36:20 GMT, Weijun Wang wrote: >> Julian Waters has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix the remaining case in sspi.cpp > > src/java.security.jgss/windows/native/libsspi_bridge/sspi.cpp line 422: > >> 42

[jdk22] Integrated: 8322100: Fix GCMIncrementByte4 & GCMIncrementDirect4, and increase overlap testing

2024-01-18 Thread Anthony Scarpino
On Thu, 18 Jan 2024 19:11:56 GMT, Anthony Scarpino wrote: > This is the straight backport to 22 of > https://github.com/openjdk/jdk/pull/17362 This pull request has now been integrated. Changeset: 5a77c290 Author:Anthony Scarpino URL: https://git.openjdk.org/jdk22/commit/5a77c2903

Re: [jdk22] RFR: 8322100: Fix GCMIncrementByte4 & GCMIncrementDirect4, and increase overlap testing

2024-01-18 Thread Jamil Nimeh
On Thu, 18 Jan 2024 19:11:56 GMT, Anthony Scarpino wrote: > This is the straight backport to 22 of > https://github.com/openjdk/jdk/pull/17362 LGTM - Marked as reviewed by jnimeh (Reviewer). PR Review: https://git.openjdk.org/jdk22/pull/93#pullrequestreview-1830622552

Re: [jdk22] RFR: 8322100: Fix GCMIncrementByte4 & GCMIncrementDirect4, and increase overlap testing

2024-01-18 Thread Anthony Scarpino
On Thu, 18 Jan 2024 19:11:56 GMT, Anthony Scarpino wrote: > This is the straight backport to 22 of > https://github.com/openjdk/jdk/pull/17362 All tests pass - PR Comment: https://git.openjdk.org/jdk22/pull/93#issuecomment-1899229307

[jdk22] RFR: JDK-8322100: Fix GCMIncrementByte4 & GCMIncrementDirect4, and increase overlap testing

2024-01-18 Thread Anthony Scarpino
This is the straight backport to 22 of https://github.com/openjdk/jdk/pull/17362 - Commit messages: - Backport 51dbd36c74c70b1b17bd73cd2c3253593300b5f0 Changes: https://git.openjdk.org/jdk22/pull/93/files Webrev: https://webrevs.openjdk.org/?repo=jdk22&pr=93&range=00 Issue: https

Integrated: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist"

2024-01-18 Thread Matthew Donovan
On Wed, 10 Jan 2024 20:14:31 GMT, Matthew Donovan wrote: > I was unable to recreate the error but it looks like the problem could happen > if two instances of the test are run on the same machine. Also, if the > deleteEntry() calls in the finally block throw an exception, they can hide > any

Integrated: 8275338: Add JFR events for notable serialization situations

2024-01-18 Thread Raffaello Giulietti
On Fri, 15 Dec 2023 17:34:53 GMT, Raffaello Giulietti wrote: > Adds serialization misdeclaration events to JFR. This pull request has now been integrated. Changeset: bfd2afe5 Author:Raffaello Giulietti URL: https://git.openjdk.org/jdk/commit/bfd2afe5adc315928fdedbfbe73049d8774400de

Re: RFR: 8317431: Implement simpler Comparator when building certification paths [v3]

2024-01-18 Thread Weijun Wang
On Thu, 11 Jan 2024 17:31:37 GMT, Sean Mullan wrote: >> This enhancement simplifies and improves the performance of the Comparator >> that the PKIX CertPathBuilder uses to sort candidate certificates. >> >> [RFC 5280](https://www.rfc-editor.org/rfc/rfc5280#section-4.2.1.1) requires >> that cer