Re: RFR: 8328785: IOException: Symbol not found: C_GetInterface for PKCS11 interface prior to V3.0 [v3]

2024-04-05 Thread Valerie Peng
On Fri, 5 Apr 2024 07:47:24 GMT, Daniel Jeliński wrote: >> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address one more review comment. > > Marked as reviewed by djelinski (Reviewer). @djelinski Thanks much for the revi

Re: RFR: 8200566: DistributionPointFetcher fails to fetch CRLs if the DistributionPoints field contains more than one DistributionPoint and the first one fails [v2]

2024-04-05 Thread Sean Mullan
On Fri, 5 Apr 2024 13:59:41 GMT, Weijun Wang wrote: >> Sean Mullan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove unnecessary module java.base/sun.security.provider.certpath. > > src/java.base/share/classes/sun/security/provider/

Re: RFR: 8200566: DistributionPointFetcher fails to fetch CRLs if the DistributionPoints field contains more than one DistributionPoint and the first one fails [v2]

2024-04-05 Thread Sean Mullan
On Fri, 5 Apr 2024 14:16:47 GMT, Weijun Wang wrote: >> Sean Mullan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove unnecessary module java.base/sun.security.provider.certpath. > > test/jdk/java/security/cert/CertPathValidator/crlD

Re: RFR: 8329538: Accelerate P256 on x86_64 using Montgomery intrinsic [v2]

2024-04-05 Thread Volodymyr Paprotski
On Tue, 2 Apr 2024 19:19:59 GMT, Volodymyr Paprotski wrote: >> Performance. Before: >> >> Benchmark(algorithm) (dataSize) (keyLength) >> (provider) Mode Cnt ScoreError Units >> SignatureBench.ECDSA.signSHA256withECDSA1024 256 >

Re: RFR: JDK-8328501 Incorrect @since` tags for java security interfaces [v3]

2024-04-05 Thread Nizar Benalla
On Mon, 25 Mar 2024 22:51:48 GMT, Nizar Benalla wrote: >> For context, I am writing tests to check for accurate use of `@since` tags >> in documentation comments in source code. >> We're following these rules for now: >> >> ### Rule 1: Introduction of New Elements >> >> - If an element is new

Re: RFR: 8200566: DistributionPointFetcher fails to fetch CRLs if the DistributionPoints field contains more than one DistributionPoint and the first one fails [v2]

2024-04-05 Thread Weijun Wang
On Fri, 5 Apr 2024 13:48:24 GMT, Sean Mullan wrote: >> Please review this change which fixes an issue in revocation checking of >> CRLs. A certificate's CRL Distribution Points extension can contain multiple >> Distribution Points (DPs), and each DP can contain one or more references to >> a C

Re: RFR: 8200566: DistributionPointFetcher fails to fetch CRLs if the DistributionPoints field contains more than one DistributionPoint and the first one fails [v2]

2024-04-05 Thread Sean Mullan
> Please review this change which fixes an issue in revocation checking of > CRLs. A certificate's CRL Distribution Points extension can contain multiple > Distribution Points (DPs), and each DP can contain one or more references to > a CRL. These CRL references are typically specified as URLs.

RFR: 8200566: DistributionPointFetcher fails to fetch CRLs if the DistributionPoints field contains more than one DistributionPoint and the first one fails

2024-04-05 Thread Sean Mullan
Please review this change which fixes an issue in revocation checking of CRLs. A certificate's CRL Distribution Points extension can contain multiple Distribution Points (DPs), and each DP can contain one or more references to a CRL. These CRL references are typically specified as URLs. If ther

Re: RFR: 8329538: Accelerate P256 on x86_64 using Montgomery intrinsic [v2]

2024-04-05 Thread Jatin Bhateja
On Tue, 2 Apr 2024 19:19:59 GMT, Volodymyr Paprotski wrote: >> Performance. Before: >> >> Benchmark(algorithm) (dataSize) (keyLength) >> (provider) Mode Cnt ScoreError Units >> SignatureBench.ECDSA.signSHA256withECDSA1024 256 >

Re: RFR: 8328785: IOException: Symbol not found: C_GetInterface for PKCS11 interface prior to V3.0 [v3]

2024-04-05 Thread Daniel Jeliński
On Thu, 4 Apr 2024 21:23:25 GMT, Valerie Peng wrote: >> This PR fixes a problem regarding the usage of dlerror() where an earlier >> error message causes a premature error out. Added extra code to clear out >> earlier error message and made minor code refactoring. >> >> No regression test as t