Re: RFR: 8329538: Accelerate P256 on x86_64 using Montgomery intrinsic [v2]

2024-04-11 Thread Anthony Scarpino
On Wed, 10 Apr 2024 18:02:38 GMT, Volodymyr Paprotski wrote: > > In `ECOperations.java`, if I understand this correctly, it is to replace > > the existing `PointMultiplier` with montgomery-based PointMuliplier. But > > when I look at the code, I see both are still options. If I read this > > c

RFR: 8328864: NullPointerException in sun.security.jca.ProviderList.getService()

2024-04-11 Thread Ben Perez
Updated `getService` to check whether `getProvider` returns null when checking for preferred providers and `continue` the loop if that is the case. Added `NullPreferredList` test. - Commit messages: - Fixed and renamed test, getService now continues loop instead of returning null

Re: RFR: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation [v5]

2024-04-11 Thread Bernd
On Thu, 11 Apr 2024 13:01:36 GMT, Weijun Wang wrote: > [One of the > test](https://github.com/openjdk/jdk/blob/master/test/jdk/sun/security/mscapi/VeryLongAlias.java) good link, thanks. Didn’t know the type is even visible for an assert. - PR Comment: https://git.openjdk.org/jdk/

Re: RFR: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation [v4]

2024-04-11 Thread Weijun Wang
On Wed, 10 Apr 2024 13:09:37 GMT, rebarbora-mckvak wrote: >> Yes it's self signed one. >> >> No it's not added to any other keystore. When I said >> "TrustedCertificateEntry" it's only because in a Java KeyStore an entry with >> only a certificate is called a TrustedCertificateEntry. >> >> So

Re: RFR: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation [v5]

2024-04-11 Thread Weijun Wang
On Thu, 11 Apr 2024 07:57:12 GMT, Bernd wrote: >> rebarbora-mckvak has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8313367: copyright updated > > Did you test with CNG keys as well? Using the new providers is much more > important since

Re: RFR: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation [v4]

2024-04-11 Thread Sean Mullan
On Wed, 10 Apr 2024 13:09:37 GMT, rebarbora-mckvak wrote: >> Yes it's self signed one. >> >> No it's not added to any other keystore. When I said >> "TrustedCertificateEntry" it's only because in a Java KeyStore an entry with >> only a certificate is called a TrustedCertificateEntry. >> >> So

Re: RFR: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation [v5]

2024-04-11 Thread Bernd
On Wed, 10 Apr 2024 21:10:16 GMT, rebarbora-mckvak wrote: >> This fixes the defect described at >> https://bugs.openjdk.org/browse/JDK-8313367 >> >> If the process does not have write permissions, the store is opened as >> read-only (instead of failing). >> >> Please note that permissions to