Re: RFR: 8329538: Accelerate P256 on x86_64 using Montgomery intrinsic [v2]

2024-04-23 Thread Anthony Scarpino
On Tue, 2 Apr 2024 19:19:59 GMT, Volodymyr Paprotski wrote: >> Performance. Before: >> >> Benchmark(algorithm) (dataSize) (keyLength) >> (provider) Mode Cnt ScoreError Units >> SignatureBench.ECDSA.signSHA256withECDSA1024 256

Re: RFR: 8329538: Accelerate P256 on x86_64 using Montgomery intrinsic [v3]

2024-04-23 Thread Anthony Scarpino
On Mon, 15 Apr 2024 22:12:30 GMT, Volodymyr Paprotski wrote: >> Performance. Before: >> >> Benchmark(algorithm) (dataSize) (keyLength) >> (provider) Mode Cnt ScoreError Units >> SignatureBench.ECDSA.signSHA256withECDSA1024 256

Integrated: 8330178: Clean up non-standard use of /** comments in `java.base`

2024-04-23 Thread Jonathan Gibbons
On Thu, 18 Apr 2024 20:44:00 GMT, Jonathan Gibbons wrote: > Please review a set of updates to clean up use of `/**` comments in the > vicinity of declarations. > > There are various categories of update: > > * "Box comments" beginning with `/**` > * Misplaced doc comments before package or

Re: RFR: 8319332: Security properties files inclusion [v9]

2024-04-23 Thread Francisco Ferrari Bihurriet
> The implementation of this proposal is based on the requirements, > specification and design choices described in the [JDK-8319332] ticket and > its respective CSR [JDK-8319333]. What follows are implementation notes > organized per functional component, with the purpose of assisting to

Re: Useless long->string->long conversion

2024-04-23 Thread Sean Mullan
It is probably fixable by storing the long as a transient field and overriding writeObject and computing the String as needed in other methods, but I am somewhat skeptical if it is worth it as it would make the implementation a bit more complex. --Sean On 4/19/24 4:38 AM, Mkrtchyan, Tigran

Re: Disable TLS Renegociation ?

2024-04-23 Thread Sean Mullan
On 4/23/24 5:54 AM, Simon Bernard wrote: Hi, I'm implementing coaps+tcp (Coap over TLS) for LWM2M protocol. In this context, I would like to disable TLS renegotiation because : * by the past we faces security issue about it * it doesn't really make sense to use it  with those protocols

Integrated: 8330108: Increase CipherInputStream buffer size

2024-04-23 Thread Oli Gillespie
On Fri, 12 Apr 2024 15:34:01 GMT, Oli Gillespie wrote: > Increase buffer size in CipherInputStream from 512 bytes to 8192 bytes. > > I have seen applications where this small buffer size significantly reduces > throughput, and I've even seen applications which use reflection to modify > the

Re: RFR: 8330108: Increase CipherInputStream buffer size

2024-04-23 Thread Sean Mullan
On Tue, 23 Apr 2024 09:05:25 GMT, Oli Gillespie wrote: > > Please don't integrate until a Reviewer from the Security Group has > > reviewed this. Thanks. > > @seanjmullan are you okay for me to integrate now? Yes, @ascarpino has reviewed it and he is a Reviewer in the Security Group.

Disable TLS Renegociation ?

2024-04-23 Thread Simon Bernard
Hi, I'm implementing coaps+tcp (Coap over TLS) for LWM2M protocol. In this context, I would like to disable TLS renegotiation because : * by the past we faces security issue about it * it doesn't really make sense to use it  with those protocols (better to not increase the attack surface

Re: RFR: 8330108: Increase CipherInputStream buffer size

2024-04-23 Thread Oli Gillespie
On Fri, 12 Apr 2024 16:19:56 GMT, Sean Mullan wrote: > Please don't integrate until a Reviewer from the Security Group has reviewed > this. Thanks. @seanjmullan are you okay for me to integrate now? - PR Comment: https://git.openjdk.org/jdk/pull/18763#issuecomment-2071793073

Re: RFR: 8330108: Increase CipherInputStream buffer size

2024-04-23 Thread Aleksey Shipilev
On Fri, 12 Apr 2024 15:34:01 GMT, Oli Gillespie wrote: > Increase buffer size in CipherInputStream from 512 bytes to 8192 bytes. > > I have seen applications where this small buffer size significantly reduces > throughput, and I've even seen applications which use reflection to modify > the