RFR: 8334106: Problemlist CAInterop.java#quovadisrootca1g3 due to JDK-8334105

2024-06-12 Thread SendaoYan
Hi all, Test `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3` report failure as `failed to validate`, before the validate issue has been fixed, should we problem list the testcase. - Commit messages: - Merge branch 'openjdk:ma

Re: RFR: 8326705: Test CertMsgCheck.java fails to find alert certificate_required

2024-06-12 Thread Anthony Scarpino
On Thu, 6 Jun 2024 14:28:25 GMT, Mark Powers wrote: >> I have never heard that. I have always ended with a plus and I believe >> everyone else does too if I'm not mistaken. > > https://cr.openjdk.org/~alundblad/styleguide/index-v6.html#toc-constants > > Probably showed up in a code review comm

Re: RFR: 8326705: Test CertMsgCheck.java fails to find alert certificate_required

2024-06-12 Thread Anthony Scarpino
On Wed, 5 Jun 2024 23:49:02 GMT, Anthony Scarpino wrote: >> test/jdk/javax/net/ssl/templates/TLSBase.java line 246: >> >>> 244: void done() { >>> 245: try { >>> 246: t.join(5000); >> >> I had to increase the join value of a test recently that failed with virt

Re: RFR: 8333867: SHA3 performance can be improved [v2]

2024-06-12 Thread Vladimir Kozlov
On Wed, 12 Jun 2024 20:04:40 GMT, Ferenc Rakoczi wrote: > tier1,2,3 mach5 tests all passed. Thank you for testing. - PR Comment: https://git.openjdk.org/jdk/pull/19632#issuecomment-2163863932

Re: RFR: 8333867: SHA3 performance can be improved [v2]

2024-06-12 Thread Vladimir Kozlov
On Wed, 12 Jun 2024 14:08:43 GMT, Ferenc Rakoczi wrote: >> This PR removes some unnecessary conversions between byte arrays and long >> arrays during SHA3 digest computations. > > Ferenc Rakoczi has updated the pull request incrementally with one additional > commit since the last revision: >

Re: RFR: 8333867: SHA3 performance can be improved [v2]

2024-06-12 Thread Ferenc Rakoczi
On Wed, 12 Jun 2024 14:08:43 GMT, Ferenc Rakoczi wrote: >> This PR removes some unnecessary conversions between byte arrays and long >> arrays during SHA3 digest computations. > > Ferenc Rakoczi has updated the pull request incrementally with one additional > commit since the last revision: >

Re: RFR: 8333867: SHA3 performance can be improved [v2]

2024-06-12 Thread Ferenc Rakoczi
On Tue, 11 Jun 2024 18:21:49 GMT, Daniel JeliƄski wrote: >> okay > > Could you try using MethodHandles instead of b2lLittle? Similar to what's > used in ChaCha20: > https://github.com/openjdk/jdk/blob/b77bd5fd6a6f7ddbed90300fba790da4fb683275/src/java.base/share/classes/com/sun/crypto/provider/Ch

Integrated: 8209092: Remove outdated wording from RC5ParameterSpec

2024-06-12 Thread Ben Perez
On Wed, 12 Jun 2024 16:18:08 GMT, Ben Perez wrote: > The RC5ParameterSpec class description contains the following sentence: "This > class can be used to initialize a Cipher object that implements the RC5 > algorithm as supplied by RSA Security LLC, or any parties authorized by RSA > Security.

Re: RFR: 8209092: Remove outdated wording from RC5ParameterSpec

2024-06-12 Thread Sean Mullan
On Wed, 12 Jun 2024 16:18:08 GMT, Ben Perez wrote: > The RC5ParameterSpec class description contains the following sentence: "This > class can be used to initialize a Cipher object that implements the RC5 > algorithm as supplied by RSA Security LLC, or any parties authorized by RSA > Security.

RFR: 8209092: Remove outdated wording from RC5ParameterSpec

2024-06-12 Thread Ben Perez
The RC5ParameterSpec class description contains the following sentence: "This class can be used to initialize a Cipher object that implements the RC5 algorithm as supplied by RSA Security LLC, or any parties authorized by RSA Security." The part "as supplied by RSA Security LLC, or any parties

Re: RFR: 8333867: SHA3 performance can be improved [v2]

2024-06-12 Thread Ferenc Rakoczi
> This PR removes some unnecessary conversions between byte arrays and long > arrays during SHA3 digest computations. Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision: Fix clone(), accept review suggestions. - Changes: