Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-18 Thread Anthony Scarpino
On Fri, 14 Jun 2024 09:14:50 GMT, Daniel JeliƄski wrote: >> Hi >> >> This change is to improve TLS 1.3 session resumption by allowing a TLS >> server to send more than one resumption ticket per connection and clients to >> store more. Resumption is a quick way to use an existing TLS session t

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-18 Thread John Jiang
On Wed, 19 Jun 2024 00:04:54 GMT, Anthony Scarpino wrote: >> src/java.base/share/classes/sun/security/ssl/NewSessionTicket.java line 369: >> >>> 367: if (SSLLogger.isOn && SSLLogger.isOn("ssl,handshake")) >>> { >>> 368: SSLLogger.fine("No session ticket prod

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-18 Thread Anthony Scarpino
On Tue, 18 Jun 2024 06:53:25 GMT, Andrey Turbanov wrote: >> Hi >> >> This change is to improve TLS 1.3 session resumption by allowing a TLS >> server to send more than one resumption ticket per connection and clients to >> store more. Resumption is a quick way to use an existing TLS session t

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-18 Thread Anthony Scarpino
On Tue, 18 Jun 2024 07:41:06 GMT, John Jiang wrote: >> Hi >> >> This change is to improve TLS 1.3 session resumption by allowing a TLS >> server to send more than one resumption ticket per connection and clients to >> store more. Resumption is a quick way to use an existing TLS session to >>

Re: RFR: 8333754: Add a Test against ECDSA and ECDH NIST Test vector

2024-06-18 Thread Anthony Scarpino
On Fri, 14 Jun 2024 06:23:32 GMT, Sibabrata Sahoo wrote: > Tests added against ECDSA and ECDH NIST Test vector. The changes look good to me. - Marked as reviewed by ascarpino (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19715#pullrequestreview-2126732468

Re: RFR: 8333583: Crypto-XDH.generateSecret regression after JDK-8329538 [v3]

2024-06-18 Thread Volodymyr Paprotski
On Tue, 18 Jun 2024 15:10:37 GMT, Vladimir Kozlov wrote: >> Volodymyr Paprotski has updated the pull request incrementally with one >> additional commit since the last revision: >> >> comment from Sandhya > > @TobiHartmann ran our testing and it passed. Thanks @vnkozlov @TobiHartmann !

Re: RFR: 8333583: Crypto-XDH.generateSecret regression after JDK-8329538 [v3]

2024-06-18 Thread Vladimir Kozlov
On Mon, 17 Jun 2024 16:38:55 GMT, Volodymyr Paprotski wrote: >> This fix recovers XDH performance but removes some of the P256 gains >> (~-8-14%). Still faster, but not as much. >> >> The fix is to undo 'int' return type on mult()/square(), which allowed to >> return partially reduced result (

Integrated: 8332524: Instead of printing "TLSv1.3," it is showing "TLS13"

2024-06-18 Thread Nibedita Jena
On Mon, 17 Jun 2024 14:22:28 GMT, Nibedita Jena wrote: > While doing SSL/TLS connection, start the Client with protocol TLSv1.2 and > Server with protocol TLSv1.3. During handshake process, the exception shows > as "javax.net.ssl.SSLHandshakeException: The client supported protocol > versions

Re: RFR: 8332524: Instead of printing "TLSv1.3, " it is showing "TLS13"

2024-06-18 Thread Sean Mullan
On Mon, 17 Jun 2024 14:22:28 GMT, Nibedita Jena wrote: > While doing SSL/TLS connection, start the Client with protocol TLSv1.2 and > Server with protocol TLSv1.3. During handshake process, the exception shows > as "javax.net.ssl.SSLHandshakeException: The client supported protocol > versions

RFR: 8324841: PKCS11 tests still skip execution

2024-06-18 Thread Matthew Donovan
In this PR, I updated PKCS11Test to throw a RuntimeException if the NSS binaries are not found in a directory specified with the property jdk.test.lib.artifacts.nsslib-. If the property is not specified, the tests will throw a SkippedException. - Commit messages: - 8324841: PKCS1

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-18 Thread John Jiang
On Wed, 29 May 2024 18:53:55 GMT, Anthony Scarpino wrote: > Hi > > This change is to improve TLS 1.3 session resumption by allowing a TLS server > to send more than one resumption ticket per connection and clients to store > more. Resumption is a quick way to use an existing TLS session to e

Re: RFR: 8333867: SHA3 performance can be improved [v4]

2024-06-18 Thread Ferenc Rakoczi
> This PR removes some unnecessary conversions between byte arrays and long > arrays during SHA3 digest computations. Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision: Copyright year update. - Changes: - all: https://