RFR: 8331163: Consider Trust Settings to select SSL certificate

2024-06-24 Thread Alexey Bakhtin
Please review a proposal to verify Trust Settings for Keychain key entries. Keychain-related Jtreg tests passed. - Commit messages: - 8331163: Consider Trust Settings to select SSL certificate Changes: https://git.openjdk.org/jdk/pull/19872/files Webrev: https://webrevs.openjdk.o

Re: RFR: 8333772: Incorrect Kerberos behavior when udp_preference_limit = 0

2024-06-24 Thread Weijun Wang
On Mon, 24 Jun 2024 14:50:39 GMT, Sean Mullan wrote: > Looks good. BTW, does MIT Kerberos also ignore negative values? Yes. I set it to -1 and `kinit` shows UDP is used. - PR Comment: https://git.openjdk.org/jdk/pull/19638#issuecomment-2187376877

Re: [External] : Status of project "Brisbane"?

2024-06-24 Thread Denis Gauthier
Thanks for asking, Volker. At this stage we're still bootstrapping the project and going through internal processes to publish its OpenJDK repositories with code. We’re also juggling other projects. I can let you know once the mailing list and repository are available. In the meantime, feel fre

Re: Missing element-list for https://docs.oracle.com/javase/8/docs/jre/api/security/jgss/spec

2024-06-24 Thread Osipov, Michael
On 2024-05-31 21:38, Jonathan Gibbons wrote: > Michael, > > There is no `element-list` file for any version of JDK before JDK 9. > Before JDK 9, the appropriate information was in the `package-list` > file. In JDK 9, with the introduction of modules, the format of the file > was updated to i

Re: RFR: 8333364: Minor cleanup could be done in com.sun.crypto.provider [v4]

2024-06-24 Thread Sean Mullan
On Fri, 14 Jun 2024 13:11:06 GMT, Mark Powers wrote: >> https://bugs.openjdk.org/browse/JDK-864 > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > move variables to above try block Some comments after reviewing part of it.

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS [v2]

2024-06-24 Thread Anthony Scarpino
> Hi > > This change is to improve TLS 1.3 session resumption by allowing a TLS server > to send more than one resumption ticket per connection and clients to store > more. Resumption is a quick way to use an existing TLS session to establish > another session by avoiding the long TLS full han

RFR: 8334670: SSLSocketOutputRecord buffer miscalculation

2024-06-24 Thread Anthony Scarpino
Hi, I need a review to change the a fragment buffer size miscalculation error. This appears when there are large handshake messages and hasn't been observed during application data. This was found during testing of the NewSessionTicket change in [JDK-8328608](https://bugs.openjdk.org/browse/

Re: RFR: 8333583: Crypto-XDH.generateSecret regression after JDK-8329538 [v3]

2024-06-24 Thread Volodymyr Paprotski
On Mon, 24 Jun 2024 14:48:43 GMT, Ferenc Rakoczi wrote: >> @ferakocz just tagging you as reminder of (the many) items in your queue :) >> Thanks! > >> @ferakocz just tagging you as reminder of (the many) items in your queue :) >> Thanks! > > Sorry, I was out of office last week. I will take a

Re: RFR: 8333772: Incorrect Kerberos behavior when udp_preference_limit = 0

2024-06-24 Thread Sean Mullan
On Mon, 10 Jun 2024 20:29:54 GMT, Weijun Wang wrote: > Allow `udp_preference_limit = 0` to force TCP. > > The reason for this bug is that it was read in a similar way as `kdc_timeout` > and `max_retries`, both must be positive to have effect. Looks good. BTW, does MIT Kerberos also ignore nega

Re: RFR: 8333583: Crypto-XDH.generateSecret regression after JDK-8329538 [v3]

2024-06-24 Thread Ferenc Rakoczi
On Thu, 20 Jun 2024 18:32:14 GMT, Volodymyr Paprotski wrote: > @ferakocz just tagging you as reminder of (the many) items in your queue :) > Thanks! Sorry, I was out of office last week. I will take a deeper look at the changes tomorrow, but I have a question based on my first look at it: Do y

[jdk23] RFR: 8324841: PKCS11 tests still skip execution

2024-06-24 Thread Matthew Donovan
8324841: PKCS11 tests still skip execution - Commit messages: - Backport 9d4a4bd2c2a4bd16bbc80b602b15b448c52220f6 Changes: https://git.openjdk.org/jdk/pull/19857/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19857&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324

RFR: 8333317: Test sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java failed with: Invalid ECDH ServerKeyExchange signature

2024-06-24 Thread Matthew Donovan
In this PR, I updated the version of NSS to 3.101 and removed the test from the ProblemList for all platforms but linux-ppc64le (that bug is still outstanding.) I also updated the skipTest logic in TestDSAKeyLength.java. Prior to my change, it compared the version numbers as double values but th

Integrated: 8324841: PKCS11 tests still skip execution

2024-06-24 Thread Matthew Donovan
On Tue, 18 Jun 2024 12:13:13 GMT, Matthew Donovan wrote: > In this PR, I updated PKCS11Test to throw a RuntimeException if the NSS > binaries are not found in a directory specified with the property > jdk.test.lib.artifacts.nsslib-. If the property is not specified, > the tests will throw a S