[jdk23] RFR: 8326705: Test CertMsgCheck.java fails to find alert certificate_required

2024-06-26 Thread Anthony Scarpino
Hi, I need a review of this clean backport of this test fix to jdk23. Tony - Commit messages: - Backport 4ffc5e60776353b03e9a557c39148e378b1690e2 Changes: https://git.openjdk.org/jdk/pull/19917/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19917&range=00 Issue: https:

Integrated: 8334670: SSLSocketOutputRecord buffer miscalculation

2024-06-26 Thread Anthony Scarpino
On Mon, 24 Jun 2024 15:57:57 GMT, Anthony Scarpino wrote: > Hi, > > I need a review to change the a fragment buffer size miscalculation error. > This appears when there are large handshake messages and hasn't been observed > during application data. This was found during testing of the >

Re: RFR: 8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test

2024-06-26 Thread Weijun Wang
On Wed, 26 Jun 2024 15:23:47 GMT, Weijun Wang wrote: >> The following test: >> **com/sun/security/auth/callback/TextCallbackHandler/Default.java** is >> currently marked to be run manually because user inputs are required in the >> console, but instead it can be automated by providing a custom

[jdk23] Integrated: 8333583: Crypto-XDH.generateSecret regression after JDK-8329538

2024-06-26 Thread Volodymyr Paprotski
On Tue, 25 Jun 2024 23:50:20 GMT, Volodymyr Paprotski wrote: > Hi all, > > This pull request contains a backport of commit > [f101e153](https://github.com/openjdk/jdk/commit/f101e153cee68750fcf1f12da10e29806875b522) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The com

Re: [jdk23] RFR: 8333583: Crypto-XDH.generateSecret regression after JDK-8329538

2024-06-26 Thread Sandhya Viswanathan
On Tue, 25 Jun 2024 23:50:20 GMT, Volodymyr Paprotski wrote: > Hi all, > > This pull request contains a backport of commit > [f101e153](https://github.com/openjdk/jdk/commit/f101e153cee68750fcf1f12da10e29806875b522) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The com

Re: RFR: 8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test

2024-06-26 Thread Weijun Wang
On Wed, 19 Jun 2024 12:47:33 GMT, Fernando Guallini wrote: > The following test: > **com/sun/security/auth/callback/TextCallbackHandler/Default.java** is > currently marked to be run manually because user inputs are required in the > console, but instead it can be automated by providing a cus

Re: RFR: 8334441: Mark tests in jdk_security_infra group as manual [v2]

2024-06-26 Thread Rajan Halade
On Tue, 25 Jun 2024 17:45:23 GMT, Andrew John Hughes wrote: > Is there still going to be some monitoring of these tests? Making it harder > to run these tests potentially means that genuine failures can go unnoticed > and JDK certificates are not updated when needed. Tracking won’t be any diff

Integrated: 8326705: Test CertMsgCheck.java fails to find alert certificate_required

2024-06-26 Thread Anthony Scarpino
On Wed, 5 Jun 2024 02:57:41 GMT, Anthony Scarpino wrote: > Hi, > > I need a review for this simple change to fix a threading problem with the > test. The server thread was not completing before the check occurred on the > main thread. The failure showed up in windows and macos, but not linux.

Re: RFR: 8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test

2024-06-26 Thread Fernando Guallini
On Wed, 19 Jun 2024 12:47:33 GMT, Fernando Guallini wrote: > The following test: > **com/sun/security/auth/callback/TextCallbackHandler/Default.java** is > currently marked to be run manually because user inputs are required in the > console, but instead it can be automated by providing a cus