On Fri, 19 Jul 2024 17:24:04 GMT, Hai-May Chao wrote:
> 8327538: The SSLExtension class specifies incorrect values for heartbeat per
> RFC 6520 and post_handshake_auth per RFC 8446
LGTM.
Since we don't support either extension, either add a regression test that
searches a provided hardcoded
On Sat, 6 Jul 2024 00:15:04 GMT, Shaojin Wen wrote:
>> String.format is widely used, and improving its performance is very
>> meaningful. This PR can significantly improve the performance of
>> String.format. Sorry, there are many changes, which will take a lot of time.
>> I hope you can revie
On Fri, 19 Jul 2024 14:04:12 GMT, Fernando Guallini
wrote:
> > LGTM. Have you run test with iterations to ensure stability. This will be a
> > tier1 test so intermittent failures are not acceptable.
>
> 👍 This is a manual test. In any case it's stable, it was successfully ran
> hundreds of ti
On Fri, 19 Jul 2024 09:32:20 GMT, Fernando Guallini
wrote:
>> The manual test Cipher/DES/PerformanceTest.java fails with
>> ArithmeticException due to potential division by zero. The issue arises when
>> calculating the elapsed time using end - start, which could result in zero
>> millisecond
On Wed, 17 Jul 2024 16:32:09 GMT, Martin Balao wrote:
>> Hi,
>>
>> I'd like to make a proposal to fix
>> [JDK-8336499](https://bugs.openjdk.org/browse/JDK-8336499).
>>
>> With the proposed change, a non-sensitive RSA private key is first
>> interpreted as a CRT key. If that fails (e.g. one of
On Fri, 19 Jul 2024 17:24:04 GMT, Hai-May Chao wrote:
> 8327538: The SSLExtension class specifies incorrect values for heartbeat per
> RFC 6520 and post_handshake_auth per RFC 8446
I double-checked the RFC, and these are the correct values. Looks good!
-
PR Comment: https://git.op
On Wed, 17 Jul 2024 00:48:20 GMT, Valerie Peng wrote:
> Can someone help review this fix? Changed the required-mechanism check by
> checking if the particular mechanism is inside the list of enabled supported
> mechanisms. This should be more reliable than calling C_GetMechanismInfo(..)
> on t
8327538: The SSLExtension class specifies incorrect values for heartbeat per
RFC 6520 and post_handshake_auth per RFC 8446
-
Commit messages:
- 8327538: The SSLExtension class specifies incorrect values for heartbeat per
RFC 6520 and post_handshake_auth per RFC 8446
Changes: https
On Fri, 19 Jul 2024 05:47:15 GMT, David Holmes wrote:
> Before RC we need to update the man pages in the repo from their Markdown
> sources. All pages at a minimum have 23-ea replaced with 23, and publication
> year set to 2024 if needed.
>
> This also picks up the unpublished changes to java.
On Fri, 19 Jul 2024 00:23:27 GMT, Hai-May Chao wrote:
> LGTM.
Thanks Haimay for the review~
-
PR Comment: https://git.openjdk.org/jdk/pull/20207#issuecomment-2239553542
On Fri, 19 Jul 2024 13:11:05 GMT, Chen Liang wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove docroot based on review
>
> src/java.base/share/classes/java/lang/foreign/Arena.java line 64:
>
>> 62: * such,
On Fri, 19 Jul 2024 14:20:48 GMT, Nizar Benalla wrote:
>> Can I get a review for this change that fixes some broken links in javadoc
>> comments? The new docs are hosted
>> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
>>
>> It's mostly fixing some relative li
On Fri, 19 Jul 2024 14:20:48 GMT, Nizar Benalla wrote:
>> Can I get a review for this change that fixes some broken links in javadoc
>> comments? The new docs are hosted
>> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
>>
>> It's mostly fixing some relative li
On Fri, 19 Jul 2024 14:05:07 GMT, Nizar Benalla wrote:
>> Can I get a review for this change that fixes some broken links in javadoc
>> comments? The new docs are hosted
>> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
>>
>> It's mostly fixing some relative li
> Can I get a review for this change that fixes some broken links in javadoc
> comments? The new docs are hosted
> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
>
> It's mostly fixing some relative links.
> If using `{@docroot}` isn't ideal I can change it.
>
>
On Fri, 19 Jul 2024 13:08:06 GMT, Nizar Benalla wrote:
>> Can I get a review for this change that fixes some broken links in javadoc
>> comments? The new docs are hosted
>> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
>>
>> It's mostly fixing some relative li
On Fri, 19 Jul 2024 09:32:20 GMT, Fernando Guallini
wrote:
>> The manual test Cipher/DES/PerformanceTest.java fails with
>> ArithmeticException due to potential division by zero. The issue arises when
>> calculating the elapsed time using end - start, which could result in zero
>> millisecond
> Can I get a review for this change that fixes some broken links in javadoc
> comments? The new docs are hosted
> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
>
> It's mostly fixing some relative links.
> If using `{@docroot}` isn't ideal I can change it.
>
>
On Fri, 19 Jul 2024 13:08:06 GMT, Nizar Benalla wrote:
>> Can I get a review for this change that fixes some broken links in javadoc
>> comments? The new docs are hosted
>> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
>>
>> It's mostly fixing some relative li
> Can I get a review for this change that fixes some broken links in javadoc
> comments? The new docs are hosted
> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
>
> It's mostly fixing some relative links.
> If using `{@docroot}` isn't ideal I can change it.
>
>
On Fri, 19 Jul 2024 12:44:47 GMT, Daniel Jeliński wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove docroot based on review
>
> src/java.base/share/classes/java/util/concurrent/StructuredTaskScope.java
> lin
On Fri, 19 Jul 2024 11:11:38 GMT, Nizar Benalla wrote:
> Can I get a review for this change that fixes some broken links in javadoc
> comments? The new docs are hosted
> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
>
> It's mostly fixing some relative links.
On Fri, 19 Jul 2024 11:11:38 GMT, Nizar Benalla wrote:
> Can I get a review for this change that fixes some broken links in javadoc
> comments? The new docs are hosted
> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
>
> It's mostly fixing some relative links.
Can I get a review for this change that fixes some broken links in javadoc
comments? The new docs are hosted
[here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
It's mostly fixing some relative links.
If using `{@docroot}` isn't ideal I can change it.
Here is the res
> The manual test Cipher/DES/PerformanceTest.java fails with
> ArithmeticException due to potential division by zero. The issue arises when
> calculating the elapsed time using end - start, which could result in zero
> milliseconds if start and end are identical due to the high speed of
> execu
On Fri, 19 Jul 2024 05:47:15 GMT, David Holmes wrote:
> Before RC we need to update the man pages in the repo from their Markdown
> sources. All pages at a minimum have 23-ea replaced with 23, and publication
> year set to 2024 if needed.
>
> This also picks up the unpublished changes to java.
Before RC we need to update the man pages in the repo from their Markdown
sources. All pages at a minimum have 23-ea replaced with 23, and publication
year set to 2024 if needed.
This also picks up the unpublished changes to java.1 from:
- [JDK-8324836](https://bugs.openjdk.org/browse/JDK-83248
27 matches
Mail list logo
