On Tue, 24 Sep 2024 21:39:32 GMT, Kevin Driver wrote:
>> src/java.base/share/classes/javax/crypto/KDF.java line 546:
>>
>>> 544: if (checkSpiNonNull(theOne)) return;
>>> 545:
>>> 546: synchronized (lock) {
>>
>> Sorry I missed this last time. The `if (checkSpiNonNull(theOne)` c
On Tue, 24 Sep 2024 18:26:06 GMT, Weijun Wang wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> additional DPS tests, removal of private method
>
> src/java.base/share/classes/javax/crypto/KDF.java line 546:
>
>> 54
On Tue, 24 Sep 2024 14:27:25 GMT, Bernd wrote:
> Can’t review it, still don’t understand how the error condition happens. (But
> I do know massive problems with extra messages sent when a broken connection
> is wound down - it might want to use aggressive timeouts for those graticious
> messag
On Wed, 11 Sep 2024 09:07:15 GMT, Fernando Guallini
wrote:
> During the code review of
> [JDK-8337664](https://bugs.openjdk.org/browse/JDK-8337664), several
> non-critical comments were raised but not addressed due to time constraints.
> This PR includes the following changes:
>
> 1. Symante
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
>
> Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924).
Kevin Driver
On Tue, 24 Sep 2024 16:04:58 GMT, Artur Barashev wrote:
> https://bugs.openjdk.org/browse/JDK-8340670
This pull request has now been integrated.
Changeset: e3d80f1e
Author:Artur Barashev
Committer: Sean Mullan
URL:
https://git.openjdk.org/jdk/commit/e3d80f1e1e8b5d503f13b8037172e3da
On Tue, 24 Sep 2024 17:53:48 GMT, Artur Barashev wrote:
>> https://bugs.openjdk.org/browse/JDK-8340670
>
> Artur Barashev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update copyright
@artur-oracle
Your change (at version 2b1c9b03ff2cb
On Mon, 23 Sep 2024 20:16:49 GMT, Kevin Driver wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are
>> cryptographic algorithms for deriving additional keys from a secret key and
>> other data. See [JEP 478](https://openjdk.org/jeps/478).
>>
>> Work was begun in [another P
On Tue, 24 Sep 2024 17:53:48 GMT, Artur Barashev wrote:
>> https://bugs.openjdk.org/browse/JDK-8340670
>
> Artur Barashev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update copyright
Marked as reviewed by mullan (Reviewer).
--
On Mon, 23 Sep 2024 17:47:17 GMT, Kevin Driver wrote:
>> src/java.base/share/classes/javax/crypto/KDF.java line 653:
>>
>>> 651: pdebug.println(
>>> 652: "The evaluated provider does not support
>>> the "
>>> 653: + "sp
On Tue, 24 Sep 2024 17:44:11 GMT, Sean Mullan wrote:
>> Artur Barashev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update copyright
>
> src/java.base/share/classes/java/security/Policy.java line 1:
>
>> 1: /*
>
> One other comment,
> https://bugs.openjdk.org/browse/JDK-8340670
Artur Barashev has updated the pull request incrementally with one additional
commit since the last revision:
Update copyright
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21165/files
- new: https://git.openjdk.org/jdk/pull/
On Tue, 24 Sep 2024 16:34:25 GMT, Weijun Wang wrote:
> To prepare for new PQC algorithms like ML-KEM and ML-DSA where there are only
> named standardized parameter sets, a common framework is introduced.
>
> A example of EdDSA implementation using this framework is included as a test.
Can you
On Tue, 24 Sep 2024 16:04:58 GMT, Artur Barashev wrote:
> https://bugs.openjdk.org/browse/JDK-8340670
Marked as reviewed by mullan (Reviewer).
src/java.base/share/classes/java/security/Policy.java line 1:
> 1: /*
One other comment, please update the last copyright date to 2024 on this file.
On Tue, 24 Sep 2024 17:08:54 GMT, Artur Barashev wrote:
> > I think this fix is trivial and obvious enough that you don't need a test;
> > however if you don't plan to add one, please add a noreg-trivial label to
> > the bug so that it doesn't get flagged as missing a test.
>
> Yes, I also tho
On Tue, 24 Sep 2024 16:49:50 GMT, Sean Mullan wrote:
> I think this fix is trivial and obvious enough that you don't need a test;
> however if you don't plan to add one, please add a noreg-trivial label to the
> bug so that it doesn't get flagged as missing a test.
Yes, I also thought the fix
On Tue, 24 Sep 2024 16:48:26 GMT, Sean Mullan wrote:
>> https://bugs.openjdk.org/browse/JDK-8340670
>
> src/java.base/share/classes/java/security/Policy.java line 907:
>
>> 905: @Override
>> 906: public boolean isReadOnly() {
>> 907: return perms.isReadOnly();
>
> Yo
On Tue, 24 Sep 2024 16:04:58 GMT, Artur Barashev wrote:
> https://bugs.openjdk.org/browse/JDK-8340670
I think this fix is trivial and obvious enough that you don't need a test;
however if you don't plan to add one, please add a noreg-trivial label to the
bug so that it doesn't get flagged as m
To prepare for new PQC algorithms like ML-KEM and ML-DSA where there are only
named standardized parameter sets, a common framework is introduced.
A example of EdDSA implementation using this framework is included as a test.
-
Commit messages:
- the fix
Changes: https://git.openjd
On Tue, 24 Sep 2024 15:57:28 GMT, Sean Mullan wrote:
>> During the code review of
>> [JDK-8337664](https://bugs.openjdk.org/browse/JDK-8337664), several
>> non-critical comments were raised but not addressed due to time constraints.
>> This PR includes the following changes:
>>
>> 1. Symantec
https://bugs.openjdk.org/browse/JDK-8340670
-
Commit messages:
- 8340670: Policy.UNSUPPORTED_EMPTY_COLLECTION.isReadOnly does not return true
Changes: https://git.openjdk.org/jdk/pull/21165/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21165&range=00
Issue: https://bugs
On Wed, 11 Sep 2024 09:07:15 GMT, Fernando Guallini
wrote:
> During the code review of
> [JDK-8337664](https://bugs.openjdk.org/browse/JDK-8337664), several
> non-critical comments were raised but not addressed due to time constraints.
> This PR includes the following changes:
>
> 1. Symante
On Mon, 23 Sep 2024 20:21:53 GMT, Artur Barashev wrote:
>> https://bugs.openjdk.org/browse/JDK-8331682
>
> Artur Barashev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Spell user_canceled instead of user_cancelled as per RFC
Can’t review
On Wed, 11 Sep 2024 15:03:43 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8336665
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> another comment from Sean
src/java.base/share/classes/sun/security/x509/X50
24 matches
Mail list logo
