RFR: 8298387: Implementing ML-DSA signature algorithm

2024-10-04 Thread Ben Perez
Java implementation of ML-DSA, the FIPS 204 post-quantum signature scheme https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.204.pdf. Depends on https://github.com/openjdk/jdk/pull/21167 - Commit messages: - ML_DSA and ML_DSA_Provider functionality - Merge branch 'master' into 83403

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v8]

2024-10-04 Thread Weijun Wang
> To prepare for new PQC algorithms like ML-KEM and ML-DSA where there are only > named standardized parameter sets, a common framework is introduced. > > A example of EdDSA implementation using this framework is included as a test. Weijun Wang has updated the pull request incrementally with one

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v6]

2024-10-04 Thread Kevin Driver
On Fri, 4 Oct 2024 17:45:03 GMT, Weijun Wang wrote: >> See also: checking the `spec` parameter in `engineNewEncapsulator`, which >> does use `InvalidParameterException`. > > We only have child classes inside JDK, therefore if the convention is not > followed, it's treated as a programming error

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v6]

2024-10-04 Thread Kevin Driver
On Fri, 4 Oct 2024 17:38:37 GMT, Weijun Wang wrote: >> src/java.base/share/classes/sun/security/pkcs/NamedPKCS8Key.java line 54: >> >>> 52: >>> 53: /// Ctor from family name, parameter set name, raw key bytes. >>> 54: /// Key bytes won't be cloned, caller must relinquish ownership >> >

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v6]

2024-10-04 Thread Kevin Driver
On Fri, 4 Oct 2024 17:40:39 GMT, Weijun Wang wrote: >> src/java.base/share/classes/sun/security/pkcs/NamedPKCS8Key.java line 55: >> >>> 53: /// Ctor from family name, parameter set name, raw key bytes. >>> 54: /// Key bytes won't be cloned, caller must relinquish ownership >>> 55: pu

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v7]

2024-10-04 Thread Weijun Wang
> To prepare for new PQC algorithms like ML-KEM and ML-DSA where there are only > named standardized parameter sets, a common framework is introduced. > > A example of EdDSA implementation using this framework is included as a test. Weijun Wang has updated the pull request incrementally with one

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v6]

2024-10-04 Thread Weijun Wang
On Fri, 4 Oct 2024 16:21:56 GMT, Kevin Driver wrote: >> src/java.base/share/classes/sun/security/provider/NamedKEM.java line 62: >> >>> 60: this.fname = Objects.requireNonNull(fname); >>> 61: if (pnames == null || pnames.length == 0) { >>> 62: throw new AssertionError

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v6]

2024-10-04 Thread Weijun Wang
On Fri, 4 Oct 2024 16:41:14 GMT, Kevin Driver wrote: >> src/java.base/share/classes/sun/security/provider/NamedKeyPairGenerator.java >> line 144: >> >>> 142: /// @return public key and private key (in this order) in raw bytes >>> 143: /// @throws ProviderException if there is an interna

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v6]

2024-10-04 Thread Weijun Wang
On Fri, 4 Oct 2024 16:10:57 GMT, Kevin Driver wrote: >> Weijun Wang has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commits si

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v6]

2024-10-04 Thread Weijun Wang
On Fri, 4 Oct 2024 13:05:57 GMT, Sean Mullan wrote: >> Weijun Wang has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commits sin

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v6]

2024-10-04 Thread Kevin Driver
On Thu, 3 Oct 2024 17:40:22 GMT, Weijun Wang wrote: >> To prepare for new PQC algorithms like ML-KEM and ML-DSA where there are >> only named standardized parameter sets, a common framework is introduced. >> >> A example of EdDSA implementation using this framework is included as a test. > > We

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v6]

2024-10-04 Thread Kevin Driver
On Thu, 3 Oct 2024 17:40:22 GMT, Weijun Wang wrote: >> To prepare for new PQC algorithms like ML-KEM and ML-DSA where there are >> only named standardized parameter sets, a common framework is introduced. >> >> A example of EdDSA implementation using this framework is included as a test. > > We

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v6]

2024-10-04 Thread Kevin Driver
On Fri, 4 Oct 2024 13:09:53 GMT, Sean Mullan wrote: >> Weijun Wang has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commits sin

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v6]

2024-10-04 Thread Kevin Driver
On Thu, 3 Oct 2024 17:40:22 GMT, Weijun Wang wrote: >> To prepare for new PQC algorithms like ML-KEM and ML-DSA where there are >> only named standardized parameter sets, a common framework is introduced. >> >> A example of EdDSA implementation using this framework is included as a test. > > We

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v6]

2024-10-04 Thread Kevin Driver
On Fri, 4 Oct 2024 16:18:29 GMT, Kevin Driver wrote: >> Weijun Wang has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commits si

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v6]

2024-10-04 Thread Kevin Driver
On Thu, 3 Oct 2024 17:40:22 GMT, Weijun Wang wrote: >> To prepare for new PQC algorithms like ML-KEM and ML-DSA where there are >> only named standardized parameter sets, a common framework is introduced. >> >> A example of EdDSA implementation using this framework is included as a test. > > We

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v6]

2024-10-04 Thread Kevin Driver
On Thu, 3 Oct 2024 17:40:22 GMT, Weijun Wang wrote: >> To prepare for new PQC algorithms like ML-KEM and ML-DSA where there are >> only named standardized parameter sets, a common framework is introduced. >> >> A example of EdDSA implementation using this framework is included as a test. > > We

Re: RFR: 8331682: Slow networks/Impatient clients can potentially send unencrypted TLSv1.3 alerts that won't parse on the server [v13]

2024-10-04 Thread Artur Barashev
> Check for unexpected plaintext alert message during TLSv1.3 handshake. This > can happen if client doesn't receive ServerHello due to network timeout and > tries to close the connection by sending an alert message. Artur Barashev has updated the pull request incrementally with one additional

Re: RFR: 8331682: Slow networks/Impatient clients can potentially send unencrypted TLSv1.3 alerts that won't parse on the server [v12]

2024-10-04 Thread Artur Barashev
> Check for unexpected plaintext alert message during TLSv1.3 handshake. This > can happen if client doesn't receive ServerHello due to network timeout and > tries to close the connection by sending an alert message. Artur Barashev has updated the pull request incrementally with one additional

Re: RFR: 8331682: Slow networks/Impatient clients can potentially send unencrypted TLSv1.3 alerts that won't parse on the server [v11]

2024-10-04 Thread Artur Barashev
> Check for unexpected plaintext alert message during TLSv1.3 handshake. This > can happen if client doesn't receive ServerHello due to network timeout and > tries to close the connection by sending an alert message. Artur Barashev has updated the pull request incrementally with one additional

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v6]

2024-10-04 Thread Sean Mullan
On Thu, 3 Oct 2024 17:40:22 GMT, Weijun Wang wrote: >> To prepare for new PQC algorithms like ML-KEM and ML-DSA where there are >> only named standardized parameter sets, a common framework is introduced. >> >> A example of EdDSA implementation using this framework is included as a test. > > We

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v6]

2024-10-04 Thread Sean Mullan
On Thu, 3 Oct 2024 17:40:22 GMT, Weijun Wang wrote: >> To prepare for new PQC algorithms like ML-KEM and ML-DSA where there are >> only named standardized parameter sets, a common framework is introduced. >> >> A example of EdDSA implementation using this framework is included as a test. > > We