On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Thu, 24 Oct 2024 07:07:35 GMT, Xue-Lei Andrew Fan wrote:
>> Artur Barashev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update Copyright
>
> src/java.base/share/classes/sun/security/ssl/SSLCipher.java line 1878:
>
>> 1876:
On Thu, 24 Oct 2024 20:23:26 GMT, Alexey Ivanov wrote:
>> @aivanov-jdk
>> It was missed when -Djava.security.manager=allow was removed.
>> Out of curiosity: does it have any impact on the performance of CI testing
>> if tests are run in `/othervm` mode when it is not needed?
>
>> It was missed
On Thu, 24 Oct 2024 17:27:33 GMT, Alexey Ivanov wrote:
> > I think we have finally decided that jtreg tag will come after copyright
> > and before imports...Applicable for all modified javax_swing tests in this
> > PR...
>
> Did we agree on that?
Atleast client-dev team did..
See this initial
On Mon, 21 Oct 2024 18:18:12 GMT, Vladimir Ivanov wrote:
> This patch remove access to the shared variable to fix scalability issue in
> the multithread environment. According to testing by the
> specjvm2008::crypto.rsa the one thread performance reduced for less than 1%
> while the score for
On Thu, 24 Oct 2024 18:49:58 GMT, Xue-Lei Andrew Fan wrote:
> > The goal is to help users to debug this situation so we provide the only
> > possible cause we know about.
>
> Then you introduce more confusing for your unknown parts. You may never know
> why it happens but it just happens. What
Many OpenJDK micros use `@Fork(jvmArgs/-Append/-Prepend)` to add JVM reasonable
or necessary flags, but when deploying and running micros we often want to add
or replace flags to tune to the machine, test different GCs, etc. The
inconsistent use of the different `jvmArgs` options make it error p
> This is the implementation of JEP 486: Permanently Disable the Security
> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
> main changes in the JEP and also includes an apidiff of the specif
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Wed, 23 Oct 2024 21:14:23 GMT, Valerie Peng wrote:
>> Hannes Wallnöfer has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update copyright header dates
>
> Is "https://tools.ietf.org/html/rfc8103"; considered external spec? It is
> ment
On Thu, 24 Oct 2024 17:58:55 GMT, Harshitha Onkar wrote:
> It was missed when `-Djava.security.manager=allow` was removed.
It wasn't intentional then, was it?
> Out of curiosity: does it have any impact on the performance of CI testing if
> tests are run in /othervm mode when it is not needed?
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Mon, 21 Oct 2024 18:18:12 GMT, Vladimir Ivanov wrote:
> This patch remove access to the shared variable to fix scalability issue in
> the multithread environment. According to testing by the
> specjvm2008::crypto.rsa the one thread performance reduced for less than 1%
> while the score for
> Check for unexpected plaintext alert message during TLSv1.3 handshake. This
> can happen if client doesn't receive ServerHello due to network timeout and
> tries to close the connection by sending an alert message.
Artur Barashev has updated the pull request incrementally with one additional
On Mon, 21 Oct 2024 18:18:12 GMT, Vladimir Ivanov wrote:
> This patch remove access to the shared variable to fix scalability issue in
> the multithread environment. According to testing by the
> specjvm2008::crypto.rsa the one thread performance reduced for less than 1%
> while the score for
On Fri, 9 Aug 2024 17:22:56 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-8336665
This pull request has now been integrated.
Changeset: ca1700b8
Author:Mark Powers
URL:
https://git.openjdk.org/jdk/commit/ca1700b8bf3b7b34616c469837748ac4c3607dfc
Stats: 93 lines in
On Thu, 24 Oct 2024 16:11:18 GMT, Alexey Ivanov wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 150 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Merge
>> - Updat
On Thu, 24 Oct 2024 16:35:44 GMT, Alexey Ivanov wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 150 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Merge
>> - Updat
On Thu, 24 Oct 2024 15:38:59 GMT, Artur Barashev wrote:
> The goal is to help users to debug this situation so we provide the only
> possible cause we know about.
Then you introduce more confusing for your unknown parts. You may never know
why it happens but it just happens. What we want to
On Thu, 24 Oct 2024 18:09:04 GMT, Harshitha Onkar wrote:
>> src/java.desktop/share/classes/java/awt/Desktop.java line 713:
>>
>>> 711: * {@code Info.plist}.
>>> 712: *
>>> 713: * @param printFileHandler handler
>>
>> Suggestion:
>>
>> * @param printFileHandler handler
>>
On Wed, 23 Oct 2024 14:06:25 GMT, Weijun Wang wrote:
> If the upstream file hasn’t changed, that’s fine. I was just curious why the
> year included (for Ludovic) hasn’t been updated as well.
Yup, same here. Since the upstream file is the same, I only update the changed
files.
Thanks for the re
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Wed, 23 Oct 2024 21:54:25 GMT, Sean Mullan wrote:
>> test/jdk/java/lang/RuntimeTests/exec/ExecCommand.java line 241:
>>
>>> 239: Properties props = System.getProperties();
>>> 240: props.setProperty(JDK_LANG_PROCESS_ALLOW_AMBIGUOUS_COMMANDS,
>>> "");
>>> 241: System.s
On Mon, 21 Oct 2024 18:18:12 GMT, Vladimir Ivanov wrote:
> This patch remove access to the shared variable to fix scalability issue in
> the multithread environment. According to testing by the
> specjvm2008::crypto.rsa the one thread performance reduced for less than 1%
> while the score for
On Thu, 24 Oct 2024 14:55:57 GMT, Alexey Ivanov wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 150 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Merge
>> - Updat
On Thu, 24 Oct 2024 17:16:54 GMT, Alexey Ivanov wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 150 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Merge
>> - Updat
On Thu, 24 Oct 2024 13:52:57 GMT, Claes Redestad wrote:
> Many OpenJDK micros use `@Fork(jvmArgs/-Append/-Prepend)` to add JVM
> reasonable or necessary flags, but when deploying and running micros we often
> want to add or replace flags to tune to the machine, test different GCs, etc.
> The i
On Wed, 23 Oct 2024 02:56:30 GMT, Prasanta Sadhukhan
wrote:
>> Agreed. This is not a "clean up / update tests" task.
>> If it is a change on some lines of code that are updated by the SM changes,
>> then that's fair game, but otherwise only the SM behaviour is part of this
>> task.
>> Anything
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Thu, 24 Oct 2024 13:52:57 GMT, Claes Redestad wrote:
> Many OpenJDK micros use `@Fork(jvmArgs/-Append/-Prepend)` to add JVM
> reasonable or necessary flags, but when deploying and running micros we often
> want to add or replace flags to tune to the machine, test different GCs, etc.
> The i
On Tue, 22 Oct 2024 15:48:54 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8336665
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> more precise comment
Marked as reviewed by mullan (Reviewer).
On Thu, 24 Oct 2024 11:32:27 GMT, Coleen Phillimore wrote:
>> Right, although you might have to wait until there is more cleanup in the
>> JDK code before they disappear completely. To clarify, most uses of
>> privileged actions are only done when a SecurityManager is set but there
>> some cas
On Thu, 24 Oct 2024 07:15:53 GMT, Alan Bateman wrote:
>> but you won't see access_controller_klass or priviledged_action_klass
>> frames, so no need to skip them? Not sure why you'd want to skip class
>> loader frames here.
>
> Right, although you might have to wait until there is more cleanup
On Thu, 24 Oct 2024 07:11:16 GMT, David Holmes wrote:
> > the way I did it I'd have to force push
>
> That should not be the case. You can just anti-delta changes.
I did it in a really inefficient way, by checking out all files except for the
files that I wanted to stay. I could not figure out
> After 8339120, gcc began catching many different instances of unused code in
> the Windows specific codebase. Some of these seem to be bugs. I've taken the
> effort to mark out all the relevant globals and locals that trigger the
> unused warnings and addressed all of them by commenting out th
On Wed, 23 Oct 2024 11:58:26 GMT, Alan Bateman wrote:
>> test/jdk/java/lang/invoke/RevealDirectTest.java line 33:
>>
>>> 31: * @test
>>> 32: * @summary verify Lookup.revealDirect on a variety of input handles,
>>> with security manager
>>> 33: * @run
>>> main/othervm/policy=jtreg.security.p
On Wed, 23 Oct 2024 19:50:19 GMT, Rajan Halade wrote:
>> Fernando Guallini has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reusing Utils.CopyFiles
>
> test/jdk/sun/security/pkcs11/PKCS11Test.java line 250:
>
>> 248: }
>> 249:
>> 25
On Thu, 24 Oct 2024 02:23:19 GMT, Valerie Peng wrote:
>> src/java.base/share/classes/java/security/package-info.java line 82:
>>
>>> 80: *
>>> 81: *
>>> 82: * @spec security/standard-names.html Java Security Standard Algorithm
>>> Names
>>
>> How about the other 2 under `Package Specificat
On Wed, 23 Oct 2024 19:43:33 GMT, Matthew Donovan wrote:
>> Fernando Guallini has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains seven additional
>
> The test sun/security/pkcs11/Provider/RequiredMechCheck.java extends
> sun/security/pkcs11/PKCS11Test.java, which sets up a PKCS11Provider
> configured with NSS config files located in the source tree directory
> (sun/security/pkcs11/nss) for the dependent tests to run properly. This test
> c
> Several tests currently use weak key and salt sizes. Since the purpose of
> these tests is not to evaluate weak keys, they can be updated to use stronger
> keys length (2048-bits) and stronger Salt (16 bytes). This PR does not intend
> to update the tests to use stronger algorithms.
>
> There
> Several tests are identified to use weak key parameters (prime modulus,
> private/public values) and certs with weak keys. As these tests purpose is
> not to exercise weak keys, these are updated in this PR to use a modulus with
> 2048-bit, base 2 and certificates with key size 2048
Fernando
On Wed, 23 Oct 2024 21:39:13 GMT, Valerie Peng wrote:
> Maybe it's due to the reference is in the javadoc for a pkg private method?
That may be why Jon's automated update didn't pick it up, but note that this is
an interface so `getAlgorithm()` is actually a public method. I'll add the
`@spec`
On Wed, 23 Oct 2024 19:51:24 GMT, Rajan Halade wrote:
>> The test sun/security/pkcs11/Provider/RequiredMechCheck.java extends
>> sun/security/pkcs11/PKCS11Test.java, which sets up a PKCS11Provider
>> configured with NSS config files located in the source tree directory
>> (sun/security/pkcs11/
On Wed, 23 Oct 2024 19:15:01 GMT, Coleen Phillimore wrote:
>> This tracing skips ClassLoader frames, you'll continue to see these when
>> using Class.forName.
>
> but you won't see access_controller_klass or priviledged_action_klass frames,
> so no need to skip them? Not sure why you'd want to
On Thu, 24 Oct 2024 03:33:51 GMT, Julian Waters wrote:
> the way I did it I'd have to force push
That should not be the case. You can just anti-delta changes.
-
PR Comment: https://git.openjdk.org/jdk/pull/21616#issuecomment-2434475849
On Thu, 17 Oct 2024 17:17:40 GMT, Xue-Lei Andrew Fan wrote:
> > > Does it happen in server side (server send plaintext) as well? I found
> > > some cases that the client decryption failed.
> >
> >
> > Current reports indicate it happens on the server side only (server throws
> > the exception
On Mon, 21 Oct 2024 20:18:24 GMT, Artur Barashev wrote:
>> Check for unexpected plaintext alert message during TLSv1.3 handshake. This
>> can happen if client doesn't receive ServerHello due to network timeout and
>> tries to close the connection by sending an alert message.
>
> Artur Barashev
48 matches
Mail list logo
