Re: RFR: 8349583: Add mechanism to disable signature schemes based on their TLS scope [v18]

2025-03-19 Thread Artur Barashev
On Wed, 19 Mar 2025 19:22:07 GMT, Artur Barashev wrote: >> src/java.base/share/classes/sun/security/util/DisabledAlgorithmConstraints.java >> line 822: >> >>> 820: } >>> 821: this.scopes.add(scope); >>> 822: } else { >> >> ex

Re: RFR: 8350459: MontgomeryIntegerPolynomialP256 multiply intrinsic with AVX2 on x86_64 [v4]

2025-03-19 Thread Anthony Scarpino
On Mon, 10 Mar 2025 23:05:10 GMT, Volodymyr Paprotski wrote: >> test/jdk/com/sun/security/util/math/intpoly/MontgomeryPolynomialFuzzTest.java >> line 123: >> >>> 121: } >>> 122: >>> 123: if (rnd.nextBoolean()) { >> >> Why is this done randomly? Wouldn't we want to check thes

Re: RFR: 8339280: jarsigner -verify performs cross-checking between CEN and LOC [v9]

2025-03-19 Thread Hai-May Chao
> The jarsigner -verify command currently performs verification by reading from > JarFile to navigate the central directory (CEN) headers. It is now enhanced > to include cross-validation of entries between JarFile (CEN-based) and > JarInputStream (stream-based) representations of the JAR. It em

Re: RFR: 8350459: MontgomeryIntegerPolynomialP256 multiply intrinsic with AVX2 on x86_64 [v4]

2025-03-19 Thread Anthony Scarpino
On Mon, 17 Mar 2025 22:25:14 GMT, Volodymyr Paprotski wrote: >> -XX:+/-UseIntPolyIntrinsics (test Java vs BigInt and intrinsic vs BigInt) >> >> Though I think I did this before I knew much about junit.. I think I can >> just have two @run commands (to make it clearer)? Will give that a try > >

Re: RFR: 8349583: Add mechanism to disable signature schemes based on their TLS scope [v18]

2025-03-19 Thread Artur Barashev
On Tue, 18 Mar 2025 23:15:29 GMT, Anthony Scarpino wrote: >> Artur Barashev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Typo fix > > test/jdk/sun/security/ssl/SignatureScheme/AbstractCheckSignatureSchemes.java > line 135: > >> 133

Re: RFR: 8349583: Add mechanism to disable signature schemes based on their TLS scope [v18]

2025-03-19 Thread Artur Barashev
On Mon, 17 Mar 2025 22:58:20 GMT, Anthony Scarpino wrote: >> Artur Barashev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Typo fix > > src/java.base/share/classes/sun/security/util/DisabledAlgorithmConstraints.java > line 822: > >>

Re: RFR: 8339280: jarsigner -verify performs cross-checking between CEN and LOC [v7]

2025-03-19 Thread Hai-May Chao
On Wed, 19 Mar 2025 13:34:10 GMT, Weijun Wang wrote: >> Hai-May Chao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add testcase for entry name integrity check > > src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java lin

Re: RFR: 8339280: jarsigner -verify performs cross-checking between CEN and LOC [v8]

2025-03-19 Thread Hai-May Chao
> The jarsigner -verify command currently performs verification by reading from > JarFile to navigate the central directory (CEN) headers. It is now enhanced > to include cross-validation of entries between JarFile (CEN-based) and > JarInputStream (stream-based) representations of the JAR. It em

Re: RFR: 8349535: Refactor ./pkcs11/Provider/MultipleLogins.sh to java test [v6]

2025-03-19 Thread Mikhail Yankelevich
> Moved the sh file logic to jtreg java test. Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: minor: space at the end - Changes: - all: https://git.openjdk.org/jdk/pull/23590/files - new: https://git.openjdk.o

Re: RFR: 8348732: SunJCE and SunPKCS11 have different PBE key encodings

2025-03-19 Thread Francisco Ferrari Bihurriet
On Tue, 18 Mar 2025 23:20:39 GMT, Francisco Ferrari Bihurriet wrote: >> As part of [https://bugs.openjdk.org/browse/JDK-8301553](JDK-8301553), >> SunPKCS11 provider added support for PBE SecretKeyFactories for >> `HmacPBESHAxxx` and `PBEWithHmacSHAxxxAndAES_yyy`. These impls produce keys >> w

Re: RFR: 8349535: Refactor ./pkcs11/Provider/MultipleLogins.sh to java test [v5]

2025-03-19 Thread Mikhail Yankelevich
> Moved the sh file logic to jtreg java test. Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: added summary - Changes: - all: https://git.openjdk.org/jdk/pull/23590/files - new: https://git.openjdk.org/jdk/pul

Re: RFR: 8339280: jarsigner -verify performs cross-checking between CEN and LOC [v7]

2025-03-19 Thread Weijun Wang
On Wed, 19 Mar 2025 03:23:17 GMT, Hai-May Chao wrote: >> The jarsigner -verify command currently performs verification by reading >> from JarFile to navigate the central directory (CEN) headers. It is now >> enhanced to include cross-validation of entries between JarFile (CEN-based) >> and Jar

Re: RFR: 8351566: Consolidate third party artifacts used in tests [v2]

2025-03-19 Thread Mikhail Yankelevich
On Tue, 18 Mar 2025 13:49:28 GMT, Roger Riggs wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> minor: imports fix > > test/jdk/sun/security/pkcs11/PKCS11Test.java line 45: > >> 43: import java.security.spec.