[jdk25] Integrated: 8359170: Add 2 TLS and 2 CS Sectigo roots

2025-06-16 Thread Rajan Halade
On Tue, 10 Jun 2025 22:01:44 GMT, Rajan Halade wrote: > Hi all, > > This pull request contains a backport of commit > [9586817c](https://github.com/openjdk/jdk/commit/9586817cea3f1cad8a49d43e9106e25dafa04765) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit bei

Re: RFR: 8359388: Stricter checking for cipher transformations

2025-06-16 Thread Valerie Peng
On Mon, 16 Jun 2025 13:49:38 GMT, Mikhail Yankelevich wrote: >> Based on the javadoc of `javax.crypto.Cipher` class, the cipher >> transformation should be either "algorithm/mode/padding" or >> "algorithm". When parsing the transformation, space(s) is trimmed off and >> empty strings are consi

Re: RFR: 8359388: Stricter checking for cipher transformations [v2]

2025-06-16 Thread Valerie Peng
> Based on the javadoc of `javax.crypto.Cipher` class, the cipher > transformation should be either "algorithm/mode/padding" or > "algorithm". When parsing the transformation, space(s) is trimmed off and > empty strings are considered as "unspecified". This PR adds checks to ensure > that transf

RFR: 8356897: Update NSS library to 3.111

2025-06-16 Thread Matthew Donovan
This PR simply bumps the NSS version to 3.111 - Commit messages: - 8356897: Update NSS library to 3.111 Changes: https://git.openjdk.org/jdk/pull/25807/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25807&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8356897 Stat

Re: [jdk25] RFR: 8359170: Add 2 TLS and 2 CS Sectigo roots

2025-06-16 Thread Sean Mullan
On Tue, 10 Jun 2025 22:01:44 GMT, Rajan Halade wrote: > Hi all, > > This pull request contains a backport of commit > [9586817c](https://github.com/openjdk/jdk/commit/9586817cea3f1cad8a49d43e9106e25dafa04765) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit bei

Re: RFR: 8355379: Annotate lazy fields in java.security @Stable [v2]

2025-06-16 Thread Koushik Muthukrishnan Thirupattur
> Several classes in the `java.security` package lazily compute their hash > value and store it in a field. These fields can typically be annotated with > the `@Stable` annotation. Many of the current implementations are using -1 as > a flag for not computed, this needs to be refactored away. >

Re: RFR: 8359395: XML signature generation does not support user provided SecureRandom [v3]

2025-06-16 Thread Weijun Wang
> New `XMLSignContext` property to allow user-specific `SecureRandom` for XML > signature generation. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: update copyright years - Changes: - all: https://git.openjdk.org/jdk

Re: RFR: 8359395: XML signature generation does not support user provided SecureRandom [v2]

2025-06-16 Thread Mikhail Yankelevich
On Fri, 13 Jun 2025 14:37:51 GMT, Weijun Wang wrote: >> New `XMLSignContext` property to allow user-specific `SecureRandom` for XML >> signature generation. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > rename Also copyr

Re: RFR: 8358451: SunJCE PBEKey impl should throw IllegalStateException when getEncoded() is called

2025-06-16 Thread Kevin Driver
On Fri, 6 Jun 2025 21:36:06 GMT, Valerie Peng wrote: >> src/java.base/share/classes/com/sun/crypto/provider/PBEKey.java line 82: >> >>> 80: } >>> 81: >>> 82: public byte[] getEncoded() { >> >> I understand this is not a public API class so there is no need to provide >> `@throws` in t

Re: RFR: 8359388: Stricter checking for cipher transformations

2025-06-16 Thread Mikhail Yankelevich
On Fri, 13 Jun 2025 17:32:12 GMT, Valerie Peng wrote: > Based on the javadoc of `javax.crypto.Cipher` class, the cipher > transformation should be either "algorithm/mode/padding" or > "algorithm". When parsing the transformation, space(s) is trimmed off and > empty strings are considered as "un

Re: RFR: 8357470: src/java.base/share/classes/sun/security/util/Debug.java implement the test for args.toLowerCase [v2]

2025-06-16 Thread Mikhail Yankelevich
> * added an automated mixed case option > * using multithreading now > * added logs for simpler debug > * added missing -Djava.security.auth.debug coverage Mikhail Yankelevich has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commit

[jdk25] Integrated: 8358171: Additional code coverage for PEM API

2025-06-16 Thread Fernando Guallini
On Tue, 10 Jun 2025 07:26:54 GMT, Fernando Guallini wrote: > Hi all, > > This pull request contains a backport of commit > [b2e7cda6](https://github.com/openjdk/jdk/commit/b2e7cda6a0bd21fa3c4ffe2a67da4953f1ca3f1f) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The comm

Re: RFR: 8357995: Use "stdin.encoding" for reading System.in with InputStreamReader/Scanner [core] [v4]

2025-06-16 Thread Volkan Yazici
On Tue, 3 Jun 2025 20:09:51 GMT, Naoto Sato wrote: >> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix missing `java.io.Reader` import in `Ktab` > > I was thinking if someone made a typo for "stdin.encoding" and then it

Integrated: 8357995: Use "stdin.encoding" for reading System.in with InputStreamReader/Scanner [core]

2025-06-16 Thread Volkan Yazici
On Fri, 30 May 2025 11:07:30 GMT, Volkan Yazici wrote: > Passes the `Charset` read from the `stdin.encoding` system property while > creating `InputStreamReader` or `Scanner` instances for `System.in`. > > `stdin.encoding` is a recently added property for Java 25 in > [JDK-8350703](https://bug