Re: RFR: 8357470: src/java.base/share/classes/sun/security/util/Debug.java implement the test for args.toLowerCase [v3]

2025-06-24 Thread Sean Coffey
On Tue, 24 Jun 2025 13:41:42 GMT, Mikhail Yankelevich wrote: > > As the original contributor of this test case, it's nice to see the speed > > up via use of ExecutorService. > > The upper case and lower case property tests are somewhat questionable IMO. > > One or two lines of test code would

Re: RFR: 8357470: src/java.base/share/classes/sun/security/util/Debug.java implement the test for args.toLowerCase [v3]

2025-06-24 Thread Sean Coffey
On Tue, 24 Jun 2025 10:41:29 GMT, Mikhail Yankelevich wrote: >> * added an automated mixed case option >> * using multithreading now >> * added logs for simpler debug >> * added missing -Djava.security.auth.debug coverage > > Mikhail Yankelevich has updated the pull request incrementally with on

Integrated: 8156715: TrustStoreManager does not buffer keystore input stream

2025-06-24 Thread Artur Barashev
On Fri, 20 Jun 2025 20:21:19 GMT, Artur Barashev wrote: > Wrap the FileInputStream into a BufferedInputStream which reduces the number > of actual file reads when loading a key store. This pull request has now been integrated. Changeset: 2af869b1 Author:Artur Barashev URL: https://

Re: RFR: 8349946: Cipher javadoc could describe AEAD reuse better [v2]

2025-06-24 Thread Anthony Scarpino
On Thu, 12 Jun 2025 17:04:22 GMT, Koushik Muthukrishnan Thirupattur wrote: >> The class documentation in javax.crypto.Cipher could better describe AEAD >> and reuse. The current class description example is outdated as GCM >> encryption does not allow resets. The doc should state that reset()

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v4]

2025-06-24 Thread Damon Nguyen
On Tue, 24 Jun 2025 14:59:18 GMT, Weijun Wang wrote: >> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update to german translations > > src/java.base/share/classes/sun/security/util/resources/security_zh_CN.properties > l

Re: RFR: 8325766: Review seclibs tests for cert expiry [v5]

2025-06-24 Thread Artur Barashev
On Tue, 3 Jun 2025 13:11:31 GMT, Matthew Donovan wrote: >> This PR updates the CertificateBuilder with a new method that creates a new >> instance with common fields (subject name, public key, serial number, >> validity, and key uses) filled-in. One test, IPIdentities.java, is updated >> to sh

Re: [jdk25] RFR: 8358099: PEM spec updates

2025-06-24 Thread Weijun Wang
On Mon, 23 Jun 2025 16:55:22 GMT, Anthony Scarpino wrote: > Hi > > This is a clean backport to jdk25 for updates to the PEM spec. > > PEMRecord.pem is renamed to content to better describe that it is the base64 > content and not including the header and footer. Additionally, > PEMRecord.get

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]

2025-06-24 Thread Weijun Wang
On Wed, 18 Jun 2025 16:43:02 GMT, Alexey Ivanov wrote: >> There is still only one space, the new one is a full width colon (U+FF1A). >> Localization rules have been observed to make the switch from regular colons >> (U+003A) into the full width version depending on the language. > > Thank you f

Re: RFR: 8343395: SSLLogger doesn't work for formatted messages [v2]

2025-06-24 Thread Sean Coffey
> SLSLogger is broken when used with with `System.Logger` (-Djavax.net.debug > mode) > > SSL Debug messages don't use format specifiers. As a result, any custom > format data isn't printed. Proposed solution is to append the SSL custom > format output to the original debug message. Similar appr

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v5]

2025-06-24 Thread Alisen Chung
> This issue is responsible for updating the translations of all the > localize(able) resources in the JDK since the previous L10n drop. Alisen Chung has updated the pull request incrementally with three additional commits since the last revision: - Update src/jdk.compiler/share/classes/com/s

Re: RFR: 8357470: src/java.base/share/classes/sun/security/util/Debug.java implement the test for args.toLowerCase [v3]

2025-06-24 Thread Mikhail Yankelevich
On Tue, 24 Jun 2025 13:02:45 GMT, Sean Coffey wrote: > As the original contributor of this test case, it's nice to see the speed up > via use of ExecutorService. > > The upper case and lower case property tests are somewhat questionable IMO. > One or two lines of test code would suffice but no

[jdk25] Integrated: 8358099: PEM spec updates

2025-06-24 Thread Anthony Scarpino
On Mon, 23 Jun 2025 16:55:22 GMT, Anthony Scarpino wrote: > Hi > > This is a clean backport to jdk25 for updates to the PEM spec. > > PEMRecord.pem is renamed to content to better describe that it is the base64 > content and not including the header and footer. Additionally, > PEMRecord.get

Re: Disable session tickets sent during successful session resumption?

2025-06-24 Thread Hai-May Chao
Hi Raveena, > On Jun 23, 2025, at 10:35 AM, Raveena Kushwah > wrote: > > Hi All > > This is first time that I'm asking a question here, please let me > know if any other details required. > > We are having an application which sents a request to tomcat server using > https. With

Re: RFR: 8156715: TrustStoreManager does not buffer keystore input stream [v2]

2025-06-24 Thread Artur Barashev
On Mon, 23 Jun 2025 23:11:16 GMT, Anthony Scarpino wrote: > Add a no regression test label on the bug. Probably `noreg-hard` as it's > difficult to test. Done, thanks! - PR Comment: https://git.openjdk.org/jdk/pull/25920#issuecomment-3000536214

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v4]

2025-06-24 Thread Christian Stein
On Mon, 23 Jun 2025 16:44:23 GMT, Alisen Chung wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK since the previous L10n drop. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the las

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]

2025-06-24 Thread Weijun Wang
On Tue, 24 Jun 2025 14:54:17 GMT, Weijun Wang wrote: >> Thank you for the clarification. > > However, there is no space required between two Chinese sentences. In > English, we usually write "I am here, and you are there." But in Chinese, > with the full-width punctuation, it's always "我在这里,你在那

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v4]

2025-06-24 Thread Weijun Wang
On Mon, 23 Jun 2025 16:44:23 GMT, Alisen Chung wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK since the previous L10n drop. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the las

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v4]

2025-06-24 Thread Christian Stein
On Mon, 23 Jun 2025 16:44:23 GMT, Alisen Chung wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK since the previous L10n drop. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the las

Re: RFR: 8357470: src/java.base/share/classes/sun/security/util/Debug.java implement the test for args.toLowerCase [v2]

2025-06-24 Thread Mikhail Yankelevich
On Sat, 21 Jun 2025 23:18:39 GMT, Koushik Muthukrishnan Thirupattur wrote: >> Mikhail Yankelevich has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains two commits: >> >> - Merge branch 'master' into JDK-8357470 >> - JDK-8357470: src

Re: RFR: 8357470: src/java.base/share/classes/sun/security/util/Debug.java implement the test for args.toLowerCase [v3]

2025-06-24 Thread Mikhail Yankelevich
> * added an automated mixed case option > * using multithreading now > * added logs for simpler debug > * added missing -Djava.security.auth.debug coverage Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: comments & split test