RFR: 8333857: Test sun/security/ssl/SSLSessionImpl/ResumeChecksServer.java failed: Existing session was used

2025-07-15 Thread Anthony Scarpino
Hi I need a review for a client-server threading change that will hopefully address intermittent failures. This change is similar to [JDK-8348309](https://bugs.openjdk.org/browse/JDK-8348309). The functional testing is unchanged. thanks Tony - Commit messages: - flip around s

Re: [jdk25] RFR: Merge 121f5a72e4c23919b3a3b474cc3f1ac29ec611af [v2]

2025-07-15 Thread Brent Christian
> This brings in cpu25_07 changes. Brent Christian has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. - Changes: - all: https://git.openjdk.org/jdk/pull/26340/files

[jdk25] Integrated: Merge 121f5a72e4c23919b3a3b474cc3f1ac29ec611af

2025-07-15 Thread Brent Christian
On Wed, 16 Jul 2025 03:40:43 GMT, Brent Christian wrote: > This brings in cpu25_07 changes. This pull request has now been integrated. Changeset: 0e6bf005 Author:Brent Christian URL: https://git.openjdk.org/jdk/commit/0e6bf0055057fae844748a300551549553f59f03 Stats: 358 lines in

[jdk25] RFR: Merge 121f5a72e4c23919b3a3b474cc3f1ac29ec611af

2025-07-15 Thread Brent Christian
This brings in cpu25_07 changes. - Commit messages: - 8360147: Better Glyph drawing redux - 8355884: [macos] java/awt/Frame/I18NTitle.java fails on MacOS - 8350991: Improve HTTP client header handling - 8349594: Enhance TLS protocol support - 8349584: Improve compiler processing

Re: [jdk25] RFR: Merge 121f5a72e4c23919b3a3b474cc3f1ac29ec611af

2025-07-15 Thread Jaikiran Pai
On Wed, 16 Jul 2025 03:40:43 GMT, Brent Christian wrote: > This brings in cpu25_07 changes. Marked as reviewed by jpai (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/26340#pullrequestreview-3023001849

Integrated: 8353925: Remove Sun Microsystems JCE Code Signing Root CA

2025-07-15 Thread Bradford Wetmore
On Tue, 8 Jul 2025 22:57:49 GMT, Bradford Wetmore wrote: > No longer trust certificates issued by the old Sun Microsystems JCE > Certificate Authority. > > Test runs include `tier1,tier2`, and JCK tests: > > jck:api/java_security > jck:api/javax_crypto > jck:api/javax_net > jck

Re: Suggestion to Improve Debug Messaging on CertPath.

2025-07-15 Thread Sean Mullan
Before I evaluate your request, I have a question. If the certificate contains the same public key, subject and SAN, why does validation fail? --Sean On 7/14/25 1:58 AM, Pooja D P wrote: Subject: Observation on CertPath Duplicate Trust Anchor Behavior and Suggestion to Improve Debug Messaging

Suggestion to Improve Debug Messaging on CertPath.

2025-07-15 Thread Pooja D P
Subject: Observation on CertPath Duplicate Trust Anchor Behavior and Suggestion to Improve Debug Messaging. Hi Team, When we were working on customer case where the customer is using a self-signed certificate for a TLS server and has added this certificate to the trust store to trust it. Howe

RFR: 8361711: Add library name configurability to PKCS11Test.java

2025-07-15 Thread Thomas Fitzsimmons
This patch adds configurability to `PKCS11Test.java`. Specifically, it adds two new system properties: - `CUSTOM_P11_LIBRARY_NAME`: Allow overriding the value assigned to the `nss_library` field. Prior to this patch, `nss_library` was set to either `"softokn3"` or `"nss3"`. - `CUSTOM_P11_CONF

Re: RFR: 8353925: Remove Sun Microsystems JCE Code Signing Root CA [v2]

2025-07-15 Thread Bradford Wetmore
> No longer trust certificates issued by the old Sun Microsystems JCE > Certificate Authority. > > Test runs include `tier1,tier2`, and JCK tests: > > jck:api/java_security > jck:api/javax_crypto > jck:api/javax_net > jck:api/javax_security > jck:api/org_ietf > jck:api/ja

Withdrawn: 8359340: KRB5 tests should protect themselves against random proxy selection

2025-07-15 Thread Mikhail Yankelevich
On Tue, 1 Jul 2025 09:57:31 GMT, Mikhail Yankelevich wrote: > 1. KRB5 tests is now always selecting NO_PROXY. > 2. test cleanup This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/26061

Re: RFR: 8360979: Remove use of Thread.stop in krb5/auto/KDC.java [v2]

2025-07-15 Thread Mikhail Yankelevich
> Replaced Thread::stop to Thread::interrupt Mikhail Yankelevich has updated the pull request incrementally with one additional commit since the last revision: breaking the loop when interrupt flag is set - Changes: - all: https://git.openjdk.org/jdk/pull/26247/files - new: h

Re: RFR: 8360979: Remove use of Thread.stop in krb5/auto/KDC.java [v2]

2025-07-15 Thread Mikhail Yankelevich
On Tue, 15 Jul 2025 11:55:01 GMT, Matthew Donovan wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> breaking the loop when interrupt flag is set > > test/jdk/sun/security/krb5/auto/KDC.java line 1649: > >> 16

RFR: 8361868: [GCC static analyzer] complains about missing calloc - NULL checks in p11_util.c

2025-07-15 Thread Matthias Baesken
When using the GCC -fanalyzer flag (see https://developers.redhat.com/articles/2022/04/12/state-static-analysis-gcc-12-compiler# ) , we get some complaints about missing calloc return value checks for NULL (we check at some code locations but in p11_util.c we do not do it). - Commi

Re: RFR: 8361894: sun/security/krb5/config/native/TestDynamicStore.java ensure that the test is run with sudo [v2]

2025-07-15 Thread Mikhail Yankelevich
On Tue, 15 Jul 2025 11:35:21 GMT, Matthew Donovan wrote: >> Mikhail Yankelevich has updated the pull request incrementally with one >> additional commit since the last revision: >> >> checking for root user automatically > > test/jdk/sun/security/krb5/config/native/TestDynamicStore.java line

Re: RFR: 8361894: sun/security/krb5/config/native/TestDynamicStore.java ensure that the test is run with sudo [v2]

2025-07-15 Thread Mikhail Yankelevich
> sun/security/krb5/config/native/TestDynamicStore.java is commonly run without > sudo, which leads to the access related failure. > Added a ui popup reminding to run the test with sudo, making instructions > clearer and more noticeable Mikhail Yankelevich has updated the pull request increment

Re: RFR: 8360979: Remove use of Thread.stop in krb5/auto/KDC.java

2025-07-15 Thread Matthew Donovan
On Thu, 10 Jul 2025 16:03:54 GMT, Mikhail Yankelevich wrote: > Replaced Thread::stop to Thread::interrupt test/jdk/sun/security/krb5/auto/KDC.java line 1649: > 1647: } else { > 1648: try { > 1649: thread1.interrupt(); Each thread catches and ignores `Except

Re: RFR: 8361894: sun/security/krb5/config/native/TestDynamicStore.java ensure that the test is run with sudo

2025-07-15 Thread Matthew Donovan
On Mon, 14 Jul 2025 12:53:55 GMT, Mikhail Yankelevich wrote: > sun/security/krb5/config/native/TestDynamicStore.java is commonly run without > sudo, which leads to the access related failure. > Added a ui popup reminding to run the test with sudo, making instructions > clearer and more notice