[jdk25] RFR: 8360416: Incorrect l10n test case in sun/security/tools/keytool/i18n.java

2025-07-22 Thread Justin Lu
Please review this PR which is a backport of commit [5540a785](https://github.com/openjdk/jdk/commit/5540a7859b3ae0faf6b6c7f50e53ff611b253a9f) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. This is a test-only issue which removes an incorrect l10n test case. - Comm

Integrated: 8360416: Incorrect l10n test case in sun/security/tools/keytool/i18n.java

2025-07-22 Thread Justin Lu
On Wed, 25 Jun 2025 20:50:43 GMT, Justin Lu wrote: > Please review this PR which removes an incorrect localization test case in > _sun/security/tools/keytool/i18n.java_. The manual test was identified to not > emit any localized output for an incorrect `keystore` password via > "-storepass". H

Re: RFR: 8360416: Incorrect l10n test case in sun/security/tools/keytool/i18n.java [v2]

2025-07-22 Thread Justin Lu
On Wed, 25 Jun 2025 21:56:10 GMT, Justin Lu wrote: >> Please review this PR which removes an incorrect localization test case in >> _sun/security/tools/keytool/i18n.java_. The manual test was identified to >> not emit any localized output for an incorrect `keystore` password via >> "-storepass

Withdrawn: 8325766: Review seclibs tests for cert expiry

2025-07-22 Thread duke
On Wed, 19 Feb 2025 15:48:10 GMT, Matthew Donovan wrote: > This PR updates the CertificateBuilder with a new method that creates a new > instance with common fields (subject name, public key, serial number, > validity, and key uses) filled-in. One test, IPIdentities.java, is updated to > show

Re: RFR: 8352728: InternalError loading java.security due to Windows parent folder permissions [v4]

2025-07-22 Thread Francisco Ferrari Bihurriet
> Hi, this is a proposal to fix 8352728. > > The main idea is to replace > [`java.nio.file.Path::toRealPath`](https://docs.oracle.com/en/java/javase/24/docs/api/java.base/java/nio/file/Path.html#toRealPath(java.nio.file.LinkOption...)) > by > [`java.io.File::getCanonicalPath`](https://docs.orac

RFR: 8357682 : sun.security.provider.certpath.Builder#getMatchingPolicies always returns null

2025-07-22 Thread Koushik Muthukrishnan Thirupattur
The method sun.security.provider.certpath.Builder#getMatchingPolicies appears to have been intended as a lazy initialization of the matchingPolicies field of the Builder class. However it checks for "matchingPolicies != null" (presumably it should be "matchingPolicies == null") at the start, whi

Integrated: 8356557: Update CodeSource::implies API documentation and deprecate java.net.SocketPermission class for removal

2025-07-22 Thread Sean Mullan
On Mon, 14 Jul 2025 19:19:47 GMT, Sean Mullan wrote: > `SocketPermission` should be deprecated for removal as has already been done > for many other `Permission` subclasses. However, `CodeSource.implies()` has > specification dependencies on `SocketPermission` which requires additional > chang

RFR: 8361871: [GCC static analyzer] complains about use of uninitialized value ckpObject in p11_util.c

2025-07-22 Thread Matthias Baesken
Seems the used j*ToCKByteArray helper functions have a potential code path where ckpObject is not written/initialized . (we see this when using the gcc flag -fanalyzer) /jdk/src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p11_util.c:1239:16: error: use of uninitialized value 'ckpObject' [CWE-4