RFR: 8360463: Ambiguity in Cipher.getInstance() specification between NoSuchAlgorithmException and NoSuchPaddingException

2025-07-25 Thread Valerie Peng
This PR is for clarifying the `NoSuchAlgorithmException` and `NoSuchPaddingException` for the `Cipher.getInstance(String transformation, Provider provider)` and `Cipher.getInstance(String transformation, String provider)` methods. As stated in `javax.crypto.CipherSpi` class, provider has the fl

Re: RFR: 8340312: sun.security.ssl.SSLLogger uses incorrect log level ALL for `finest` log events

2025-07-25 Thread Bradford Wetmore
On Fri, 18 Jul 2025 15:11:20 GMT, Sean Coffey wrote: > SSLLogger shouldn't be logging at the `ALL` level. > > Trivial enough edit so that both the SSLLogger `finer `and `finest `methods > log at the `System.Logger.Level.TRACE` value > DebugPropertyValuesTest.java edited to cover this change I

Re: RFR: 8209992: Align SSLSocket and SSLEngine Javadocs

2025-07-25 Thread Bradford Wetmore
On Fri, 25 Jul 2025 16:27:42 GMT, Artur Barashev wrote: > Add a javadoc paragraph to SSLSocket.startHandshake() and > SSLEngine.beginHandshake() methods explaining behavioral differences between > TLSv1.3+ and TLSv1.2- versions. The renegotiation wording should probably updated in both the SS

Re: RFR: 8347938: Switch to latest ML-KEM private key encoding [v4]

2025-07-25 Thread Sean Mullan
On Tue, 10 Jun 2025 14:41:49 GMT, Weijun Wang wrote: >> The private key encoding formats of ML-KEM and ML-DSA are updated to match >> the latest IETF drafts at: >> https://datatracker.ietf.org/doc/html/draft-ietf-lamps-dilithium-certificates-11 >> and >> https://datatracker.ietf.org/doc/html/

Re: RFR: 8244336: Restrict algorithms at JCE layer

2025-07-25 Thread Sean Mullan
On Fri, 18 Jul 2025 01:44:33 GMT, Valerie Peng wrote: > This enhancement introduces a new security property > "jdk.crypto.disabledAlgorithms" which can be leveraged to disable algorithms > for JCE/JCA crypto services. For now, only Cipher, KeyStore, MessageDigest, > and Signature services supp

Re: [jdk25] RFR: 8360416: Incorrect l10n test case in sun/security/tools/keytool/i18n.java

2025-07-25 Thread Justin Lu
On Tue, 22 Jul 2025 20:44:55 GMT, Justin Lu wrote: > Please review this PR which is a backport of commit > [5540a785](https://github.com/openjdk/jdk/commit/5540a7859b3ae0faf6b6c7f50e53ff611b253a9f) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > This is a test-only issue

RFR: 8209992: Align SSLSocket and SSLEngine Javadocs

2025-07-25 Thread Artur Barashev
Add a javadoc paragraph to SSLSocket.startHandshake() and SSLEngine.beginHandshake() methods explaining behavioral differences between TLSv1.3+ and TLSv1.2- versions. - Commit messages: - 8209992: Align SSLSocket and SSLEngine Javadocs Changes: https://git.openjdk.org/jdk/pull/264

Re: RFR: 8359395: XML signature generation does not support user provided SecureRandom [v7]

2025-07-25 Thread Sean Mullan
On Thu, 24 Jul 2025 16:09:37 GMT, Weijun Wang wrote: >> New `XMLSignContext` property to allow user-specific `SecureRandom` for XML >> signature generation. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > update copyright y

Integrated: 8361964: Remove outdated algorithms from requirements and add PBES2 algorithms

2025-07-25 Thread Sean Mullan
On Fri, 18 Jul 2025 16:37:25 GMT, Sean Mullan wrote: > The Security Algorithm Implementation Requirements will be updated as follows: > > The following algorithms will be removed from the list of required algorithms > as they are no longer recommended, and should not be in wide usage anymore: >

Re: RFR: 8361871: [GCC static analyzer] complains about use of uninitialized value ckpObject in p11_util.c

2025-07-25 Thread Matthias Baesken
On Tue, 22 Jul 2025 13:33:05 GMT, Matthias Baesken wrote: > Seems the used j*ToCKByteArray helper functions have a potential code path > where ckpObject is not written/initialized . > (we see this when using the gcc flag -fanalyzer) > > > /jdk/src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p

Integrated: 8361871: [GCC static analyzer] complains about use of uninitialized value ckpObject in p11_util.c

2025-07-25 Thread Matthias Baesken
On Tue, 22 Jul 2025 13:33:05 GMT, Matthias Baesken wrote: > Seems the used j*ToCKByteArray helper functions have a potential code path > where ckpObject is not written/initialized . > (we see this when using the gcc flag -fanalyzer) > > > /jdk/src/jdk.crypto.cryptoki/share/native/libj2pkcs11/p