Re: RFR: 8365820: Apply certificate scope constraints to algorithms in "signature_algorithms" extension when "signature_algorithms_cert" extension is not being sent [v4]

2025-08-25 Thread Nibedita Jena
On Mon, 25 Aug 2025 18:18:01 GMT, Artur Barashev wrote: >> [JDK-8349583](https://bugs.openjdk.org/browse/JDK-8349583) implementation >> assumes that OpenJDK client always sends "signature_algorithms_cert" >> extension together with "signature_algorithms" extension. But we didn't >> account for

Re: RFR: 8365820: Apply certificate scope constraints to algorithms in "signature_algorithms" extension when "signature_algorithms_cert" extension is not being sent [v4]

2025-08-25 Thread Nibedita Jena
On Mon, 25 Aug 2025 18:18:01 GMT, Artur Barashev wrote: >> [JDK-8349583](https://bugs.openjdk.org/browse/JDK-8349583) implementation >> assumes that OpenJDK client always sends "signature_algorithms_cert" >> extension together with "signature_algorithms" extension. But we didn't >> account for

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v13]

2025-08-25 Thread Artur Barashev
On Wed, 20 Aug 2025 14:38:44 GMT, Daniel JeliƄski wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 616 commits: >> >> - merge latest changes from master branch >> - merge latest http3 changes >> - Hide int

Re: RFR: 8325448: Hybrid Public Key Encryption [v15]

2025-08-25 Thread Sean Mullan
On Thu, 24 Apr 2025 22:10:35 GMT, Weijun Wang wrote: >> I can add a sentence saying if an implementation does not provide default >> numeric algorithm identifiers then an exception will be thrown if `of()` is >> used by the sender. >> >> I still think it's useful to provide defaults. Now that

Re: RFR: 8325448: Hybrid Public Key Encryption [v10]

2025-08-25 Thread Sean Mullan
On Fri, 14 Mar 2025 02:46:47 GMT, Weijun Wang wrote: >> If they are common, would it make more sense to include them as parameters >> to an overloaded version of the static `of` method? > > I'd rather not. There are already three `of` methods. Adding `info` would > make make six, and adding `en

Re: RFR: 8325448: Hybrid Public Key Encryption [v33]

2025-08-25 Thread Sean Mullan
On Fri, 22 Aug 2025 19:33:15 GMT, Weijun Wang wrote: >> Implement HPKE as defined in https://datatracker.ietf.org/doc/rfc9180/. >> >> > src="https://github.com/user-attachments/assets/45625334-903b-4a3d-a987-7fddeab9a604"; >> /> > > Weijun Wang has updated the pull request incrementally with on

Re: RFR: 8365288: PEMDecoder should throw ClassCastException [v3]

2025-08-25 Thread Anthony Scarpino
On Mon, 25 Aug 2025 19:36:35 GMT, Weijun Wang wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> update test bugid > > src/java.base/share/classes/java/security/PEMDecoder.java line 440: > >> 438:

Re: RFR: 8365288: PEMDecoder should throw ClassCastException [v3]

2025-08-25 Thread Weijun Wang
On Tue, 19 Aug 2025 19:42:19 GMT, Anthony Scarpino wrote: >> This bug fix is to change PEMDecoder.decode(..., Class<>) using >> PKCS8EncodedKeySpec and X509EncodedKeySpec will throw an >> IllegalArgumentException when the decoded data does not match. It should be >> ClassCastException. >> >>

Re: RFR: 8365820: Apply certificate scope constraints to algorithms in "signature_algorithms" extension when "signature_algorithms_cert" extension is not being sent [v4]

2025-08-25 Thread Artur Barashev
> [JDK-8349583](https://bugs.openjdk.org/browse/JDK-8349583) implementation > assumes that OpenJDK client always sends "signature_algorithms_cert" > extension together with "signature_algorithms" extension. But we didn't > account for `jdk.tls.client.disableExtensions` and > `jdk.tls.server.dis

Re: RFR: 8362268 : NPE thrown from SASL GSSAPI impl when TLS is used with QOP auth-int against Active Directory

2025-08-25 Thread Michael Osipov
On Fri, 22 Aug 2025 15:38:05 GMT, Weijun Wang wrote: > So, it seems we should NOT revert to the raw stream. We can either return > earlier in `abandonRequest()` before the `write` call or the `write` should > fail (which the current PR does). Of course, an exception with clear > information is

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v14]

2025-08-25 Thread Artur Barashev
On Mon, 25 Aug 2025 13:34:51 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the >> HTTP Client API](htt

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v14]

2025-08-25 Thread Artur Barashev
On Mon, 25 Aug 2025 13:34:51 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the >> HTTP Client API](htt

RFR: 8364039: Adding implNote to DOMSignContext and DOMValidateContext on JDK-specific properties

2025-08-25 Thread Weijun Wang
Document some existing JDK-specific properties for XML Digital Signature. - Commit messages: - the implNote Changes: https://git.openjdk.org/jdk/pull/26929/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=26929&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8364039

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v5]

2025-08-25 Thread Albert Mingkun Yang
On Mon, 25 Aug 2025 11:40:56 GMT, Leo Korinth wrote: > while not multiplying a 10x factor with four resulting in a 40x factor. Why is that undesirable? The base is `(HOLD_TARGET_TIME + 3) * 4` and the timeout-factor changes that linearly. Using `max(..., 4)` here may come as a surprise to

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v14]

2025-08-25 Thread Daniel Fuchs
> Hi, > > Please find here a PR for the implementation of [JEP 517: HTTP/3 for the HTTP > Client API](https://openjdk.org/jeps/517). > > The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the HTTP > Client API](https://bugs.openjdk.org/browse/JDK-8350588) > > This JEP propose

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v5]

2025-08-25 Thread Leo Korinth
On Fri, 22 Aug 2025 15:55:38 GMT, Albert Mingkun Yang wrote: >> Leo Korinth has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update testing.md, remove makefile link, fix bad text > > test/jdk/java/rmi/transport/dgcDeadLock/DGCDeadLock.jav

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v5]

2025-08-25 Thread Leo Korinth
On Wed, 20 Aug 2025 17:05:59 GMT, Leo Korinth wrote: >> This changes the timeout factor from 4 to 1. Most of the changes add >> timeouts to individual test cases so that I am able to run them with a >> timeout factor of 0.7 (some margin to the checked in factor of one) >> >> In addition to cha

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v5]

2025-08-25 Thread Leo Korinth
On Fri, 22 Aug 2025 16:06:16 GMT, Albert Mingkun Yang wrote: >> Leo Korinth has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update testing.md, remove makefile link, fix bad text > > test/langtools/jdk/jshell/HangingRemoteAgent.java line

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v5]

2025-08-25 Thread Leo Korinth
On Fri, 22 Aug 2025 15:44:28 GMT, Albert Mingkun Yang wrote: >> Leo Korinth has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update testing.md, remove makefile link, fix bad text > > test/hotspot/jtreg/runtime/cds/appcds/LotsOfSyntheticCl

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v5]

2025-08-25 Thread Leo Korinth
On Sun, 24 Aug 2025 22:51:05 GMT, David Holmes wrote: >> test/hotspot/jtreg/compiler/tiered/Level2RecompilationTest.java line 36: >> >>> 34: * @build jdk.test.whitebox.WhiteBox >>> 35: * @run driver jdk.test.lib.helpers.ClassFileInstaller >>> jdk.test.whitebox.WhiteBox >>> 36: * @run main/ot

Re: RFR: 8356439: Rename JavaLangAccess::*NoRepl methods [v6]

2025-08-25 Thread Volkan Yazici
On Fri, 22 Aug 2025 14:25:19 GMT, Roger Riggs wrote: >> Volkan Yazici has updated the pull request incrementally with five >> additional commits since the last revision: >> >> - Renamed to `malformedASCII` >> - Improve exception parametrization >> - Document parametrization on the exception

Re: RFR: 8356439: Rename JavaLangAccess::*NoRepl methods [v7]

2025-08-25 Thread Volkan Yazici
> `NoRepl`-suffixed `String` methods denote methods that do not replace invalid > characters, but throw `CharacterCodingException` on encounter. This behavior > cannot easily be derived from the method footprints, has been a source of > confusion for maintainers, and is not uniformly adopted, e.