Withdrawn: 8360979: Remove use of Thread.stop in krb5/auto/KDC.java

2025-09-15 Thread duke
On Thu, 10 Jul 2025 16:03:54 GMT, Mikhail Yankelevich wrote: > Replaced Thread::stop to Thread::interrupt This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/26247

Withdrawn: 8361894: sun/security/krb5/config/native/TestDynamicStore.java ensure that the test is run with sudo

2025-09-15 Thread duke
On Mon, 14 Jul 2025 12:53:55 GMT, Mikhail Yankelevich wrote: > sun/security/krb5/config/native/TestDynamicStore.java is commonly run without > sudo, which leads to the access related failure. > Added a ui popup reminding to run the test with sudo, making instructions > clearer and more notice

Withdrawn: 8360562: sun/security/tools/keytool/i18n.java add an ability to add comment for failures

2025-09-15 Thread duke
On Mon, 21 Jul 2025 10:49:18 GMT, Mikhail Yankelevich wrote: > When the test is run now the reason for the failure will be requested > providing further feedback. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/26412

Re: RFR: 8325448: Hybrid Public Key Encryption [v43]

2025-09-15 Thread Anthony Scarpino
On Fri, 12 Sep 2025 23:39:37 GMT, Weijun Wang wrote: >> src/java.base/share/classes/javax/crypto/spec/HPKEParameterSpec.java line >> 317: >> >>> 315: throw new IllegalArgumentException("psk_id is empty"); >>> 316: } >>> 317: if ("RAW".equalsIgnoreCase(psk.getFormat()

Re: RFR: 8366224: Introduce DecimalDigits.appendPair for efficient two-digit formatting and refactor DateTimeHelper [v5]

2025-09-15 Thread Per Minborg
On Mon, 15 Sep 2025 06:45:25 GMT, Per Minborg wrote: >> Shaojin Wen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update test/jdk/jdk/internal/util/DecimalDigitsTest.java >> >> Co-authored-by: Chen Liang > > We have, for long, es

Re: RFR: 8325448: Hybrid Public Key Encryption [v43]

2025-09-15 Thread Weijun Wang
On Mon, 15 Sep 2025 22:42:31 GMT, Anthony Scarpino wrote: >> I just meant if it's not "RAW" (maybe `null`?) then I have no way to check >> its length. A 16 byte AES will be rejected if it has an encoding which is >> almost always of "RAW" format. >> >> Or, did you confuse `getAlgorithm` and `

Re: RFR: 8354469: Keytool exposes the password in plain text when command is piped using | grep [v5]

2025-09-15 Thread Hai-May Chao
On Mon, 15 Sep 2025 19:04:26 GMT, Weijun Wang wrote: >> Allow password hiding even if there is no `System.console`. A manual test is >> included. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > quote keystore paths as well

Re: RFR: 8354469: Keytool exposes the password in plain text when command is piped using | grep [v5]

2025-09-15 Thread Weijun Wang
> Allow password hiding even if there is no `System.console`. A manual test is > included. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: quote keystore paths as well - Changes: - all: https://git.openjdk.org/jdk/pull

Re: RFR: 8360564: Implement JEP 524: PEM Encodings of Cryptographic Objects (Second Preview)

2025-09-15 Thread Anthony Scarpino
On Fri, 12 Sep 2025 18:33:53 GMT, Weijun Wang wrote: >> src/java.base/share/classes/sun/security/ec/ECPrivateKeyImpl.java line 255: >> >>> 253: if (seq.data.available() != 0) { >>> 254: DerValue derValue = seq.data.getDerValue(); >>> 255:

Re: RFR: 8366261: Provide utility methods for sun.security.util.Password [v7]

2025-09-15 Thread Naoto Sato
On Tue, 9 Sep 2025 17:10:10 GMT, Naoto Sato wrote: >> Providing a couple of utility methods using the "built-in" `Console` >> implementation to support tools that require password input, such as >> `keytool`, ensuring they work even when std0ut is redirected. > > Naoto Sato has updated the pull

Re: RFR: 8360564: Implement JEP 524: PEM Encodings of Cryptographic Objects (Second Preview)

2025-09-15 Thread Anthony Scarpino
On Fri, 12 Sep 2025 17:54:49 GMT, Weijun Wang wrote: >> Hi >> >> Please review the [Second Preview](https://openjdk.org/jeps/8360563) for the >> PEM API. The most significant changes from [JEP >> 470](https://openjdk.org/jeps/470) are: >> >> - Renamed the name of `PEMRecord` class to `PEM`.

Re: RFR: 8366817: test/jdk/javax/net/ssl/TLSCommon/interop/JdkProcServer.java and JdkProcClient.java should not delete logs [v2]

2025-09-15 Thread SendaoYan
On Fri, 5 Sep 2025 13:57:29 GMT, Fernando Guallini wrote: >> The following test helpers delete logs after the test completes: >> jdk/javax/net/ssl/TLSCommon/interop/JdkProcServer.java >> jdk/javax/net/ssl/TLSCommon/interop/JdkProcClient.java >> >> These helpers are used by tests located in >>

Re: RFR: 8366978: dead code in SunCertPathBuilder

2025-09-15 Thread duke
On Sat, 13 Sep 2025 05:02:46 GMT, Koushik Muthukrishnan Thirupattur wrote: > A DESCRIPTION OF THE PROBLEM : > [JDK-7194452](https://bugs.openjdk.org/browse/JDK-7194452) left the > SunCertPathBuilder.anchorIsTarget orphaned. Remove the deadcode. @koushikthirupattur Your change (at version ce1d

Re: RFR: 8350550: Preload classes from AOT cache during VM bootstrap [v7]

2025-09-15 Thread Ioi Lam
On Wed, 10 Sep 2025 14:47:19 GMT, Ashutosh Mehra wrote: >> Ioi Lam has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains 22 commits: >> >> - @ashu-mehra review comments >> - Merge branch 'master' into 8350550-preload-aot-classes-durin

RFR: 8367344: Better error message when decryption of AP-REQ fails because of kvno mismatch

2025-09-15 Thread Weijun Wang
For interoperability, AP-REQ decryption uses the key with the highest kvno in the keytab if no exact match is found. If decryption fails, a normal "checksum failed" error is reported, which may hide the real cause that the wrong key is used. This code change throws a KRB_AP_ERR_BADKEYVER error i

Re: RFR: 8366978: dead code in SunCertPathBuilder

2025-09-15 Thread Hai-May Chao
On Sat, 13 Sep 2025 05:02:46 GMT, Koushik Muthukrishnan Thirupattur wrote: > A DESCRIPTION OF THE PROBLEM : > [JDK-7194452](https://bugs.openjdk.org/browse/JDK-7194452) left the > SunCertPathBuilder.anchorIsTarget orphaned. Remove the deadcode. Marked as reviewed by hchao (Reviewer).

Re: RFR: 8366224: Introduce DecimalDigits.appendPair for efficient two-digit formatting and refactor DateTimeHelper [v5]

2025-09-15 Thread Weijun Wang
On Mon, 15 Sep 2025 06:11:18 GMT, Shaojin Wen wrote: >> This PR introduces a new efficient API for appending two-digit integers to >> StringBuilders and refactors DateTimeHelper to leverage this new >> functionality. >> >> Changes include: >> >> 1. New `appendPair` method for efficient two-di

RFR: 8367133: DTLS: fragmentation of Finished message results in handshake failure

2025-09-15 Thread Daniel JeliƄski
The DTLSReassembler may release a Finished message before assembling all necessary fragments. The newly added test fails without the DTLSReassembler changes, passes with the changes. Other tier1-3 tests continue to pass. - Commit messages: - Clean up comment - Extract test to a s

Re: RFR: 8366224: Introduce DecimalDigits.appendPair for efficient two-digit formatting and refactor DateTimeHelper [v5]

2025-09-15 Thread Shaojin Wen
On Mon, 15 Sep 2025 06:45:25 GMT, Per Minborg wrote: >> Shaojin Wen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update test/jdk/jdk/internal/util/DecimalDigitsTest.java >> >> Co-authored-by: Chen Liang > > We have, for long, es