Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v19]

2025-09-21 Thread Daniel Fuchs
350588) > > This JEP proposes to enhance the HttpClient implementation to support HTTP/3. > It adds a non-exposed / non-exported internal implementation of the QUIC > protocol based on DatagramChannel and the SunJSSE SSLContext provider. Daniel Fuchs has updated the pull request with a new

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v18]

2025-09-17 Thread Daniel Fuchs
350588) > > This JEP proposes to enhance the HttpClient implementation to support HTTP/3. > It adds a non-exposed / non-exported internal implementation of the QUIC > protocol based on DatagramChannel and the SunJSSE SSLContext provider. Daniel Fuchs has updated the pull request with a new

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v17]

2025-09-10 Thread Daniel Fuchs
350588) > > This JEP proposes to enhance the HttpClient implementation to support HTTP/3. > It adds a non-exposed / non-exported internal implementation of the QUIC > protocol based on DatagramChannel and the SunJSSE SSLContext provider. Daniel Fuchs has updated the pull request with a new

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v16]

2025-09-04 Thread Daniel Fuchs
350588) > > This JEP proposes to enhance the HttpClient implementation to support HTTP/3. > It adds a non-exposed / non-exported internal implementation of the QUIC > protocol based on DatagramChannel and the SunJSSE SSLContext provider. Daniel Fuchs has updated the pull request with a new

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v14]

2025-08-26 Thread Daniel Fuchs
On Mon, 25 Aug 2025 15:58:08 GMT, Artur Barashev wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 628 commits: >> >> - merge latest changes from master branch >> - http3:

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v13]

2025-08-26 Thread Daniel Fuchs
On Wed, 20 Aug 2025 15:32:55 GMT, Artur Barashev wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 616 commits: >> >> - merge latest changes from master branch >> - merge l

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v15]

2025-08-26 Thread Daniel Fuchs
350588) > > This JEP proposes to enhance the HttpClient implementation to support HTTP/3. > It adds a non-exposed / non-exported internal implementation of the QUIC > protocol based on DatagramChannel and the SunJSSE SSLContext provider. Daniel Fuchs has updated the pull request with a new

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v14]

2025-08-25 Thread Daniel Fuchs
350588) > > This JEP proposes to enhance the HttpClient implementation to support HTTP/3. > It adds a non-exposed / non-exported internal implementation of the QUIC > protocol based on DatagramChannel and the SunJSSE SSLContext provider. Daniel Fuchs has updated the pull request with a new

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-08-20 Thread Daniel Fuchs
On Wed, 20 Aug 2025 16:21:42 GMT, Jaikiran Pai wrote: >> src/java.base/share/classes/sun/security/ssl/Finished.java line 852: >> >>> 850: QuicTLSEngineImpl engine = >>> 851: (QuicTLSEngineImpl) >>> shc.conContext.transport; >>> 852:

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v13]

2025-08-20 Thread Daniel Fuchs
On Wed, 20 Aug 2025 13:55:38 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v13]

2025-08-20 Thread Daniel Fuchs
350588) > > This JEP proposes to enhance the HttpClient implementation to support HTTP/3. > It adds a non-exposed / non-exported internal implementation of the QUIC > protocol based on DatagramChannel and the SunJSSE SSLContext provider. Daniel Fuchs has updated the pull request with a new

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v11]

2025-08-19 Thread Daniel Fuchs
On Wed, 23 Jul 2025 11:00:57 GMT, Daniel Jeliński wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 550 commits: >> >> - merge latest changes from master branch >> - htt

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v11]

2025-08-19 Thread Daniel Fuchs
On Thu, 24 Jul 2025 12:21:56 GMT, Daniel Jeliński wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 550 commits: >> >> - merge latest changes from master branch >> - htt

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v11]

2025-08-19 Thread Daniel Fuchs
On Thu, 24 Jul 2025 19:28:16 GMT, Daniel Jeliński wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 550 commits: >> >> - merge latest changes from master branch >> - htt

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v11]

2025-08-19 Thread Daniel Fuchs
On Thu, 24 Jul 2025 17:04:52 GMT, Daniel Jeliński wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 550 commits: >> >> - merge latest changes from master branch >> - htt

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v11]

2025-08-19 Thread Daniel Fuchs
On Thu, 24 Jul 2025 16:02:44 GMT, Daniel Jeliński wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 550 commits: >> >> - merge latest changes from master branch >> - htt

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v11]

2025-08-19 Thread Daniel Fuchs
On Thu, 24 Jul 2025 15:31:21 GMT, Daniel Jeliński wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 550 commits: >> >> - merge latest changes from master branch >> - htt

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v11]

2025-08-19 Thread Daniel Fuchs
On Thu, 24 Jul 2025 15:20:37 GMT, Daniel Jeliński wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 550 commits: >> >> - merge latest changes from master branch >> - htt

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v4]

2025-08-18 Thread Daniel Fuchs
On Mon, 18 Aug 2025 16:34:21 GMT, Leo Korinth wrote: >> This changes the timeout factor from 4 to 1. Most of the changes add >> timeouts to individual test cases so that I am able to run them with a >> timeout factor of 0.7 (some margin to the checked in factor of one) >> >> In addition to cha

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v3]

2025-08-18 Thread Daniel Fuchs
On Fri, 15 Aug 2025 11:43:33 GMT, Leo Korinth wrote: >> This changes the timeout factor from 4 to 1. Most of the changes add >> timeouts to individual test cases so that I am able to run them with a >> timeout factor of 0.7 (some margin to the checked in factor of one) >> >> In addition to cha

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v12]

2025-08-05 Thread Daniel Fuchs
350588) > > This JEP proposes to enhance the HttpClient implementation to support HTTP/3. > It adds a non-exposed / non-exported internal implementation of the QUIC > protocol based on DatagramChannel and the SunJSSE SSLContext provider. Daniel Fuchs has updated the pull request with a new

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v11]

2025-07-08 Thread Daniel Fuchs
350588) > > This JEP proposes to enhance the HttpClient implementation to support HTTP/3. > It adds a non-exposed / non-exported internal implementation of the QUIC > protocol based on DatagramChannel and the SunJSSE SSLContext provider. Daniel Fuchs has updated the pull request with a new

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v10]

2025-07-07 Thread Daniel Fuchs
350588) > > This JEP proposes to enhance the HttpClient implementation to support HTTP/3. > It adds a non-exposed / non-exported internal implementation of the QUIC > protocol based on DatagramChannel and the SunJSSE SSLContext provider. Daniel Fuchs has updated the pull request with a new

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-06-30 Thread Daniel Fuchs
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-06-30 Thread Daniel Fuchs
On Mon, 30 Jun 2025 09:34:48 GMT, Daniel Jeliński wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 525 commits: >> >> - merge latest changes from master branch >> - http3: run

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-06-27 Thread Daniel Fuchs
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-06-27 Thread Daniel Fuchs
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-06-27 Thread Daniel Fuchs
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-06-27 Thread Daniel Fuchs
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-06-27 Thread Daniel Fuchs
On Fri, 27 Jun 2025 11:37:00 GMT, Daniel Jeliński wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 525 commits: >> >> - merge latest changes from master branch >> - http3: run

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-06-27 Thread Daniel Fuchs
On Fri, 27 Jun 2025 11:22:51 GMT, Daniel Jeliński wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 525 commits: >> >> - merge latest changes from master branch >> - http3: run

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-06-27 Thread Daniel Fuchs
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-06-27 Thread Daniel Fuchs
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-06-27 Thread Daniel Fuchs
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-06-26 Thread Daniel Fuchs
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-06-26 Thread Daniel Fuchs
On Thu, 26 Jun 2025 17:36:21 GMT, Daniel Jeliński wrote: >> src/java.base/share/classes/jdk/internal/net/quic/QuicTLSContext.java line >> 70: >> >>> 68: if (!(underlyingImpl instanceof SSLContextImpl ssci)) { >>> 69: return false; >>> 70: } >> >> Would there be a wa

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-06-26 Thread Daniel Fuchs
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-06-26 Thread Daniel Fuchs
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]

2025-06-26 Thread Daniel Fuchs
350588) > > This JEP proposes to enhance the HttpClient implementation to support HTTP/3. > It adds a non-exposed / non-exported internal implementation of the QUIC > protocol based on DatagramChannel and the SunJSSE SSLContext provider. Daniel Fuchs has updated the pull request with a new

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v7]

2025-06-26 Thread Daniel Fuchs
On Thu, 26 Jun 2025 11:04:33 GMT, Daniel Fuchs wrote: >> Thank you Artur. >> >> @dfuch this conversation can be resolved too. > > Done > Hi Jaikiran! Sounds good. It's likely we are going to re-work this code > anyhow when we make QUIC engine pub

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v8]

2025-06-26 Thread Daniel Fuchs
On Thu, 26 Jun 2025 13:22:28 GMT, Jaikiran Pai wrote: >> src/java.base/share/classes/sun/security/ssl/X509Authentication.java line >> 226: >> >>> 224: chc.peerSupportedAuthorities == null ? null : >>> 225: chc.peerSupportedAuthorities.clone(), >>>

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v7]

2025-06-26 Thread Daniel Fuchs
On Thu, 26 Jun 2025 01:04:41 GMT, Jaikiran Pai wrote: >> Hi Jaikiran! Sounds good. It's likely we are going to re-work this code >> anyhow when we make QUIC engine public in the next iteration. We had a >> discussion with Daniel about it today. > > Thank you Artur. > > @dfuch this conversation

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v8]

2025-06-25 Thread Daniel Fuchs
On Wed, 4 Jun 2025 17:43:16 GMT, Daniel Fuchs wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 506 commits: >> >> - merge latest changes from master branch >> - http3: update

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v8]

2025-06-12 Thread Daniel Fuchs
350588) > > This JEP proposes to enhance the HttpClient implementation to support HTTP/3. > It adds a non-exposed / non-exported internal implementation of the QUIC > protocol based on DatagramChannel and the SunJSSE SSLContext provider. Daniel Fuchs has updated the pull request with a new

Re: RFR: 8358731: Remove jdk.internal.access.JavaAWTAccess.java

2025-06-06 Thread Daniel Fuchs
On Fri, 6 Jun 2025 18:35:53 GMT, Phil Race wrote: > The fix for JDK-8344235: Revisit SecurityManager usage in java.logging after > JEP 486 and JEP 491 integration > removed use of AppContext from java/util/logging/LogManager.java. > That was the only place in the JDK that used > jdk.internal.ac

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v7]

2025-06-06 Thread Daniel Fuchs
350588) > > This JEP proposes to enhance the HttpClient implementation to support HTTP/3. > It adds a non-exposed / non-exported internal implementation of the QUIC > protocol based on DatagramChannel and the SunJSSE SSLContext provider. Daniel Fuchs has updated the pull request with a new

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v6]

2025-06-04 Thread Daniel Fuchs
On Wed, 4 Jun 2025 15:46:36 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v5]

2025-06-04 Thread Daniel Fuchs
On Fri, 16 May 2025 10:26:11 GMT, Daniel Fuchs wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 422 commits: >> >> - merge latest changes from master branch >> - Undo

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v6]

2025-06-04 Thread Daniel Fuchs
350588) > > This JEP proposes to enhance the HttpClient implementation to support HTTP/3. > It adds a non-exposed / non-exported internal implementation of the QUIC > protocol based on DatagramChannel and the SunJSSE SSLContext provider. Daniel Fuchs has updated the pull request with a new

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v20]

2025-06-03 Thread Daniel Fuchs
On Tue, 3 Jun 2025 14:23:54 GMT, Michael McMahon wrote: >> Hi, >> >> Enhanced exception messages are designed to hide sensitive information such >> as hostnames, IP >> addresses from exception message strings, unless the enhanced mode for the >> specific category >> has been explicitly enabl

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v19]

2025-06-03 Thread Daniel Fuchs
x27; into 8348986-exceptions > - doc update to java.security > - removed jmod/Handler change > - doc update to java.security > - Fixed problem with j.n.HostPortRange > - typo in suggestions and other issues > - Merge branch 'master' into 8348986-exceptions > -

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v13]

2025-05-29 Thread Daniel Fuchs
On Thu, 29 May 2025 14:35:11 GMT, Michael McMahon wrote: >> Hi, >> >> Enhanced exception messages are designed to hide sensitive information such >> as hostnames, IP >> addresses from exception message strings, unless the enhanced mode for the >> specific category >> has been explicitly enab

Re: RFR: 8228773: URLClassLoader constructors should include API note warning that the parent should not be null [v3]

2025-05-29 Thread Daniel Fuchs
On Thu, 29 May 2025 14:19:08 GMT, Jaikiran Pai wrote: >> Can I please get a review of this doc-only change which proposes to add an >> `@apiNote` on the constructors of `URLClassLoader` and `SecureClassLoader` >> to explain the current implementation of these constructors? This addresses >> ht

Re: RFR: 8228773: URLClassLoader constructors should include API note warning that the parent should not be null

2025-05-29 Thread Daniel Fuchs
On Thu, 29 May 2025 05:57:56 GMT, Jaikiran Pai wrote: > Can I please get a review of this doc-only change which proposes to add an > `@apiNote` on the constructors of `URLClassLoader` and `SecureClassLoader` to > explain the current implementation of these constructors? This addresses > https:

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v11]

2025-05-26 Thread Daniel Fuchs
On Mon, 26 May 2025 10:31:39 GMT, Michael McMahon wrote: >> Hi, >> >> Enhanced exception messages are designed to hide sensitive information such >> as hostnames, IP >> addresses from exception message strings, unless the enhanced mode for the >> specific category >> has been explicitly enab

Re: RFR: 8356632: Fix remaining {@link/@linkplain} tags with refer to private/protected types in java.base

2025-05-20 Thread Daniel Fuchs
On Sat, 17 May 2025 19:42:39 GMT, Nizar Benalla wrote: > Please review this patch to fix some `javadoc` bugs in `java.base`. > Certain `@link` tags used to refer to private fields instead of public APIs. > > A couple of `@see` tags in the [serialization > page](https://download.java.net/java/ea

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v10]

2025-05-19 Thread Daniel Fuchs
On Fri, 16 May 2025 11:42:08 GMT, Michael McMahon wrote: >> Hi, >> >> Enhanced exception messages are designed to hide sensitive information such >> as hostnames, IP >> addresses from exception message strings, unless the enhanced mode for the >> specific category >> has been explicitly enab

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v5]

2025-05-16 Thread Daniel Fuchs
On Fri, 9 May 2025 14:39:53 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517

Integrated: 8353642: Deprecate URL::getPermission method and networking permission classes for removal

2025-05-12 Thread Daniel Fuchs
On Fri, 11 Apr 2025 09:00:05 GMT, Daniel Fuchs wrote: > Please find her a patch that deprecate networking permission classes for > removal. The method `URL::getPermission` now serves little purpose and is > also deprecated. That method was overridden in subclasses and specified to

Re: RFR: 8353642: Deprecate URL::getPermission method and networking permission classes for removal [v4]

2025-05-12 Thread Daniel Fuchs
On Fri, 9 May 2025 19:19:03 GMT, Daniel Fuchs wrote: >> src/java.base/share/classes/java/net/HttpURLConnection.java line 615: >> >>> 613: */ >>> 614: @Deprecated(since = "25", forRemoval = true) >>> 615: @SuppressWarnings("remov

Re: RFR: 8353642: Deprecate URL::getPermission method and networking permission classes for removal [v4]

2025-05-12 Thread Daniel Fuchs
On Fri, 9 May 2025 19:18:58 GMT, Daniel Fuchs wrote: >> src/java.base/share/classes/sun/net/www/protocol/file/FileURLConnection.java >> line 214: >> >>> 212: */ >>> 213: @Override >>> 214: @Deprecated(since = "25", forRemoval

Re: RFR: 8353642: Deprecate URL::getPermission method and networking permission classes for removal [v4]

2025-05-09 Thread Daniel Fuchs
On Fri, 9 May 2025 16:42:31 GMT, Sean Mullan wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five addi

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v5]

2025-05-09 Thread Daniel Fuchs
350588) > > This JEP proposes to enhance the HttpClient implementation to support HTTP/3. > It adds a non-exposed / non-exported internal implementation of the QUIC > protocol based on DatagramChannel and the SunJSSE SSLContext provider. Daniel Fuchs has updated the pull request with a new

Re: RFR: 8356171: Increase timeout for testcases as preparation for change of default timeout factor

2025-05-09 Thread Daniel Fuchs
On Fri, 9 May 2025 08:40:44 GMT, Leo Korinth wrote: > The whole idea of running with a timeout factor of `0.7` is to remove > intermittent failures. (I had it close to 0.5 or maybe less to begin with > until I found and reported CODETOOLS-7903937: JTREG uses timeout factor on > socket timeout

Re: RFR: 8356171: Increase timeout for testcases as preparation for change of default timeout factor

2025-05-09 Thread Daniel Fuchs
On Thu, 8 May 2025 17:41:02 GMT, Daniel Fuchs wrote: > Thank you. I have imported your PR locally and running some HTTP client tests > in the CI. > Tests have not finished running - but I already see one intermittent failure: > `java/net/httpclient/RedirectTimeoutTest.java` i

Re: RFR: 8356171: Increase timeout for testcases as preparation for change of default timeout factor

2025-05-08 Thread Daniel Fuchs
On Thu, 8 May 2025 14:51:24 GMT, Leo Korinth wrote: > This change tries to add timeout to individual testcases so that I am able to > run them with a timeout factor of 1 in the future (JDK-8260555). > > The first commit changes the timeout factor to 0.7, so that I can run tests > and test the

Re: RFR: 8353642: Deprecate URL::getPermission method and networking permission classes for removal [v4]

2025-05-08 Thread Daniel Fuchs
> Please find her a patch that deprecate networking permission classes for > removal. The method `URL::getPermission` now serves little purpose and is > also deprecated. That method was overridden in subclasses and specified to > return some of the deprecated permissions. Dani

Re: RFR: 8356171: Increase timeout for testcases as preparation for change of default timeout factor

2025-05-08 Thread Daniel Fuchs
On Thu, 8 May 2025 14:51:24 GMT, Leo Korinth wrote: > This change tries to add timeout to individual testcases so that I am able to > run them with a timeout factor of 1 in the future (JDK-8260555). > > The first commit changes the timeout factor to 0.7, so that I can run tests > and test the

Re: RFR: 8353642: Deprecate URL::getPermission method and networking permission classes for removal [v4]

2025-05-08 Thread Daniel Fuchs
On Thu, 8 May 2025 16:10:18 GMT, Daniel Fuchs wrote: >> Please find her a patch that deprecate networking permission classes for >> removal. The method `URL::getPermission` now serves little purpose and is >> also deprecated. That method was overridden in subclasse

Re: RFR: 8349910: Implement HTTP/3 for the HTTP Client API [v4]

2025-05-01 Thread Daniel Fuchs
rg/browse/JDK-8350588) > > This JEP proposes to enhance the HttpClient implementation to support HTTP/3. > It adds a non-exposed / non-exported internal implementation of the QUIC > protocol based on DatagramChannel and the SunJSSE SSLContext provider. Daniel Fuchs has updated the pull reques

Re: RFR: 8349910: Implement HTTP/3 for the HTTP Client API [v3]

2025-04-30 Thread Daniel Fuchs
On Wed, 30 Apr 2025 10:19:54 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for >> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976). >> >> The CSR can be viewed at [JDK-83

Re: RFR: 8349910: Implement HTTP/3 for the HTTP Client API [v3]

2025-04-30 Thread Daniel Fuchs
rg/browse/JDK-8350588) > > This JEP proposes to enhance the HttpClient implementation to support HTTP/3. > It adds a non-exposed / non-exported internal implementation of the QUIC > protocol based on DatagramChannel and the SunJSSE SSLContext provider. Daniel Fuchs has updated the pull reques

Re: RFR: 8349910: Implement HTTP/3 for the HTTP Client API [v2]

2025-04-24 Thread Daniel Fuchs
rg/browse/JDK-8350588) > > This JEP proposes to enhance the HttpClient implementation to support HTTP/3. > It adds a non-exposed / non-exported internal implementation of the QUIC > protocol based on DatagramChannel and the SunJSSE SSLContext provider. Daniel Fuchs has updated the pull reques

Re: RFR: 8349910: Implement HTTP/3 for the HTTP Client API

2025-04-22 Thread Daniel Fuchs
On Tue, 22 Apr 2025 18:48:06 GMT, Chen Liang wrote: >> PushId is an HTTP/3 concept. It would be strange to have a generic method >> (sendAsync) that you could call with any requests, but with a parameter that >> could only be used for HTTP/3. We don't have pushIds for HTTP/2. I don't >> think

Re: RFR: 8349910: Implement HTTP/3 for the HTTP Client API

2025-04-22 Thread Daniel Fuchs
On Fri, 18 Apr 2025 18:49:19 GMT, Chen Liang wrote: >> Hi, >> >> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for >> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976). >> >> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Client

RFR: 8349910: Implement HTTP/3 for the HTTP Client API

2025-04-18 Thread Daniel Fuchs
Hi, Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976). The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8350588) This JEP proposes to

Re: Integrated: Merge ed30fce6df57b1cbf7a6efebabc3558550f8ec16

2025-04-16 Thread Daniel Fuchs
On Wed, 16 Apr 2025 11:20:36 GMT, Jaikiran Pai wrote: > This brings in the CPU25_04 changes into the master branch. LGTM - Marked as reviewed by dfuchs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/24683#pullrequestreview-2772164693

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v6]

2025-04-15 Thread Daniel Fuchs
On Tue, 15 Apr 2025 14:35:28 GMT, Michael McMahon wrote: >> Hi, >> >> Enhanced exception messages are designed to hide sensitive information such >> as hostnames, IP >> addresses from exception message strings, unless the enhanced mode for the >> specific category >> has been explicitly enab

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v5]

2025-04-14 Thread Daniel Fuchs
On Thu, 10 Apr 2025 21:26:21 GMT, Michael McMahon wrote: >> Hi, >> >> Enhanced exception messages are designed to hide sensitive information such >> as hostnames, IP >> addresses from exception message strings, unless the enhanced mode for the >> specific category >> has been explicitly enab

Re: RFR: 8353642: Deprecate URL::getPermission method and networking permission classes for removal [v2]

2025-04-11 Thread Daniel Fuchs
On Fri, 11 Apr 2025 13:47:10 GMT, Michael McMahon wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Missing white spaces > > src/java.base/share/classes/java/security/CodeS

Re: RFR: 8353642: Deprecate networking permission classes for removal [v3]

2025-04-11 Thread Daniel Fuchs
> Please find her a patch that deprecate networking permission classes for > removal. The method `URL::getPermission` now serves little purpose and is > also deprecated. That method was overridden in subclasses and specified to > return some of the deprecated permissions. Dani

Re: RFR: 8353642: Deprecate URL::getPermission method and networking permission classes for removal [v2]

2025-04-11 Thread Daniel Fuchs
On Fri, 11 Apr 2025 11:47:21 GMT, Daniel Fuchs wrote: >> I think we should at least consider deprecating URLConnection.getPermission >> and HttpURLConnection.getPermission for removal, only because I don't >> immediately see the advantage of doing it in two steps for the

Re: RFR: 8353642: Deprecate URL::getPermission method and networking permission classes for removal [v2]

2025-04-11 Thread Daniel Fuchs
On Fri, 11 Apr 2025 12:31:04 GMT, Daniel Fuchs wrote: > The GHA failure (Windows) appears to be related. Should be fixed now - PR Comment: https://git.openjdk.org/jdk/pull/24592#issuecomment-2796995066

Re: RFR: 8353642: Deprecate networking permission classes for removal [v2]

2025-04-11 Thread Daniel Fuchs
On Fri, 11 Apr 2025 12:01:52 GMT, Daniel Jeliński wrote: > The GHA failure (Windows) appears to be related. Yes - I missed one windows specific file in my original patch. I have a test running in the CI and I am waiting for it to pass before updating the PR. - PR Comment: https://

Re: RFR: 8353642: Deprecate networking permission classes for removal [v2]

2025-04-11 Thread Daniel Fuchs
On Fri, 11 Apr 2025 11:34:36 GMT, Alan Bateman wrote: >> Possibly. @AlanBateman may have some thoughts on this. > > I think we should at least consider deprecating URLConnection.getPermission > and HttpURLConnection.getPermission for removal, only because I don't > immediately see the advantage

Re: RFR: 8353642: Deprecate networking permission classes for removal [v2]

2025-04-11 Thread Daniel Fuchs
On Fri, 11 Apr 2025 11:10:10 GMT, Daniel Jeliński wrote: >> src/java.base/share/classes/java/security/CodeSource.java line 468: >> >>> 466: } >>> 467: @SuppressWarnings("removal") >>> 468: var result = this.sp.implies(that.sp); >> >> Will we need

Re: RFR: 8353642: Deprecate networking permission classes for removal [v2]

2025-04-11 Thread Daniel Fuchs
On Fri, 11 Apr 2025 10:45:20 GMT, Daniel Jeliński wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Missing white spaces > > src/java.base/share/classes/java/net/HttpURLConne

Re: RFR: 8353642: Deprecate networking permission classes for removal [v2]

2025-04-11 Thread Daniel Fuchs
> Please find her a patch that deprecate networking permission classes for > removal. The method `URL::getPermission` now serves little purpose and is > also deprecated. That method was overridden in subclasses and specified to > return some of the deprecated permissions. Dani

Re: RFR: 8353642: Deprecate networking permission classes for removal

2025-04-11 Thread Daniel Fuchs
On Fri, 11 Apr 2025 09:00:05 GMT, Daniel Fuchs wrote: > Please find her a patch that deprecate networking permission classes for > removal. The method `URL::getPermission` now serves little purpose and is > also deprecated. That method was overridden in subclasses and specified to

RFR: 8353642: Deprecate networking permission classes for removal

2025-04-11 Thread Daniel Fuchs
Please find her a patch that deprecate networking permission classes for removal. The method `URL::getPermission` now serves little purpose and is also deprecated. That method was overridden in subclasses and specified to return some of the deprecated permissions. - Commit message

Re: RFR: 8348967: Deprecate security permission classes for removal

2025-04-04 Thread Daniel Fuchs
On Fri, 4 Apr 2025 12:42:36 GMT, Sean Mullan wrote: > Please review this change to terminally deprecate the following security > related permission classes: `java.security.AllPermission`, > `java.security.UnresolvedPermission`, `javax.net.ssl.SSLPermission`, > `javax.security.auth.AuthPermissi

Re: RFR: 8348967: Deprecate security permission classes for removal

2025-04-04 Thread Daniel Fuchs
Hi David, Are there other subclasses of Permission that this framework uses? More specifically - would it be fine to deprecate NetPermission, URLPermission and SocketPermission classes? best regards, -- daniel On 04/04/2025 15:51, David M. Lloyd wrote: Can you elaborate or give an example/poi

Re: RFR: 8353641: Deprecate core library permission classes for removal

2025-04-04 Thread Daniel Fuchs
On Fri, 4 Apr 2025 12:37:32 GMT, Roger Riggs wrote: > Now that the Security Manager is permanently disabled, the following > permission classes in the core libraries area can be deprecated for removal > as they are no longer useful: FilePermission, LinkPermission, > LoggingPermission, Property

Re: RFR: 8349121: SSLParameters.setApplicationProtocols() ALPN example could be clarified [v3]

2025-02-06 Thread Daniel Fuchs
On Thu, 6 Feb 2025 19:47:54 GMT, Artur Barashev wrote: >> I still think that `Convert to the default ALPN encoding` comment is less >> confusing, we are just passing the string in the encoding that the library >> expects. Basically your comment assumes reader's familiarity with the RFC. > > `Co

Re: RFR: 8249824: s/n/w/p/https/HttpsURLConnection/CloseKeepAliveCached.java uses @ignore w/o bugid [v2]

2025-02-05 Thread Daniel Fuchs
request incrementally with one > additional commit since the last revision: > > Apply suggestions from cr > > Co-authored-by: Daniel Fuchs <67001856+df...@users.noreply.github.com> Marked as reviewed by dfuchs (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/23469#pullrequestreview-2596826422

Re: RFR: 8249824: s/n/w/p/https/HttpsURLConnection/CloseKeepAliveCached.java uses @ignore w/o bugid

2025-02-05 Thread Daniel Fuchs
On Wed, 5 Feb 2025 17:39:42 GMT, Mikhail Yankelevich wrote: > * fully automated the test > * removed the race condition > * client on a thread and server on a thread options are now run together > automatically And implementing the suggested changes would be good... - Changes requ

Re: RFR: 8249824: s/n/w/p/https/HttpsURLConnection/CloseKeepAliveCached.java uses @ignore w/o bugid

2025-02-05 Thread Daniel Fuchs
On Wed, 5 Feb 2025 17:39:42 GMT, Mikhail Yankelevich wrote: > * fully automated the test > * removed the race condition > * client on a thread and server on a thread options are now run together > automatically The new logic looks good to me. Please wait for a review from someone from security

Re: RFR: 8349121: SSLParameters.setApplicationProtocols() ALPN example could be clarified [v3]

2025-02-05 Thread Daniel Fuchs
On Tue, 4 Feb 2025 19:42:24 GMT, Bradford Wetmore wrote: >> Update and clarify the sample code. >> >> Docs only, no additional testing other than verifying javadoc is correctly >> output. > > Bradford Wetmore has updated the pull request incrementally with one > additional commit since the las

Re: RFR: 8349121: SSLParameters.setApplicationProtocols() ALPN example could be clarified [v3]

2025-02-05 Thread Daniel Fuchs
On Wed, 5 Feb 2025 17:42:11 GMT, Bradford Wetmore wrote: >> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 661: >> >>> 659: * // Encode 3 Meetei Mayek letters (HUK, UN, I) using Unicode >>> Escapes >>> 660: * // 0xabcd->0xabcf, 2 Unicode bytes/letter. >>

Re: RFR: 8349121: SSLParameters.setApplicationProtocols() ALPN example could be clarified [v3]

2025-02-05 Thread Daniel Fuchs
On Tue, 4 Feb 2025 19:42:24 GMT, Bradford Wetmore wrote: >> Update and clarify the sample code. >> >> Docs only, no additional testing other than verifying javadoc is correctly >> output. > > Bradford Wetmore has updated the pull request incrementally with one > additional commit since the las

  1   2   3   >