Re: RFR: 8355559: Benchmark modification/extension shouldn't affect the behavior of other benchmarks [v2]

2025-05-01 Thread Eric Caspole
On Fri, 25 Apr 2025 15:25:11 GMT, Sergey Kuksenko wrote: >> Benchmark modification/extension shouldn't affect the behavior of other >> benchmarks. >> Precisely: [JDK-8344144](https://bugs.openjdk.org/browse/JDK-8344144) >> modified AESBench in that way, which caused significant changes in the

Re: RFR: 8353478: Update crypto microbenchmarks to cover ML-DSA, ML-KEM, and HSS algorithms [v3]

2025-04-23 Thread Eric Caspole
On Wed, 9 Apr 2025 19:34:24 GMT, Sergey Kuksenko wrote: >> Update crypto microbenchmarks to cover ML-DSA, ML-KEM, and HSS algorithms. > > Sergey Kuksenko has updated the pull request incrementally with three > additional commits since the last revision: > > - Update SignatureBench.java > >

Re: RFR: 8342958: Use jvmArgs consistently in microbenchmarks

2024-10-25 Thread Eric Caspole
On Thu, 24 Oct 2024 13:52:57 GMT, Claes Redestad wrote: > Many OpenJDK micros use `@Fork(jvmArgs/-Append/-Prepend)` to add JVM > reasonable or necessary flags, but when deploying and running micros we often > want to add or replace flags to tune to the machine, test different GCs, etc. > The i

Re: RFR: 8314085: Fixing scope from benchmark to thread for JMH tests having shared state

2023-10-03 Thread Eric Caspole
On Thu, 10 Aug 2023 15:30:19 GMT, Swati Sharma wrote: > In addition to the issue > [JDK-8311178](https://bugs.openjdk.org/browse/JDK-8311178), logically fixing > the scope from benchmark to thread for below benchmark files having shared > state, also which fixes few of the benchmarks scalabili

Integrated: 8292681: Add JMH for ProtectionDomain

2022-08-31 Thread Eric Caspole
On Fri, 19 Aug 2022 18:48:10 GMT, Eric Caspole wrote: > Add a JMH for ProtectionDomain related to current work on JDK-8292375. Also, > add the InMemoryJavaCompiler to the JMH jar, to generate the classes needed > for this test and will be useful for future class loading JMH too.

Re: RFR: 8292681: Add JMH for ProtectionDomain [v3]

2022-08-29 Thread Eric Caspole
> Add a JMH for ProtectionDomain related to current work on JDK-8292375. Also, > add the InMemoryJavaCompiler to the JMH jar, to generate the classes needed > for this test and will be useful for future class loading JMH too. Eric Caspole has updated the pull request incrementally

Re: RFR: 8292681: Add JMH for ProtectionDomain [v2]

2022-08-25 Thread Eric Caspole
On Thu, 25 Aug 2022 09:14:07 GMT, Sean Mullan wrote: >> Eric Caspole has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updates from reviewers comments > > test/micro/org/openjdk/bench/java/security/Prot

Re: RFR: 8292681: Add JMH for ProtectionDomain [v2]

2022-08-24 Thread Eric Caspole
On Wed, 24 Aug 2022 05:35:54 GMT, David Schlosnagle wrote: >> Eric Caspole has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updates from reviewers comments > > test/micro/org/openjdk/bench/java/security/Prot

Re: RFR: 8292681: Add JMH for ProtectionDomain [v2]

2022-08-24 Thread Eric Caspole
> Add a JMH for ProtectionDomain related to current work on JDK-8292375. Also, > add the InMemoryJavaCompiler to the JMH jar, to generate the classes needed > for this test and will be useful for future class loading JMH too. Eric Caspole has updated the pull request incrementally

RFR: 8292681: Add JMH for ProtectionDomain

2022-08-19 Thread Eric Caspole
Add a JMH for ProtectionDomain related to current work on JDK-8292375. Also, add the InMemoryJavaCompiler to the JMH jar, to generate the classes needed for this test and will be useful for future class loading JMH too. - Commit messages: - 8292681: Add JMH for ProtectionDomain Ch

Re: RFR: 8288568: Reduce runtime of java.security microbenchmarks

2022-06-16 Thread Eric Caspole
On Thu, 16 Jun 2022 15:35:04 GMT, Claes Redestad wrote: > - Reduce forks, iteration, runtime to reduce runtime while maintaining high > data quality on typical benchmarking hosts. > > Reduces runtime from estimated 10+ hours to 54 minutes. Looks good, thanks! - Marked as reviewed