On Mon, 14 Oct 2024 13:52:24 GMT, Sean Mullan wrote:
> This is the implementation of JEP 486: Permanently Disable the Security
> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
> main change
On Tue, 8 Oct 2024 15:28:17 GMT, Jan Lahoda wrote:
> Currently, running `java` without any parameters will lead to an output that
> is a full `--help`, which is over 100 lines (on my computer at least), and it
> feels overwhelming. And many people might actually want to run JShell/REPL,
> not
On Wed, 9 Oct 2024 07:44:49 GMT, Jan Lahoda wrote:
> I was thinking of a different way to say , that would not
> loose the descriptiveness, but none so far. Any more descriptive/specific
> suggestions than ?
I understand why you ended up with that choice of words, since it is not
trivial to
On Tue, 8 Oct 2024 15:28:17 GMT, Jan Lahoda wrote:
> Currently, running `java` without any parameters will lead to an output that
> is a full `--help`, which is over 100 lines (on my computer at least), and it
> feels overwhelming. And many people might actually want to run JShell/REPL,
> not
On Fri, 7 Jun 2024 13:34:45 GMT, Julian Waters wrote:
>> I find the extra trailing newlines through below shell command:
>>
>> for i in `find . -iname "Makefile*" | sed "/./build/d"` ; do tail -n 2 $i |
>> grep -c "^$" | grep -q "^1$" ; if [[ 0 -eq $? ]] ; then echo $i ; fi ; done
>>
>>
>> Th
On Fri, 17 May 2024 13:38:25 GMT, Maurizio Cimadamore
wrote:
>> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting
>> the use of JNI in the following ways:
>>
>> * `System::load` and `System::loadLibrary` are now restricted methods
>> * `Runtime::load` and `Runtime::loa
On Tue, 2 Apr 2024 19:19:59 GMT, Volodymyr Paprotski wrote:
>> Performance. Before:
>>
>> Benchmark(algorithm) (dataSize) (keyLength)
>> (provider) Mode Cnt ScoreError Units
>> SignatureBench.ECDSA.signSHA256withECDSA1024 256
>
On Wed, 6 Mar 2024 00:56:16 GMT, Jaikiran Pai wrote:
>> I believe we could technically reuse the list for boot/platform modules.
>> But, the intent here is to provide more control over the modules with native
>> access, not only being able to add to the list, but also remove from the
>> list.
On Tue, 5 Mar 2024 12:44:10 GMT, Jan Lahoda wrote:
>> Currently, JDK modules load by the bootstrap and platform ClassLoaders are
>> automatically granted the native access. I am working on an upgrade of JLine
>> inside the `jdk.internal.le` module, and I would like to replace the current
>> na
On Thu, 15 Feb 2024 12:19:31 GMT, Magnus Ihse Bursie wrote:
> Since jcheck only checks file in a commit, there is a possibility of us
> getting files in the repository that would not be accepted by jcheck. This
> can happen when extending the set of files checked by jcheck, or
On Thu, 15 Feb 2024 17:53:41 GMT, Naoto Sato wrote:
>> `\u000b` is VT (vertical tab)
>> `\u0009` or `\t` perhaps?
>
> Right. `\t` is better to avoid such a mistake.
Ok, fixed.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/17871#discussion_r1492403403
xes).
>
> I have now run jcheck over the entire code base, and fixed a handful of
> issues. With these changes, jcheck accept the entire code base.
Magnus Ihse Bursie has updated the pull request incrementally with one
additional commit since the last revision:
Replace spaces with \t in
On Thu, 15 Feb 2024 14:01:46 GMT, Erik Joelsson wrote:
>> test/jdk/java/util/Currency/currency.properties line 18:
>>
>>> 16: SB=EUR,111,2, 2099-01-01T00:00:00
>>> 17: US=euR,978,2,2001-01-01T00:00:00
>>> 18: ZZ = ZZZ , 999 , 3
>>
>> This looks weird, but so did t
Since jcheck only checks file in a commit, there is a possibility of us getting
files in the repository that would not be accepted by jcheck. This can happen
when extending the set of files checked by jcheck, or if jcheck changes how it
checks files (perhaps due to bug fixes).
I have now run jc
On Thu, 15 Feb 2024 12:19:31 GMT, Magnus Ihse Bursie wrote:
> Since jcheck only checks file in a commit, there is a possibility of us
> getting files in the repository that would not be accepted by jcheck. This
> can happen when extending the set of files checked by jcheck, or
On Fri, 9 Feb 2024 13:35:55 GMT, Magnus Ihse Bursie wrote:
> This is an attempt to finally implement the idea brought forward in
> JDK-8295729: Properties files is essentially source code. It should have the
> same whitespace checks as all other source code, so we don'
On Fri, 9 Feb 2024 18:09:11 GMT, Naoto Sato wrote:
>> This is an attempt to finally implement the idea brought forward in
>> JDK-8295729: Properties files is essentially source code. It should have
>> the same whitespace checks as all other source code, so we don't get
>> spurious trailing wh
On Fri, 9 Feb 2024 13:35:55 GMT, Magnus Ihse Bursie wrote:
> This is an attempt to finally implement the idea brought forward in
> JDK-8295729: Properties files is essentially source code. It should have the
> same whitespace checks as all other source code, so we don'
On Fri, 9 Feb 2024 13:35:55 GMT, Magnus Ihse Bursie wrote:
> This is an attempt to finally implement the idea brought forward in
> JDK-8295729: Properties files is essentially source code. It should have the
> same whitespace checks as all other source code, so we don'
This is an attempt to finally implement the idea brought forward in
JDK-8295729: Properties files is essentially source code. It should have the
same whitespace checks as all other source code, so we don't get spurious
trailing whitespace changes or leading tabs instead of spaces.
With Skara
On Thu, 1 Feb 2024 11:57:04 GMT, Magnus Ihse Bursie wrote:
> This is a follow-up on
> [JDK-8324053](https://bugs.openjdk.org/browse/JDK-8324053). I have run the
> bin/blessed-modifier-order.sh on the entire code base, and manually checked
> the result. I have reverted all but t
On Thu, 1 Feb 2024 11:57:04 GMT, Magnus Ihse Bursie wrote:
> This is a follow-up on
> [JDK-8324053](https://bugs.openjdk.org/browse/JDK-8324053). I have run the
> bin/blessed-modifier-order.sh on the entire code base, and manually checked
> the result. I have reverted all but t
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote:
> After the "this-escape" lint warning was added to javac (JDK-8015831), the
> base module was not updated to be able to compile with this warning enabled.
> This PR makes the necessary changes to allow the base module to build with
> the warni
On Thu, 1 Feb 2024 11:57:04 GMT, Magnus Ihse Bursie wrote:
> This is a follow-up on
> [JDK-8324053](https://bugs.openjdk.org/browse/JDK-8324053). I have run the
> bin/blessed-modifier-order.sh on the entire code base, and manually checked
> the result. I have reverted all but t
On Thu, 1 Feb 2024 17:21:23 GMT, Joe Darcy wrote:
> I just suggest double-checking on the current maintenance procedures for the
> java.util.concurrent code.
@jddarcy Any idea how to do that? I tried searching for JSR-166 and
java.util.concurrent, but all I could find was talk about a now-del
This is a follow-up on
[JDK-8324053](https://bugs.openjdk.org/browse/JDK-8324053). I have run the
bin/blessed-modifier-order.sh on the entire code base, and manually checked the
result. I have reverted all but these trivial and uncontroversial changes.
Almost all of these are about moving `stat
On Tue, 21 Nov 2023 14:47:39 GMT, Matthew Donovan wrote:
>> Hello,
>>
>> In this PR I removed NSS tests from the ProblemList and updated NssTest to
>> use Sqlite databases. I also removed code in PKCS11Test.java that falls back
>> to NSS libraries installed on the test system. The tests can st
On Tue, 21 Nov 2023 13:55:29 GMT, Matthew Donovan wrote:
>> Hello,
>>
>> In this PR I removed NSS tests from the ProblemList and updated NssTest to
>> use Sqlite databases. I also removed code in PKCS11Test.java that falls back
>> to NSS libraries installed on the test system. The tests can st
On Tue, 21 Nov 2023 12:36:24 GMT, Matthew Donovan wrote:
>> Hello,
>>
>> In this PR I removed NSS tests from the ProblemList and updated NssTest to
>> use Sqlite databases. I also removed code in PKCS11Test.java that falls back
>> to NSS libraries installed on the test system. The tests can st
On Mon, 23 Oct 2023 11:43:06 GMT, Matthew Donovan wrote:
>> I am not sure, but shouldn`t the change also adopt the documentation in
>> test/jdk/sun/security/pkcs11/README
>
>> I am not sure, but shouldn`t the change also adopt the documentation in
>> test/jdk/sun/security/pkcs11/README
>
> Goo
On Thu, 14 Sep 2023 03:23:55 GMT, Julian Waters wrote:
>> Julian Waters has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Document changes in awt_DnDDS.cpp
>
> Pinging
@TheShermanTanker In my experience, getting reviews from all areas for
On Tue, 8 Aug 2023 19:59:52 GMT, Thomas Stuefe wrote:
>> Julian Waters has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 25 commits:
>>
>> - Merge branch 'master' into patch-10
>> - Document changes in awt_DnDDS.cpp
>> - Remove n
On Tue, 8 Aug 2023 19:57:12 GMT, Thomas Stuefe wrote:
>> Julian Waters has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 22 additional
>> commits
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote:
> There are a number of files in the `test` directory that have an incorrect
> copyright header, which includes the "classpath" exception text. This patch
> removes that text from all test files that I could find it in. I did this
> using a
On Mon, 6 Mar 2023 20:22:48 GMT, Pavel Rappo wrote:
>> Please review this superficial documentation cleanup that was triggered by
>> unrelated analysis of doc comments in JDK API.
>>
>> The only effect that this multi-area PR has on the JDK API Documentation
>> (i.e. the observable effect on t
On Fri, 2 Dec 2022 16:40:51 GMT, Magnus Ihse Bursie wrote:
> According to [the
> specification](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/Properties.html#load(java.io.Reader))
> trailing whitespaces in the values of properties files are (somewhat
>
On Fri, 2 Dec 2022 17:12:55 GMT, Andy Goryachev wrote:
>> This turned out to be much more complicated than anticipated. I am going to
>> close this PR (and bug), and instead I have split up this work in five
>> different bugs:
>>
>> [JDK-8298047](https://bugs.openjdk.org/browse/JDK-8298047) is
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote:
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the
On Fri, 2 Dec 2022 16:40:51 GMT, Magnus Ihse Bursie wrote:
> According to [the
> specification](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/Properties.html#load(java.io.Reader))
> trailing whitespaces in the values of properties files are (somewhat
>
According to [the
specification](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/Properties.html#load(java.io.Reader))
trailing whitespaces in the values of properties files are (somewhat
surprisingly) actually significant.
We have multiple files in the JDK with trailing
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the
On Thu, 20 Oct 2022 10:19:38 GMT, Magnus Ihse Bursie wrote:
> After JDK-8294281, it is now possible to disable warnings for individual
> files instead for whole libraries. I used this opportunity to go through all
> disabled warnings in the security native libraries.
>
> An
On Mon, 24 Oct 2022 19:39:21 GMT, Jonathan Gibbons wrote:
> I think it would be better to try and remove incidental trailing whitespace
> first, before encoding any remaining whitespace. Hiding the trailing
> whitespace as a Unicode escape seems like a bad idea, equivalent to sweeping
> the is
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the
On Mon, 24 Oct 2022 19:20:24 GMT, Andy Goryachev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Remove check for .properties from jcheck
>> - Restore trailing whitespace for
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the
s (in the old mercurial version, this was more or less
> impossible).
>
> The only manual change is to `.jcheck/conf`. All other changes were made by
> running `find . -type f -iname "*.properties" | xargs gsed -i -e 's/[
> \t]*$//'`.
Magnus Ihse Bursie has u
On Fri, 21 Oct 2022 08:17:46 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the
s (in the old mercurial version, this was more or less
> impossible).
>
> The only manual change is to `.jcheck/conf`. All other changes were made by
> running `find . -type f -iname "*.properties" | xargs gsed -i -e 's/[
> \t]*$//'`.
Magnus Ihse Bursie has u
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote:
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is
On Thu, 20 Oct 2022 18:38:43 GMT, Andy Goryachev wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increase th
Properties files is essentially source code. It should have the same whitespace
checks as all other source code, so we don't get spurious trailing whitespace
changes.
With the new Skara jcheck, it is possible to increase the coverage of the
whitespace checks (in the old mercurial version, this
On Tue, 18 Oct 2022 11:55:06 GMT, Magnus Ihse Bursie wrote:
> This is a continuation of the effort to update all our URLs to the new
> top-level domain.
>
> This patch updates (most) URLs in testing code. There still exists references
> to openjdk.java.net, but that are not s
This is a continuation of the effort to update all our URLs to the new
top-level domain.
This patch updates (most) URLs in testing code. There still exists references
to openjdk.java.net, but that are not strictly used as normal URLs, which I
deemed need special care, so I left them out of this
On Tue, 18 Oct 2022 11:55:06 GMT, Magnus Ihse Bursie wrote:
> This is a continuation of the effort to update all our URLs to the new
> top-level domain.
>
> This patch updates (most) URLs in testing code. There still exists references
> to openjdk.java.net, but that are not s
On Mon, 10 Oct 2022 14:15:37 GMT, Julian Waters wrote:
> Some external libraries required by native code are linked via linker
> comments embedded in pragmas. Searching for which libraries are linked can
> then become frustrating and confusing since they may be included in an
> obscure place,
On Wed, 12 Oct 2022 09:44:54 GMT, Magnus Ihse Bursie wrote:
> Markdown files are basically source code for documentation. It should have
> the same whitespace checks as all other source code, so we don't get spurious
> trailing whitespace changes.
This pull request has now b
Markdown files are basically source code for documentation. It should have the
same whitespace checks as all other source code, so we don't get spurious
trailing whitespace changes.
-
Commit messages:
- 8295205: Add jcheck whitespace checking for markdown files
Changes: https://gi
On Mon, 3 Oct 2022 20:37:11 GMT, Joe Darcy wrote:
>> With the domain change from openjdk.java.net to openjdk.org, references to
>> URLs in the sources should be updated.
>>
>> Updates were made using a shell script. I"ll run a copyright updater before
>> any push.
>
> Joe Darcy has updated the
On Fri, 30 Sep 2022 01:11:45 GMT, Joe Darcy wrote:
>> With the domain change from openjdk.java.net to openjdk.org, references to
>> URLs in the sources should be updated.
>>
>> Updates were made using a shell script. I"ll run a copyright updater before
>> any push.
>
> Joe Darcy has updated th
On Tue, 30 Aug 2022 12:08:09 GMT, Daniel JeliĆski wrote:
> Fix compilation with Zc:preprocessor enabled.
>
> The flag itself will be enabled in
> [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283); I enabled the
> flag using instructions found in Magnus's comment on that issue.
>
> W
62 matches
Mail list logo