On Thu, 7 Nov 2024 00:37:02 GMT, Ben Perez wrote:
>> Java implementation of ML-DSA, the FIPS 204 post-quantum signature scheme
>> https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.204.pdf. Depends on
>> https://github.com/openjdk/jdk/pull/21167
>
> Ben Perez has updated the pull request incremen
On Thu, 7 Nov 2024 00:37:02 GMT, Ben Perez wrote:
>> Java implementation of ML-DSA, the FIPS 204 post-quantum signature scheme
>> https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.204.pdf. Depends on
>> https://github.com/openjdk/jdk/pull/21167
>
> Ben Perez has updated the pull request incremen
On Tue, 15 Oct 2024 22:17:26 GMT, Ben Perez wrote:
>> Java implementation of ML-KEM, the [FIPS
>> 203](https://csrc.nist.gov/pubs/fips/203/final) post-quantum KEM scheme.
>> Depends on https://github.com/openjdk/jdk/pull/21167
>
> Ben Perez has updated the pull request incrementally with one ad
On Mon, 21 Oct 2024 20:42:14 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/sun/security/provider/ML_DSA.java line 1:
>>
>>> 1: /*
>>
>> Does this class need to be public? Many methods are also public - do they
>> need to be?
>
> No need, but Mark's test might be using it.
Benchmarks
On Thu, 31 Oct 2024 17:21:06 GMT, Weijun Wang wrote:
>> Here we have a launcher and several algorithm-specific tests. Users can
>> populate "internalProjection.json" files generated by NIST's ACVP Server
>> into the `data` directory and test them with the launcher.
>>
>> Currently, only SHA2,
On Fri, 9 Aug 2024 17:22:56 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-8336665
This pull request has now been integrated.
Changeset: ca1700b8
Author: Mark Powers
URL:
https://git.openjdk.org/jdk/commit/ca1700b8bf3b7b34616c469837748ac4c3607dfc
Stats: 93 li
> https://bugs.openjdk.org/browse/JDK-8336665
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
more precise comment
-
Changes:
- all: https://git.openjdk.org/jdk/pull/20528/files
- new: https://git.openjdk.org/
On Tue, 22 Oct 2024 14:27:19 GMT, Sean Mullan wrote:
>> The CRL is being constructed from a fuzzed data input stream. All I know is
>> that the name in the CertificateIssuerExtension looks like an x509.OIDName
>> in the first test, and in the second test it looks like an x509.X400Address.
>>
>
On Mon, 21 Oct 2024 17:28:42 GMT, Sean Mullan wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> more precise exception message
>
> test/jdk/sun/security/x509/X509CRLImpl/Unexpe
On Fri, 18 Oct 2024 13:40:38 GMT, Sean Mullan wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> allow more than one name
>
> src/java.base/share/classes/sun/security/x509/X509CR
> https://bugs.openjdk.org/browse/JDK-8336665
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
more precise exception message
-
Changes:
- all: https://git.openjdk.org/jdk/pull/20528/files
- new: ht
On Fri, 18 Oct 2024 13:50:13 GMT, Sean Mullan wrote:
>> Does the test need to be modified to test for more than one name? I could go
>> either way.
>
> Are you able to easily create test CRLs with more than one entry? If not, I
> think the existing test is ok.
I know how to create a Certificat
On Mon, 14 Oct 2024 13:53:10 GMT, Weijun Wang wrote:
> Previous code change for
> [JDK-8340327](https://bugs.openjdk.org/browse/JDK-8340327) changed the
> display names for all keys with a `NamedParameterSpec` to be the parameter
> set name. This test is not updated.
>
> I understand the curr
On Wed, 9 Oct 2024 16:22:13 GMT, Weijun Wang wrote:
> Switch to `ExceptionCheck`.
>
> This is a part of an umbrella bug [JDK-8341542 JNI uses of
> ExceptionOccurred() treated as if function returns a
> bool](https://bugs.openjdk.org/browse/JDK-8341542).
Looks good to me.
-
PR Co
On Tue, 8 Oct 2024 15:28:58 GMT, Mark Powers wrote:
>> src/java.base/share/classes/sun/security/x509/X509CRLImpl.java line 292:
>>
>>> 290: throw new CRLException("Parsing error: "
>>> 291:
On Tue, 24 Sep 2024 12:33:54 GMT, Sean Mullan wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> another comment from Sean
>
> src/java.base/share/classes/sun/security/x509/X509CR
> https://bugs.openjdk.org/browse/JDK-8336665
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
allow more than one name
-
Changes:
- all: https://git.openjdk.org/jdk/pull/20528/files
- new: https://git.openjdk.org/
On Wed, 11 Sep 2024 13:26:27 GMT, Sean Mullan wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> comment from Sean
>
> src/java.base/share/classes/sun/security/x509/X509CR
> https://bugs.openjdk.org/browse/JDK-8336665
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
another comment from Sean
-
Changes:
- all: https://git.openjdk.org/jdk/pull/20528/files
- new: https://git.openjdk.
On Tue, 27 Aug 2024 17:18:29 GMT, Mark Powers wrote:
> Please review this change to distrust TLS server certificates issued after
> October 31, 2024 and anchored by Entrust Root CAs. This change is in line
> with similar plans recently announced by Google and Mozilla. T
On Tue, 3 Sep 2024 17:38:30 GMT, Rajan Halade wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> beware moving lines around
>
> test/jdk/sun/security/ssl/X509TrustManagerImpl/Entrust/Dis
On Tue, 3 Sep 2024 17:41:24 GMT, Rajan Halade wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> beware moving lines around
>
> test/jdk/sun/security/ssl/X509TrustManagerImpl/Entrust/Dis
On Mon, 2 Sep 2024 21:47:25 GMT, Mark Powers wrote:
>> Please review this change to distrust TLS server certificates issued after
>> October 31, 2024 and anchored by Entrust Root CAs. This change is in line
>> with similar plans recently announced by Google and M
to be valid until they
> expire. This restriction should have minimal compatibility impact since
> Entrust has announced they will be using a partner (SSL.com) for all TLS
> server certificates issued after Oct 31, 2024.
>
> See the CSR for more details: https://bugs.openjdk.org/brow
to be valid until they
> expire. This restriction should have minimal compatibility impact since
> Entrust has announced they will be using a partner (SSL.com) for all TLS
> server certificates issued after Oct 31, 2024.
>
> See the CSR for more details: https://bugs.openjdk.org/brow
On Wed, 28 Aug 2024 13:02:30 GMT, Sean Mullan wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove unused files
>
> src/java.base/share/classes/sun/security/validator/EntrustTLS
to be valid until they
> expire. This restriction should have minimal compatibility impact since
> Entrust has announced they will be using a partner (SSL.com) for all TLS
> server certificates issued after Oct 31, 2024.
>
> See the CSR for more details: https://bugs.openjdk.org/brow
Please review this change to distrust TLS server certificates issued after
October 31, 2024 and anchored by Entrust Root CAs. This change is in line with
similar plans recently announced by Google and Mozilla. TLS server certificates
issued before this date will continue to be valid until they e
On Mon, 12 Aug 2024 19:20:17 GMT, Sean Mullan wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> copyright and unnecessary initialization
>
> src/java.base/share/classes/sun/security/
> https://bugs.openjdk.org/browse/JDK-8336665
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
comment from Sean
-
Changes:
- all: https://git.openjdk.org/jdk/pull/20528/files
- new: https://git.openjdk.org/jdk/p
> https://bugs.openjdk.org/browse/JDK-8336665
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
copyright and unnecessary initialization
-
Changes:
- all: https://git.openjdk.org/jdk/pull/20528/files
- new: ht
On Fri, 9 Aug 2024 17:22:56 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-8336665
Need to update copyright on X509CRLImpl.java.
-
PR Comment: https://git.openjdk.org/jdk/pull/20528#issuecomment-2278477735
https://bugs.openjdk.org/browse/JDK-8336665
-
Commit messages:
- first iteration
Changes: https://git.openjdk.org/jdk/pull/20528/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20528&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8336665
Stats: 88 lines in 2 files
On Wed, 29 May 2024 15:45:12 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-4966250
This pull request has now been integrated.
Changeset: f1fa64b6
Author: Mark Powers
URL:
https://git.openjdk.org/jdk/commit/f1fa64b6b67f2eef916b8d92eb522ccb19035e12
Stats: 25 li
On Wed, 29 May 2024 19:20:27 GMT, Sean Mullan wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Joe Darcy's comment
>
> src/java.base/share/classes/javax/net/ssl/SSLSessionContext.
On Tue, 4 Jun 2024 02:32:31 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-864
This pull request has now been integrated.
Changeset: 14721244
Author: Mark Powers
URL:
https://git.openjdk.org/jdk/commit/1472124489c841642996ae984e21c533ffec8091
Stats: 419 li
> https://bugs.openjdk.org/browse/JDK-864
Mark Powers has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains seven additional commits since
the l
On Tue, 2 Jul 2024 17:23:18 GMT, Kevin Driver wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> move variables to above try block
>
> src/java.base/share/classes/com/sun/crypto/pr
On Mon, 24 Jun 2024 18:26:34 GMT, Sean Mullan wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> move variables to above try block
>
> src/java.base/share/classes/com/sun/crypto/pro
On Mon, 24 Jun 2024 18:15:21 GMT, Sean Mullan wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> move variables to above try block
>
> src/java.base/share/c
On Mon, 24 Jun 2024 18:12:47 GMT, Sean Mullan wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> move variables to above try block
>
> src/java.base/share/classes/com/sun/crypto/pro
On Fri, 14 Jun 2024 13:11:06 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-864
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> move variables to above try block
Thanks for the re
> https://bugs.openjdk.org/browse/JDK-864
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
move variables to above try block
-
Changes:
- all: https://git.openjdk.org/jdk/pull/19535/files
- new: ht
On Thu, 13 Jun 2024 21:23:27 GMT, Valerie Peng wrote:
>> No. The two variables wouldn't be in scope for the `finally` block on line
>> 276.
>
> How about right above the block where they are assigned? The reason that I
> suggested this is that it's easier to see why no default value needed when
> https://bugs.openjdk.org/browse/JDK-864
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
join two lines
-
Changes:
- all: https://git.openjdk.org/jdk/pull/19535/files
- new: https://git.openjdk.org/jdk/p
On Wed, 12 Jun 2024 04:15:44 GMT, Valerie Peng wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> join two lines
>
> src/java.base/share/classes/com/sun/crypto/provider/CipherCore.java li
On Thu, 6 Jun 2024 20:10:10 GMT, Valerie Peng wrote:
>> https://bugs.openjdk.org/browse/JDK-864
>
> src/java.base/share/classes/com/sun/crypto/provider/AESKeyWrap.java line 121:
>
>> 119: @Override
>> 120: int encrypt(byte[] pt, int ptOfs, int ptLen, byte[] ct, int ctOfs) {
>> 121:
> https://bugs.openjdk.org/browse/JDK-864
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
comments from Valerie
-
Changes:
- all: https://git.openjdk.org/jdk/pull/19535/files
- new: https://git.openjdk.org/
On Wed, 5 Jun 2024 23:48:56 GMT, Anthony Scarpino wrote:
>> test/jdk/javax/net/ssl/templates/TLSBase.java line 101:
>>
>>> 99: if (!empty) {
>>> 100: fis = new FileInputStream(System.getProperty("test.src",
>>> "./") +
>>> 101: "/" + pathToStores + "/" + keyS
On Wed, 5 Jun 2024 02:57:41 GMT, Anthony Scarpino wrote:
> Hi,
>
> I need a review for this simple change to fix a threading problem with the
> test. The server thread was not completing before the check occurred on the
> main thread. The failure showed up in windows and macos, but not linux.
On Tue, 4 Jun 2024 02:32:31 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-864
This is the last cleanup bug. After integration, the umbrella bug can be closed.
-
PR Comment: https://git.openjdk.org/jdk/pull/19535#issuecomment-2146459913
https://bugs.openjdk.org/browse/JDK-864
-
Commit messages:
- second iteration
- first iteration
Changes: https://git.openjdk.org/jdk/pull/19535/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19535&range=00
Issue: https://bugs.openjdk.org/browse/JDK-864
Stats:
> https://bugs.openjdk.org/browse/JDK-4966250
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
Joe Darcy's comment
-
Changes:
- all: https://git.openjdk.org/jdk/pull/19458/files
- new: https://git.openjdk.org/
> https://bugs.openjdk.org/browse/JDK-4966250
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
Sean's comment
-
Changes:
- all: https://git.openjdk.org/jdk/pull/19458/files
- new: https://git.openjdk.org/
On Wed, 29 May 2024 15:45:12 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-4966250
/CSR
-
PR Comment: https://git.openjdk.org/jdk/pull/19458#issuecomment-2140612454
https://bugs.openjdk.org/browse/JDK-4966250
-
Commit messages:
- first iteration
Changes: https://git.openjdk.org/jdk/pull/19458/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19458&range=00
Issue: https://bugs.openjdk.org/browse/JDK-4966250
Stats: 7 lines in 1 file ch
On Mon, 13 May 2024 14:34:41 GMT, Weijun Wang wrote:
> Add a new system property to control the name comparison in keytab and ccache
> entry lookup.
Are there any existing interoperability tests?
-
PR Comment: https://git.openjdk.org/jdk/pull/19216#issuecomment-2120764622
On Mon, 13 May 2024 14:34:41 GMT, Weijun Wang wrote:
> Add a new system property to control the name comparison in keytab and ccache
> entry lookup.
LGTM
Only have one comment about existing code.
-
Marked as reviewed by mpowers (Committer).
PR Review: https://git.openjdk.org/jdk
On Mon, 13 May 2024 14:34:41 GMT, Weijun Wang wrote:
> Add a new system property to control the name comparison in keytab and ccache
> entry lookup.
src/java.security.jgss/share/classes/sun/security/krb5/PrincipalName.java line
634:
> 632: // if (this.nameType != pname.nameType) {
> 6
On Thu, 9 May 2024 19:02:05 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-8325384
This pull request has now been integrated.
Changeset: da9c23ac
Author: Mark Powers
URL:
https://git.openjdk.org/jdk/commit/da9c23ace9bdf398d811a88ed137217dd3167231
Stats: 3 lines
> https://bugs.openjdk.org/browse/JDK-8325384
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
just in case
-
Changes:
- all: https://git.openjdk.org/jdk/pull/19160/files
- new: https://git.openjdk.org/jdk/pull/19
On Mon, 8 Apr 2024 19:33:25 GMT, Valerie Peng wrote:
>> Existing legacy mechanism check disables mechanism(s) when the support is
>> partial, e.g. supports decryption but not encryption, or supports
>> verification but not signing. Some mechanisms can be used for both
>> encryption/decryption
https://bugs.openjdk.org/browse/JDK-8325384
-
Commit messages:
- Merge
- the fix
Changes: https://git.openjdk.org/jdk/pull/19160/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19160&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8325384
Stats: 3 lines in 1 file c
On Thu, 18 Apr 2024 20:44:00 GMT, Jonathan Gibbons wrote:
> Please review a set of updates to clean up use of `/**` comments in the
> vicinity of declarations.
>
> There are various categories of update:
>
> * "Box comments" beginning with `/**`
> * Misplaced doc comments before package or imp
On Mon, 8 Apr 2024 19:33:25 GMT, Valerie Peng wrote:
>> Existing legacy mechanism check disables mechanism(s) when the support is
>> partial, e.g. supports decryption but not encryption, or supports
>> verification but not signing. Some mechanisms can be used for both
>> encryption/decryption
On Thu, 14 Mar 2024 20:25:06 GMT, Weijun Wang wrote:
>> src/jdk.security.auth/share/classes/com/sun/security/auth/module/Krb5LoginModule.java
>> line 1015:
>>
>>> 1013: } catch (Exception e) {
>>> 1014: lcreds = null;
>>> 1015: if (debug != null)
>>
>> Might wan
On Thu, 14 Mar 2024 18:04:57 GMT, Weijun Wang wrote:
>> Change `Krb5LoginModule` debugging to use `sun.security.util.Debug`.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> native debug in stderr
src/jdk.security.auth/share
On Thu, 14 Mar 2024 13:43:01 GMT, Weijun Wang wrote:
>> Change `Krb5LoginModule` debugging to use `sun.security.util.Debug`.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> just use true
src/java.security.jgss/share/classes
On Tue, 27 Feb 2024 17:08:54 GMT, Weijun Wang wrote:
>> Add a `memset` after memory is successfully allocated.
>>
>> No regression test, hard to write without a KDC.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> use callo
On Mon, 26 Feb 2024 22:33:03 GMT, Weijun Wang wrote:
> Add a `memset` after memory is successfully allocated.
>
> No regression test, hard to write without a KDC.
Why do you have to set memory to zero?
If you really need to, `calloc()` sets memory to zero.
-
PR Comment: https://gi
On Mon, 5 Feb 2024 18:23:30 GMT, Martin Balao wrote:
> Hi,
>
> May I have a review for this fix to
> [JDK-8325254](https://bugs.openjdk.org/browse/JDK-8325254)?
>
> With this change, CKA_TOKEN = true is used as an indicator of a sensitive
> private key (opaque) only if the token is NSS. The b
On Tue, 31 Oct 2023 18:16:11 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-8318105
This pull request has now been integrated.
Changeset: 38c01971
Author: Mark Powers
URL:
https://git.openjdk.org/jdk/commit/38c01971ff1c440d8c7ef4bc3432e5b9797ae708
Stats: 224 li
On Thu, 11 Jan 2024 03:26:03 GMT, Anthony Scarpino
wrote:
> Hi,
>
> I need a review of a few simple test changes. This fixes a failure with two
> manually run AES/GCM tests that depended on another test that changed with
> [JDK-8318756](https://bugs.openjdk.org/browse/JDK-8318756). It also
> https://bugs.openjdk.org/browse/JDK-8318105
Mark Powers has updated the pull request incrementally with two additional
commits since the last revision:
- Copyright
- reworked to use Benchmark and Thread State
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16435/fi
On Mon, 20 Nov 2023 13:57:58 GMT, Weijun Wang wrote:
>> When blocksize is less than digest output length, call `keccak` more.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> minimize code changes
Nice!
-
PR Co
On Fri, 17 Nov 2023 17:28:40 GMT, Kevin Driver wrote:
>> https://bugs.openjdk.org/browse/JDK-8318105
>
> test/micro/org/openjdk/bench/java/security/HSS.java line 83:
>
>> 81: @Setup
>> 82: public void setup() throws Exception {
>> 83: p = Security.getProvider("SUN");
>
> I assum
On Thu, 16 Nov 2023 20:45:29 GMT, Weijun Wang wrote:
> When blocksize is less than digest output length, call `keccak` more.
Looks good. I only found trivial things. A comment describing `squeezeOffset`
would help.
src/java.base/share/classes/sun/security/provider/DigestBase.java line 144:
>
On Thu, 16 Nov 2023 14:50:23 GMT, Weijun Wang wrote:
> Update `public_suffix_list.dat` to the latest.
Looks good to me. I never knew this existed.
-
PR Comment: https://git.openjdk.org/jdk/pull/16692#issuecomment-1814778083
https://bugs.openjdk.org/browse/JDK-8318105
-
Commit messages:
- @State(Scope.Thread) preference
- first iteration
Changes: https://git.openjdk.org/jdk/pull/16435/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16435&range=00
Issue: https://bugs.openjdk.org/browse/JDK-831
On Tue, 17 Oct 2023 18:03:33 GMT, Weijun Wang wrote:
> The comparison should have been done in case-insensitive mode.
>
> The new test confirms the change inside `DHKEM.java`. The one in
> `XDHPrivateKeyImpl.java` is not easy to confirm. The SUN provider's
> implementation always got the name
On Fri, 13 Oct 2023 16:04:48 GMT, Hai-May Chao wrote:
>> Please review the enhancement for JDK-8311596 and its CSR JDK-8313236. Thank
>> you.
>
> Hai-May Chao has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Change made to configure max all
On Wed, 11 Oct 2023 21:24:30 GMT, Kevin Driver wrote:
> JDK-8308453: JSSE regression test keystore migration from JKS to PKCS12
Looks good to me.
-
PR Review: https://git.openjdk.org/jdk/pull/16159#pullrequestreview-1672643060
On Wed, 20 Sep 2023 15:00:28 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-8315042
This pull request has now been integrated.
Changeset: 8c0d026d
Author: Mark Powers
Committer: Valerie Peng
URL:
https://git.openjdk.org/jdk/com
On Mon, 2 Oct 2023 22:27:41 GMT, Valerie Peng wrote:
>> I'll revert the code to check both.
>
> If we are fixing the summary, can we also elaborate a little more so it's
> clear that the test is checking for CRLException or no NPE is thrown?
@valeriepeng I improved the summary a bit.
-
On Mon, 2 Oct 2023 22:15:15 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8315042
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> a few more comments
I changed the summary to be mor
> https://bugs.openjdk.org/browse/JDK-8315042
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
improved @summary
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15844/files
- new: https://git.openjdk.org/jdk/p
On Mon, 2 Oct 2023 22:27:41 GMT, Valerie Peng wrote:
>> I'll revert the code to check both.
>
> If we are fixing the summary, can we also elaborate a little more so it's
> clear that the test is checking for CRLException or no NPE is thrown?
What about:
"Verify that generateCRL and generateCRLs
On Fri, 8 Sep 2023 19:41:47 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-8296631
This pull request has now been integrated.
Changeset: 6e1aacdf
Author: Mark Powers
Committer: Valerie Peng
URL:
https://git.openjdk.org/jdk/com
On Mon, 2 Oct 2023 20:58:39 GMT, Weijun Wang wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> more comments from Weijun
>
> test/jdk/sun/security/x509/X509CRLImpl/UnexpectedNPE.java lin
> https://bugs.openjdk.org/browse/JDK-8315042
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
a few more comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15844/files
- new: https://git.openjdk.org/jdk/p
> https://bugs.openjdk.org/browse/JDK-8315042
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
more comments from Weijun
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15844/files
- new: https://git.openjdk.
On Mon, 25 Sep 2023 15:29:42 GMT, Weijun Wang wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> comment from Weijun
>
> test/jdk/sun/security/x509/X509CRLImpl/UnexpectedNPE.java lin
On Mon, 25 Sep 2023 03:40:47 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8315042
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> comment from Weijun
@wangweij Thanks for the review
On Mon, 2 Oct 2023 18:04:30 GMT, Weijun Wang wrote:
>> I don't understand.
>
> I mean there is no need to call both `generateCRL` and `generateCRLs`. The
> original test cases are about basic SEQUENCE encoding, the new test case is
> about PKCS7 encoding. These can be tested with a single `gene
On Mon, 25 Sep 2023 15:29:08 GMT, Weijun Wang wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> comment from Weijun
>
> test/jdk/sun/security/x509/X509CRLImpl/UnexpectedNPE.
On Thu, 28 Sep 2023 20:22:40 GMT, Valerie Peng wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> more sqlite conversion needed
>
> Thanks, changes look good to me.
@val
> https://bugs.openjdk.org/browse/JDK-8296631
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
more sqlite conversion needed
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15644/files
- new: ht
On Thu, 21 Sep 2023 15:40:22 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8296631
>
> Mark Powers has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merg
> https://bugs.openjdk.org/browse/JDK-8315042
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
comment from Weijun
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15844/files
- new: https://git.openjdk.org/jdk/p
On Fri, 22 Sep 2023 13:02:57 GMT, Weijun Wang wrote:
>> Why not just updating UnexpectedNPE test with `Utils.runAndCheckException`
>> calls?
>
> I was just thinking the tests are quite different. Now I re-read it and maybe
> we can change the old code to call `generateCRLs` as well. The existin
1 - 100 of 337 matches
Mail list logo
