Re: RFR: 8341243: Use ArraySupport.SOFT_MAX_ARRAY_LENGTH for max array size in java.base

2024-10-01 Thread Stuart Marks
On Tue, 1 Oct 2024 05:52:23 GMT, Eirik Bjørsnøs wrote: >> As this stands (modulo my other comments) this change is mostly OK. Using >> the SOFT_MAX value within java.base is fine. Using SOFT_MAX within >> java.base-related tests is a little suspicious, because it requires the >> addition of di

Re: RFR: 8341243: Use ArraySupport.SOFT_MAX_ARRAY_LENGTH for max array size in java.base [v2]

2024-10-01 Thread Stuart Marks
On Tue, 1 Oct 2024 05:39:09 GMT, Eirik Bjørsnøs wrote: >> Please review this cleanup PR which updates code and tests in `java.base` to >> consistently use `jdk.internal.util.ArraySupport.SOFT_MAX_ARRAY_LENGTH` >> when referring to the JVM's maximum array size implementation limit. >> Currentl

Re: RFR: 8341243: Use ArraySupport.SOFT_MAX_ARRAY_LENGTH for max array size in java.base

2024-09-30 Thread Stuart Marks
On Mon, 30 Sep 2024 15:14:31 GMT, Eirik Bjørsnøs wrote: > Please review this cleanup PR which updates code and tests in `java.base` to > consistently use `jdk.internal.util.ArraySupport.SOFT_MAX_ARRAY_LENGTH` when > referring to the JVM's maximum array size implementation limit. Currently, >

Re: RFR: 8341243: Use ArraySupport.SOFT_MAX_ARRAY_LENGTH for max array size in java.base

2024-09-30 Thread Stuart Marks
On Mon, 30 Sep 2024 15:14:31 GMT, Eirik Bjørsnøs wrote: > Please review this cleanup PR which updates code and tests in `java.base` to > consistently use `jdk.internal.util.ArraySupport.SOFT_MAX_ARRAY_LENGTH` when > referring to the JVM's maximum array size implementation limit. Currently, >

Re: RFR: 8325247: Memory leak in SessionKeyRef class def when using PKCS11 security provider

2024-02-17 Thread Stuart Marks
On Thu, 15 Feb 2024 11:13:17 GMT, Daniel Jeliński wrote: > The reported leak was caused by the death of the `Cleanup-SunPKCS11` thread. > The cleanup thread in turn died because of an exception thrown from > `removeNativeKey` that resulted from 2 threads executing that method at the > same tim

Re: RFR: JDK-8325189: Enable this-escape javac warning in java.base

2024-02-05 Thread Stuart Marks
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote: > After the "this-escape" lint warning was added to javac (JDK-8015831), the > base module was not updated to be able to compile with this warning enabled. > This PR makes the necessary changes to allow the base module to build with > the warni

Re: RFR: 8308995: Update Network IO JFR events to be static mirror events

2023-06-21 Thread Stuart Marks
On Wed, 21 Jun 2023 09:46:35 GMT, Alan Bateman wrote: >> The socket read/write JFR events currently use instrumentation of java.base >> code using templates in the jdk.jfr modules. This results in some java.base >> code residing in the jdk.jfr module which is undesirable. >> >> JDK19 added sta

Re: RFR: JDK-8300133: Use generalized see and link tags in core libs [v2]

2023-01-18 Thread Stuart Marks
On Fri, 13 Jan 2023 22:54:47 GMT, Joe Darcy wrote: >> With generalized see and link tags that can refer to anchors (JDK-8200337), >> the see and link tags in core libraries should be updated to use this >> feature when possible. This PR covers such updates for java.base. > > Joe Darcy has updat

Re: RFR: 8297778: Modernize and improve module jdk.sctp

2022-11-29 Thread Stuart Marks
On Tue, 29 Nov 2022 16:46:43 GMT, Per Minborg wrote: > This PR proposes a variety of modernisations to the `jdk.sctp` module. > > During the fix of https://bugs.openjdk.org/browse/JDK-8296024, several > improvement areas were identified including: > > * Replacing duplicate code segments > *

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v7]

2022-10-31 Thread Stuart Marks
On Mon, 31 Oct 2022 20:11:34 GMT, Jim Laskey wrote: >> Enhance the Java programming language with string templates, which are >> similar to string literals but contain embedded expressions. A string >> template is interpreted at run time by replacing each expression with the >> result of evalu

Re: RFR: 8284780: Need methods to create pre-sized HashSet and LinkedHashSet [v17]

2022-07-07 Thread Stuart Marks
On Wed, 1 Jun 2022 16:45:35 GMT, liach wrote: >> XenoAmess has updated the pull request incrementally with one additional >> commit since the last revision: >> >> do it as naotoj said > > 'the new' fix should be applied to newHashMap etc. too. @liach > 'the new' fix should be applied to ne