On Thu, 25 Aug 2022 20:00:45 GMT, Sean Coffey wrote:
>> Even the cipher suites are the same between client and server, it may still
>> fail with "no common in cipher suites" error. The cause of the bug is not
>> only about "no common in cipher suites" between client and server, but also
>>
On Wed, 24 Aug 2022 20:38:07 GMT, Weibing Xiao wrote:
>> Thanks for the comments. I'm not sure if it is really helpful for
>> developers to understand and debug the failure by reading the additionally
>> dumped cipher suites and/or key exchange configuration. Given the server
>> cipher
On Tue, 23 Aug 2022 20:03:19 GMT, Sean Coffey wrote:
>> So, do you want to make the log where the configuration happens? Logging in
>> one place cannot have the accuracy debug log where the problem happens, and
>> cannot easy the analysis of the debug. One just gets the configuration
>>
On Fri, 19 Aug 2022 15:13:34 GMT, Weijun Wang wrote:
> The two tests are no longer manual and should be removed from the problem
> list.
Marked as reviewed by xuelei (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9943
On Wed, 3 Aug 2022 15:40:54 GMT, Weibing Xiao wrote:
> Log the debugging info for server cipher suites when setting javax.net.debug
> == ssl, handshake.
src/java.base/share/classes/sun/security/ssl/ServerHello.java line 409:
> 407: if (shc.sslConfig.preferLocalCipherSuites) {
>
On Fri, 5 Aug 2022 05:23:15 GMT, Xue-Lei Andrew Fan wrote:
> In the SunJSSE implementation, there are a few unexpected extending of static
> class SupportedGroups. It may be nice to clean them up so that the code is
> easier to read. Please review this simple code clean up.
On Wed, 10 Aug 2022 16:33:27 GMT, Daniel Jeliński wrote:
> > Could it be a TLS implementation problem that the server should not read
> > application data as handshaking data?
>
> Not really; `SSLEngine#unwrap` does not have to consume the entire
> ByteBuffer, and it's the application's
On Fri, 5 Aug 2022 12:25:36 GMT, Daniel Jeliński wrote:
> Fix `SSLEngineService` test class to make sure it does not discard any
> network data between `handshaking` and `receive`.
>
> With TLS1.3 the client starts sending application data immediately after
> sending the Finished message. The
On Fri, 5 Aug 2022 12:25:36 GMT, Daniel Jeliński wrote:
> Fix `SSLEngineService` test class to make sure it does not discard any
> network data between `handshaking` and `receive`.
>
> With TLS1.3 the client starts sending application data immediately after
> sending the Finished message. The
> In the SunJSSE implementation, there are a few unexpected extending of static
> class SupportedGroups. It may be nice to clean them up so that the code is
> easier to read. Please review this simple code clean up.
Xue-Lei Andrew Fan has updated the pull request with a new target
wse/JDK-8291975
>
> This is an effort similar to [JDK-8280494: "(D)TLS signature
> schemes"](https://bugs.openjdk.org/browse/JDK-8280494)
Xue-Lei Andrew Fan has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev exclu
On Sat, 6 Aug 2022 15:12:44 GMT, raspberry-hu wrote:
> remove unused imports
Looks good to me.
-
Marked as reviewed by xuelei (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9792
This update is to support key exchange named groups customization for
individual (D)TLS connection. Please review the CSR as well:
CSR: https://bugs.openjdk.org/browse/JDK-8291950
RFE: https://bugs.openjdk.org/browse/JDK-8281236
Release-note: https://bugs.openjdk.org/browse/JDK-8291975
This is
In the SunJSSE implementation, there are a few unexpected extending of static
class SupportedGroups. It may be nice to clean them up so that the code is
easier to read. Please review this simple code clean up.
-
Commit messages:
- 8291949: Unexpected extending of SupportedGroups
On Sat, 23 Jul 2022 05:29:07 GMT, jquanC wrote:
>> There are some doc errors in sun.security.util.DerOutputStream, like the
>> followings,
>>
>>
>> /**
>> * Private helper routine for writing DER encoded string values.
>> * @param s the string to write
>> * @param stringTag one of the DER
On Fri, 22 Jul 2022 17:59:51 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-8290887
Marked as reviewed by xuelei (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9616
On Fri, 22 Jul 2022 14:56:34 GMT, jquanC wrote:
>> There are some doc errors in sun.security.util.DerOutputStream, like the
>> followings,
>>
>>
>> /**
>> * Private helper routine for writing DER encoded string values.
>> * @param s the string to write
>> * @param stringTag one of the DER
On Fri, 22 Jul 2022 01:43:06 GMT, jquanC wrote:
> On the second point, I have some doubts. 1) Here don't need to add
> ***@***.*** charset" because it's clear to everyone? ***@***.*** enc" does
> not seem to be used in the method. Shouldn't it be deleted?
Sorry for the confusing.
I think it
On Thu, 21 Jul 2022 08:53:31 GMT, jquanC wrote:
> There are some doc errors in sun.security.util.DerOutputStream, like the
> followings,
>
>
> /**
> * Private helper routine for writing DER encoded string values.
> * @param s the string to write
> * @param stringTag one of the DER string
On Mon, 18 Jul 2022 15:22:16 GMT, Hollow Man wrote:
> inifinity -> infinity
> nonnce -> nonce
> hasg -> hash
>
> Signed-off-by: Hollow Man
Looks good to me. Thanks!
-
Marked as reviewed by xuelei (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9541
On Wed, 1 Jun 2022 19:08:03 GMT, Xue-Lei Andrew Fan wrote:
> This is a follow up update per comments in [JDK-8287384
> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
> open part looks good to me. Please help to run Mach5 just case the closed
>
On Fri, 1 Jul 2022 14:45:44 GMT, Alan Bateman wrote:
> Does this address JDK-8288286 and allow ReflectionCallerCacheTest.java to be
> removed from ProblemList-Xcomp.txt?
I think JDK-8288286 should be addressed, but I would like to have it further
evaluated via more Mach5 testing before remove
On Fri, 1 Jul 2022 15:28:36 GMT, Roger Riggs wrote:
> > Could someone in Oracle help me run Mach 5 testing?
>
> The CI Passed for Tiers 1-3.
Thanks a lot!
-
PR: https://git.openjdk.org/jdk/pull/8979
On Thu, 30 Jun 2022 18:44:30 GMT, Xue-Lei Andrew Fan wrote:
>> This is a follow up update per comments in [JDK-8287384
>> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
>> open part looks good to me. Please help to run Mach5 just case the clo
> This is a follow up update per comments in [JDK-8287384
> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
> open part looks good to me. Please help to run Mach5 just case the closed
> test cases are impacted.
Xue-Lei Andrew Fan has updated the
On Fri, 1 Jul 2022 08:12:59 GMT, Daniel Fuchs wrote:
>> True, knowing when GC is 'done' is not deterministic except for a specify
>> Reference to a specific object.
>> System.gc is just a request, the checking for an object can more quickly
>> exit the loop.
>> The code is as is, and already
On Thu, 30 Jun 2022 15:48:07 GMT, Roger Riggs wrote:
>> Xue-Lei Andrew Fan has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 13 commits:
>>
>> - Master
>> - use Reference.refersTo
>> - r
> This is a follow up update per comments in [JDK-8287384
> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
> open part looks good to me. Please help to run Mach5 just case the closed
> test cases are impacted.
Xue-Lei Andrew Fan has updated the
On Thu, 30 Jun 2022 15:53:10 GMT, Roger Riggs wrote:
>> Xue-Lei Andrew Fan has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 13 commits:
>>
>> - Master
>> - use Reference.refersTo
>> - r
On Sat, 18 Jun 2022 05:55:32 GMT, Xue-Lei Andrew Fan wrote:
>> This is a follow up update per comments in [JDK-8287384
>> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
>> open part looks good to me. Please help to run Mach5 just case the clo
On Fri, 17 Jun 2022 16:05:38 GMT, Ryan Ernst wrote:
> Applied required casts in jdk.crypto.ec for the upcoming warning.
> Verified by cherry-picking @asotona's patch.
Marked as reviewed by xuelei (Reviewer).
src/jdk.crypto.ec/share/classes/sun/security/ec/XDHPublicKeyImpl.java line 79:
> 77:
On Thu, 16 Jun 2022 16:08:04 GMT, Roger Riggs wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> remove trailing whitespaces
>
> test/jdk/java/io/ObjectStreamClass/TestOSCClassLoa
ooks good to me. Please help to
> run Mach5 just case the closed test cases are impacted.
Xue-Lei Andrew Fan has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 13 commits:
- Master
- use Reference.refersTo
- remove trailing whites
ooks good to me. Please help to
> run Mach5 just case the closed test cases are impacted.
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
remove trailing whitespaces
-
Changes:
- all: https://git.openjdk.org/j
On Mon, 13 Jun 2022 22:37:52 GMT, Mandy Chung wrote:
>> Xue-Lei Andrew Fan has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains ten commits:
>>
>> - Merge
>> - Merge master
>> - Merge
>&g
On Mon, 13 Jun 2022 22:21:18 GMT, Mandy Chung wrote:
>> test/lib/jdk/test/lib/util/ForceGC.java line 44:
>>
>>> 42: */
>>> 43: public static boolean wait(BooleanSupplier booleanSupplier) {
>>> 44: return wait(booleanSupplier, 1L);
>>
>> For the max waiting time, instead of
> This is a follow up update per comments in [JDK-8287384
> PR](https://github.com/openjdk/jdk/pull/8907). The tier1 and tier2 test in
> open part looks good to me. Please help to run Mach5 just case the closed
> test cases are impacted.
Xue-Lei Andrew Fan has updated the
301 - 337 of 337 matches
Mail list logo
