Re: RFR: 8281236: (D)TLS key exchange named groups [v3]

2022-11-21 Thread Sean Mullan
On Tue, 8 Nov 2022 22:07:35 GMT, Sean Mullan wrote: >>> Unfortunately, I only have author status and can only comment. >> >> I think OpenJDK Author can approve as well. I just need to get another >> Reviewer approval before integration. > >> > Unfortunately, I only have author status and can o

Re: RFR: 8281236: (D)TLS key exchange named groups [v3]

2022-11-20 Thread Xue-Lei Andrew Fan
On Tue, 8 Nov 2022 22:07:35 GMT, Sean Mullan wrote: >>> Unfortunately, I only have author status and can only comment. >> >> I think OpenJDK Author can approve as well. I just need to get another >> Reviewer approval before integration. > >> > Unfortunately, I only have author status and can o

Re: RFR: 8281236: (D)TLS key exchange named groups [v3]

2022-11-08 Thread Xue-Lei Andrew Fan
On Tue, 8 Nov 2022 22:07:35 GMT, Sean Mullan wrote: > > > Unfortunately, I only have author status and can only comment. > > > > > > I think OpenJDK Author can approve as well. I just need to get another > > Reviewer approval before integration. > > For a CSR, I believe that is true. But you

Re: RFR: 8281236: (D)TLS key exchange named groups [v3]

2022-11-08 Thread Sean Mullan
On Tue, 8 Nov 2022 21:52:51 GMT, Xue-Lei Andrew Fan wrote: > > Unfortunately, I only have author status and can only comment. > > I think OpenJDK Author can approve as well. I just need to get another > Reviewer approval before integration. For a CSR, I believe that is true. But you will need

Re: RFR: 8281236: (D)TLS key exchange named groups [v3]

2022-11-08 Thread Xue-Lei Andrew Fan
On Tue, 8 Nov 2022 21:18:20 GMT, Mark Powers wrote: > Unfortunately, I only have author status and can only comment. I think OpenJDK Author can approve as well. I just need to get another Reviewer approval before integration. - PR: https://git.openjdk.org/jdk/pull/9776

Re: RFR: 8281236: (D)TLS key exchange named groups [v3]

2022-11-08 Thread Mark Powers
On Mon, 7 Nov 2022 18:48:27 GMT, Xue-Lei Andrew Fan wrote: >> This update is to support key exchange named groups customization for >> individual (D)TLS connection. Please review the CSR as well: >> CSR: https://bugs.openjdk.org/browse/JDK-8291950 >> RFE: https://bugs.openjdk.org/browse/JDK-8281

Re: RFR: 8281236: (D)TLS key exchange named groups [v3]

2022-11-08 Thread Xue-Lei Andrew Fan
On Tue, 8 Nov 2022 16:51:24 GMT, Mark Powers wrote: > I'll look at your CSR this morning. Make sure your SSLParameters additions > look correct with JavaDoc. I always forget that step. Thank you for the suggestion. I double checked the JavaDoc. It looks good to me. Please feel free to add y

Re: RFR: 8281236: (D)TLS key exchange named groups [v3]

2022-11-08 Thread Mark Powers
On Mon, 7 Nov 2022 18:48:27 GMT, Xue-Lei Andrew Fan wrote: >> This update is to support key exchange named groups customization for >> individual (D)TLS connection. Please review the CSR as well: >> CSR: https://bugs.openjdk.org/browse/JDK-8291950 >> RFE: https://bugs.openjdk.org/browse/JDK-8281

Re: RFR: 8281236: (D)TLS key exchange named groups [v3]

2022-11-07 Thread Xue-Lei Andrew Fan
On Mon, 7 Nov 2022 23:24:39 GMT, Mark Powers wrote: >> Xue-Lei Andrew Fan has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains four commits: >> >> - Merge >> - Merge >> - add test cases >> - 8281236: (D)TLS key exchange algorithms

Re: RFR: 8281236: (D)TLS key exchange named groups [v3]

2022-11-07 Thread Mark Powers
On Mon, 7 Nov 2022 18:48:27 GMT, Xue-Lei Andrew Fan wrote: >> This update is to support key exchange named groups customization for >> individual (D)TLS connection. Please review the CSR as well: >> CSR: https://bugs.openjdk.org/browse/JDK-8291950 >> RFE: https://bugs.openjdk.org/browse/JDK-8281

Re: RFR: 8281236: (D)TLS key exchange named groups [v3]

2022-11-07 Thread Xue-Lei Andrew Fan
> This update is to support key exchange named groups customization for > individual (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.org/browse/JDK-8291950 > RFE: https://bugs.openjdk.org/browse/JDK-8281236 > Release-note: https://bugs.openjdk.org/browse/JDK-8291975 >