Re: RFR: 8289275: Remove incorrect __declspec(dllimport) attributes from pointers in jdk.crypto.cryptoki

2022-07-20 Thread Julian Waters
On Wed, 13 Jul 2022 16:40:48 GMT, Valerie Peng wrote: >>> pkcs11.h is a standard header file from OASIS. Best to leave it alone. Just >>> my .02. >> >> The only change to pkcs11.h is in a comment though, the other changes are >> outside the ANSI C headers from the standard. Should I just rever

Re: RFR: 8289275: Remove incorrect __declspec(dllimport) attributes from pointers in jdk.crypto.cryptoki [v4]

2022-07-19 Thread Valerie Peng
On Thu, 14 Jul 2022 02:48:07 GMT, Julian Waters wrote: >> Several instances of function pointers in jdk.crypto.cryptoki are marked >> with the dllimport attribute, which should only be applied to symbol >> declarations, of which a typedef'd function pointer is not. This would only >> be useful

Re: RFR: 8289275: Remove incorrect __declspec(dllimport) attributes from pointers in jdk.crypto.cryptoki [v4]

2022-07-13 Thread Julian Waters
> Several instances of function pointers in jdk.crypto.cryptoki are marked with > the dllimport attribute, which should only be applied to symbol declarations, > of which a typedef'd function pointer is not. This would only be useful if a > function pointer defined in the linked dll is desired t

Re: RFR: 8289275: Remove incorrect __declspec(dllimport) attributes from pointers in jdk.crypto.cryptoki [v3]

2022-07-13 Thread Julian Waters
> Several instances of function pointers in jdk.crypto.cryptoki are marked with > the dllimport attribute, which should only be applied to symbol declarations, > of which a typedef'd function pointer is not. This would only be useful if a > function pointer defined in the linked dll is desired t

Re: RFR: 8289275: Remove incorrect __declspec(dllimport) attributes from pointers in jdk.crypto.cryptoki

2022-07-13 Thread Julian Waters
On Wed, 13 Jul 2022 16:40:48 GMT, Valerie Peng wrote: > > > pkcs11.h is a standard header file from OASIS. Best to leave it alone. > > > Just my .02. > > > > > > The only change to pkcs11.h is in a comment though, the other changes are > > outside the ANSI C headers from the standard. Should

Re: RFR: 8289275: Remove incorrect __declspec(dllimport) attributes from pointers in jdk.crypto.cryptoki

2022-07-13 Thread Valerie Peng
On Sat, 9 Jul 2022 06:05:09 GMT, Julian Waters wrote: > > pkcs11.h is a standard header file from OASIS. Best to leave it alone. Just > > my .02. > > The only change to pkcs11.h is in a comment though, the other changes are > outside the ANSI C headers from the standard. Should I just revert t

Re: RFR: 8289275: Remove incorrect __declspec(dllimport) attributes from pointers in jdk.crypto.cryptoki [v2]

2022-07-10 Thread Julian Waters
On Sat, 9 Jul 2022 07:46:39 GMT, Julian Waters wrote: >> Several instances of function pointers in jdk.crypto.cryptoki are marked >> with the dllimport attribute, which should only be applied to symbol >> declarations, of which a typedef'd function pointer is not. This would only >> be useful

Re: RFR: 8289275: Remove incorrect __declspec(dllimport) attributes from pointers in jdk.crypto.cryptoki [v2]

2022-07-09 Thread Julian Waters
> Several instances of function pointers in jdk.crypto.cryptoki are marked with > the dllimport attribute, which should only be applied to symbol declarations, > of which a typedef'd function pointer is not. This would only be useful if a > function pointer defined in the linked dll is desired t

Re: RFR: 8289275: Remove incorrect __declspec(dllimport) attributes from pointers in jdk.crypto.cryptoki

2022-07-08 Thread Julian Waters
On Thu, 7 Jul 2022 21:57:42 GMT, Valerie Peng wrote: > pkcs11.h is a standard header file from OASIS. Best to leave it alone. Just > my .02. The only change to pkcs11.h is in a comment though, the other changes are outside the ANSI C headers from the standard. Should I just revert the comment

Re: RFR: 8289275: Remove incorrect __declspec(dllimport) attributes from pointers in jdk.crypto.cryptoki

2022-07-08 Thread Valerie Peng
On Sat, 2 Jul 2022 02:12:15 GMT, Julian Waters wrote: > Several instances of function pointers in jdk.crypto.cryptoki are marked with > the dllimport attribute, which should only be applied to symbol declarations, > of which a typedef'd function pointer is not. This would only be useful if a >

RFR: 8289275: Remove incorrect __declspec(dllimport) attributes from pointers in jdk.crypto.cryptoki

2022-07-01 Thread Julian Waters
Several instances of function pointers in jdk.crypto.cryptoki are marked with the dllimport attribute, which should only be applied to symbol declarations, of which a typedef'd function pointer is not. This would only be useful if a function pointer defined in the linked dll is desired to be imp

RFR: 8289275: Remove incorrect __declspec(dllimport) attributes from pointers in jdk.crypto.cryptoki

2022-06-28 Thread Julian Waters
Several instances of function pointers in jdk.crypto.cryptoki are marked with the dllimport attribute, which should only be applied to symbol declarations, of which a typedef'd function pointer is not. In addition to being incorrect, at least on the versions of Visual C++ the JDK supports today,