Re: RFR: 8289908: Skip bounds check for cases when String is constructed from entirely used byte[] [v4]

2022-07-13 Thread Сергей Цыпанов
On Wed, 13 Jul 2022 15:44:04 GMT, Roger Riggs wrote: >> Сергей Цыпанов has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commits

Re: RFR: 8289908: Skip bounds check for cases when String is constructed from entirely used byte[] [v4]

2022-07-13 Thread Roger Riggs
On Wed, 13 Jul 2022 15:11:25 GMT, Сергей Цыпанов wrote: >> We can skip bounds check and null check for Charset in case we use the array >> entirely and the Charset is either default one or proven to be non-null. >> >> Benchmark results: >> >> before >> >> Benchmark

Re: RFR: 8289908: Skip bounds check for cases when String is constructed from entirely used byte[] [v4]

2022-07-13 Thread Сергей Цыпанов
> We can skip bounds check and null check for Charset in case we use the array > entirely and the Charset is either default one or proven to be non-null. > > Benchmark results: > > before > > Benchmark Mode Cnt Score > Error Units > StringC

Re: RFR: 8289908: Skip bounds check for cases when String is constructed from entirely used byte[] [v4]

2022-07-13 Thread Сергей Цыпанов
On Tue, 12 Jul 2022 15:57:12 GMT, Roger Riggs wrote: >> Benchmark results after: >> >> Benchmark Mode Cnt Score >> Error Units >> StringConstructor.newStringFromArray avgt 50 4,354 >> ± 0,195 ns/op >> StringConstru