Re: RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic [v2]

2024-07-29 Thread Valerie Peng
On Thu, 27 Jun 2024 21:32:53 GMT, Valerie Peng wrote: >>> UP @valeriepeng possible to backport PKCS11 configuration attribute part on >>> JDK 17 or 21 ? >> >> I am not sure, let me check and get back to you. > >> UP @valeriepeng possible to backport PKCS11 configuration attribute part on >> JD

Re: RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic [v2]

2024-07-24 Thread dems54
On Thu, 27 Jun 2024 21:32:53 GMT, Valerie Peng wrote: >>> UP @valeriepeng possible to backport PKCS11 configuration attribute part on >>> JDK 17 or 21 ? >> >> I am not sure, let me check and get back to you. > >> UP @valeriepeng possible to backport PKCS11 configuration attribute part on >> JD

Re: RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic [v2]

2024-06-27 Thread Valerie Peng
On Fri, 14 Jun 2024 18:56:12 GMT, Valerie Peng wrote: > UP @valeriepeng possible to backport PKCS11 configuration attribute part on > JDK 17 or 21 ? Based on the feedback that I got, it should be ok to backport the PKCS11 configuration attribute, separate CSRs would be needed for that though.

Re: RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic [v2]

2024-06-14 Thread Valerie Peng
On Tue, 16 Apr 2024 22:30:57 GMT, Valerie Peng wrote: >> What about testing? > > @mcpowers I am about to leave for vacation. Will wait for your review and > resume on this PR after I return. Thanks! > UP @valeriepeng possible to backport PKCS11 configuration attribute part on > JDK 17 or 21 ?

Re: RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic [v2]

2024-05-29 Thread dems54
On Tue, 16 Apr 2024 22:30:57 GMT, Valerie Peng wrote: >> What about testing? > > @mcpowers I am about to leave for vacation. Will wait for your review and > resume on this PR after I return. Thanks! UP @valeriepeng possible to backport PKCS11 configuration attribute part on JDK 17 or 21 ? --

Re: RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic [v2]

2024-05-10 Thread dems54
On Tue, 16 Apr 2024 22:30:57 GMT, Valerie Peng wrote: >> What about testing? > > @mcpowers I am about to leave for vacation. Will wait for your review and > resume on this PR after I return. Thanks! Many thanks @valeriepeng for this feature. Possible to backport on JDK 17 or 21 ? -

Re: RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic [v2]

2024-05-09 Thread Mark Powers
On Mon, 8 Apr 2024 19:33:25 GMT, Valerie Peng wrote: >> Existing legacy mechanism check disables mechanism(s) when the support is >> partial, e.g. supports decryption but not encryption, or supports >> verification but not signing. Some mechanisms can be used for both >> encryption/decryption

Re: RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic [v2]

2024-05-01 Thread Weijun Wang
On Mon, 8 Apr 2024 19:33:25 GMT, Valerie Peng wrote: >> Existing legacy mechanism check disables mechanism(s) when the support is >> partial, e.g. supports decryption but not encryption, or supports >> verification but not signing. Some mechanisms can be used for both >> encryption/decryption

Re: RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic [v2]

2024-04-16 Thread Valerie Peng
On Tue, 9 Apr 2024 18:37:44 GMT, Mark Powers wrote: >> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update to match CSR for disableLegacy -> allowLegacy name change > > What about testing? @mcpowers I am about to leave f

Re: RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic [v2]

2024-04-16 Thread Valerie Peng
On Tue, 9 Apr 2024 22:15:23 GMT, Valerie Peng wrote: >> What about testing? > >> What about testing? > > I tested the change manually by changing some behavior to simulate the case. > However, this cannot be done by regression test since NSS does not have > legacy mechanisms. > @valeriepeng c

Re: RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic [v2]

2024-04-15 Thread dems54
On Tue, 9 Apr 2024 22:15:23 GMT, Valerie Peng wrote: >> What about testing? > >> What about testing? > > I tested the change manually by changing some behavior to simulate the case. > However, this cannot be done by regression test since NSS does not have > legacy mechanisms. @valeriepeng can

Re: RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic [v2]

2024-04-09 Thread Valerie Peng
On Tue, 9 Apr 2024 18:34:52 GMT, Mark Powers wrote: >> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update to match CSR for disableLegacy -> allowLegacy name change > > src/jdk.crypto.cryptoki/share/classes/sun/security/p

Re: RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic [v2]

2024-04-09 Thread Valerie Peng
On Tue, 9 Apr 2024 18:37:44 GMT, Mark Powers wrote: > What about testing? I tested the change manually by changing some behavior to simulate the case. However, this cannot be done by regression test since NSS does not have legacy mechanisms. - PR Comment: https://git.openjdk.org/

Re: RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic [v2]

2024-04-09 Thread Mark Powers
On Mon, 8 Apr 2024 19:33:25 GMT, Valerie Peng wrote: >> Existing legacy mechanism check disables mechanism(s) when the support is >> partial, e.g. supports decryption but not encryption, or supports >> verification but not signing. Some mechanisms can be used for both >> encryption/decryption

Re: RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic [v2]

2024-04-08 Thread Daniel JeliƄski
On Mon, 8 Apr 2024 19:33:25 GMT, Valerie Peng wrote: >> Existing legacy mechanism check disables mechanism(s) when the support is >> partial, e.g. supports decryption but not encryption, or supports >> verification but not signing. Some mechanisms can be used for both >> encryption/decryption

Re: RFR: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic [v2]

2024-04-08 Thread Valerie Peng
> Existing legacy mechanism check disables mechanism(s) when the support is > partial, e.g. supports decryption but not encryption, or supports > verification but not signing. Some mechanisms can be used for both > encryption/decryption and sign/verify such as RSA related ones. If the > particu