Re: RFR: 8296507: GCM using more memory than necessary with in-place operations [v2]

2022-12-01 Thread Valerie Peng
On Thu, 1 Dec 2022 04:10:32 GMT, Anthony Scarpino wrote: >> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java >> line 778: >> >>> 776: gctr, ghash); >>> 777: } else { >>> 778: int ofs = src.arrayOff

Re: RFR: 8296507: GCM using more memory than necessary with in-place operations [v2]

2022-11-30 Thread Anthony Scarpino
On Thu, 1 Dec 2022 02:10:01 GMT, Valerie Peng wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> comment cleanup & finesse ByteBuffer implGCMCrypt better > > src/java.base/share/classes/com/sun/crypto/provider/Gal

Re: RFR: 8296507: GCM using more memory than necessary with in-place operations [v2]

2022-11-30 Thread Valerie Peng
On Mon, 21 Nov 2022 18:20:09 GMT, Anthony Scarpino wrote: >> I would like a review of an update to the GCM code. A recent report showed >> that GCM memory usage for TLS was very large. This was a result of in-place >> buffers, which TLS uses, and how the code handled the combined intrinsic

Re: RFR: 8296507: GCM using more memory than necessary with in-place operations [v2]

2022-11-30 Thread Valerie Peng
On Mon, 21 Nov 2022 18:20:09 GMT, Anthony Scarpino wrote: >> I would like a review of an update to the GCM code. A recent report showed >> that GCM memory usage for TLS was very large. This was a result of in-place >> buffers, which TLS uses, and how the code handled the combined intrinsic

Re: RFR: 8296507: GCM using more memory than necessary with in-place operations [v2]

2022-11-30 Thread Valerie Peng
On Wed, 16 Nov 2022 16:55:39 GMT, Mark Powers wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> comment cleanup & finesse ByteBuffer implGCMCrypt better > > src/java.base/share/classes/com/sun/crypto/provider/Gal

Re: RFR: 8296507: GCM using more memory than necessary with in-place operations [v2]

2022-11-21 Thread Anthony Scarpino
On Fri, 18 Nov 2022 05:19:31 GMT, Anthony Scarpino wrote: >> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java >> line 694: >> >>> 692: int originalOutOfs = 0; >>> 693: >>> 694: // True if op is in-place array decryption with the input & >>> output >>

Re: RFR: 8296507: GCM using more memory than necessary with in-place operations [v2]

2022-11-21 Thread Anthony Scarpino
On Wed, 16 Nov 2022 17:01:50 GMT, Mark Powers wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> comment cleanup & finesse ByteBuffer implGCMCrypt better > > src/java.base/share/classes/com/sun/crypto/provider/Gal

Re: RFR: 8296507: GCM using more memory than necessary with in-place operations [v2]

2022-11-21 Thread Anthony Scarpino
> I would like a review of an update to the GCM code. A recent report showed > that GCM memory usage for TLS was very large. This was a result of in-place > buffers, which TLS uses, and how the code handled the combined intrinsic > method during decryption. A temporary buffer was used because