Re: RFR: 8308016: Use snippets in java.io package [v2]

2023-05-18 Thread Brian Burkhalter
On Wed, 17 May 2023 15:50:13 GMT, Roger Riggs wrote: >> src/java.base/share/classes/java/io/RandomAccessFile.java line 904: >> >>> 902: * {@code b7}, and {@code b8,} where: >>> 903: * {@snippet lang=java : >>> 904: * 0 <= b1, b2, b3, b4, b5, b6, b7, b8 <= 255, >> >> Same:

Re: RFR: 8308016: Use snippets in java.io package [v2]

2023-05-17 Thread Roger Riggs
On Sun, 14 May 2023 05:50:20 GMT, Tagir F. Valeev wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8308016: Remove ellipses ("...") from snippets > > src/java.base/share/classes/java/io/RandomAccessFile.java lin

Re: RFR: 8308016: Use snippets in java.io package [v2]

2023-05-13 Thread Alan Bateman
On Sun, 14 May 2023 05:47:50 GMT, Tagir F. Valeev wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8308016: Remove ellipses ("...") from snippets > > src/java.base/share/classes/java/io/FilePermission.java line

Re: RFR: 8308016: Use snippets in java.io package [v2]

2023-05-13 Thread Alan Bateman
On Fri, 12 May 2023 19:02:46 GMT, Brian Burkhalter wrote: >> Replace `{@code ...}` patterns and the like with `{@snippet >> lang=java : ...}`. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8308016: Remove ellipses ("

Re: RFR: 8308016: Use snippets in java.io package [v2]

2023-05-13 Thread Tagir F . Valeev
On Fri, 12 May 2023 17:59:32 GMT, Lance Andersen wrote: >> I have been just trying to keep it as similar visually as possible but what >> you say is reasonable. > > Agree, that I would make the code valid when using a snippet There's a replacement tag for this. Some people use label, e.g. code

Re: RFR: 8308016: Use snippets in java.io package [v2]

2023-05-13 Thread Tagir F . Valeev
On Fri, 12 May 2023 19:02:46 GMT, Brian Burkhalter wrote: >> Replace `{@code ...}` patterns and the like with `{@snippet >> lang=java : ...}`. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8308016: Remove ellipses ("

Re: RFR: 8308016: Use snippets in java.io package [v2]

2023-05-12 Thread Brian Burkhalter
> Replace `{@code ...}` patterns and the like with `{@snippet > lang=java : ...}`. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8308016: Remove ellipses ("...") from snippets - Changes: - all: https://git.openj