Re: RFR: 8309667: TLS handshake fails because of ConcurrentModificationException in PKCS12KeyStore.engineGetEntry [v3]

2023-09-25 Thread Weijun Wang
On Fri, 16 Jun 2023 12:52:00 GMT, Weijun Wang wrote: >> The `attributes` field inside the `PKCS12KeyStore.Entry` class might be >> modified and retrieved at the same time. Make it concurrent. >> >> The test uses some reflection to get this field and try updating it in >> multiple threads. > >

Re: RFR: 8309667: TLS handshake fails because of ConcurrentModificationException in PKCS12KeyStore.engineGetEntry [v3]

2023-06-16 Thread Weijun Wang
On Fri, 16 Jun 2023 12:52:00 GMT, Weijun Wang wrote: >> The `attributes` field inside the `PKCS12KeyStore.Entry` class might be >> modified and retrieved at the same time. Make it concurrent. >> >> The test uses some reflection to get this field and try updating it in >> multiple threads. > >

Re: RFR: 8309667: TLS handshake fails because of ConcurrentModificationException in PKCS12KeyStore.engineGetEntry [v3]

2023-06-16 Thread Daniel Fuchs
On Fri, 16 Jun 2023 12:45:58 GMT, Weijun Wang wrote: >> src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java line >> 1438: >> >>> 1436: >>> 1437: if (entry.attributes == null) { >>> 1438: entry.attributes = ConcurrentHashMap.newKeySet(); >> >> It seems that

Re: RFR: 8309667: TLS handshake fails because of ConcurrentModificationException in PKCS12KeyStore.engineGetEntry [v3]

2023-06-16 Thread Weijun Wang
On Fri, 16 Jun 2023 09:25:30 GMT, Daniel Fuchs wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> more cases to cover > > src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java line 1438: > >> 1436: >> 1

Re: RFR: 8309667: TLS handshake fails because of ConcurrentModificationException in PKCS12KeyStore.engineGetEntry [v3]

2023-06-16 Thread Weijun Wang
On Fri, 16 Jun 2023 09:53:10 GMT, Daniel JeliƄski wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> more cases to cover > > src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java line 1: > >> 1: /* > >

Re: RFR: 8309667: TLS handshake fails because of ConcurrentModificationException in PKCS12KeyStore.engineGetEntry [v3]

2023-06-16 Thread Weijun Wang
> The `attributes` field inside the `PKCS12KeyStore.Entry` class might be > modified and retrieved at the same time. Make it concurrent. > > The test uses some reflection to get this field and try updating it in > multiple threads. Weijun Wang has updated the pull request incrementally with one