On Fri, 7 Jul 2023 19:21:29 GMT, Pavel Rappo wrote:
> > Took another pass at this, looks good, but I would like to take another
> > last look and make sure that changing the hash code for some of the classes
> > like X509CRL is a benign change.
>
> Thanks, Sean. Take your time, you're an exper
On Fri, 7 Jul 2023 19:19:03 GMT, Sean Mullan wrote:
> Took another pass at this, looks good, but I would like to take another last
> look and make sure that changing the hash code for some of the classes like
> X509CRL is a benign change.
Thanks, Sean. Take your time, you're an expert in this
On Thu, 6 Jul 2023 19:10:14 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> `equals` and `hashCode` in security area.
>>
>> I understand that security area is sensitive and a non-expert, such as
>> myself, should tread carefully; so belo
On Thu, 6 Jul 2023 19:10:14 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> `equals` and `hashCode` in security area.
>>
>> I understand that security area is sensitive and a non-expert, such as
>> myself, should tread carefully; so belo
> Please review this PR to use modern APIs and language features to simplify
> `equals` and `hashCode` in security area.
>
> I understand that security area is sensitive and a non-expert, such as
> myself, should tread carefully; so below are my notes to assist the review.
>
> * Unlike `hashCod
