Re: RFR: 8313229: DHEKeySizing.java should be modified to use TLS versions TLSv1, TLSv1.1, TLSv1.2 [v2]

2023-09-21 Thread Jamil Nimeh
On Thu, 21 Sep 2023 13:29:10 GMT, Sean Mullan wrote: >> Please review this change to ensure this test is tested on different TLS >> protocols (1.0, 1.1, 1.2) >> >> I added a protocol parameter to the test arguments so that different >> protocols are tested. I also removed the boolean

Re: RFR: 8313229: DHEKeySizing.java should be modified to use TLS versions TLSv1, TLSv1.1, TLSv1.2 [v2]

2023-09-21 Thread Jamil Nimeh
On Thu, 21 Sep 2023 13:30:07 GMT, Sean Mullan wrote: >> test/jdk/sun/security/ssl/DHKeyExchange/DHEKeySizing.java line 35: >> >>> 33: * @library /javax/net/ssl/templates >>> 34: * @run main/othervm -Djdk.tls.client.enableSessionTicketExtension=false >>> 35: * DHEKeySizing

Re: RFR: 8313229: DHEKeySizing.java should be modified to use TLS versions TLSv1, TLSv1.1, TLSv1.2 [v2]

2023-09-21 Thread Sean Mullan
On Wed, 20 Sep 2023 20:13:35 GMT, Jamil Nimeh wrote: >> Sean Mullan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Only adjust sever hello size for TLS_DHE_RSA_WITH_AES_128_CBC_SHA with >> TLSv1.2. >> Fix some typos. > >

Re: RFR: 8313229: DHEKeySizing.java should be modified to use TLS versions TLSv1, TLSv1.1, TLSv1.2 [v2]

2023-09-21 Thread Sean Mullan
> Please review this change to ensure this test is tested on different TLS > protocols (1.0, 1.1, 1.2) > > I added a protocol parameter to the test arguments so that different > protocols are tested. I also removed the boolean exportable argument as it > wasn't doing anything. Sean Mullan has