Re: RFR: 8314148: Fix variable scope in SunMSCAPI [v2]

2023-08-14 Thread Valerie Peng
On Fri, 11 Aug 2023 20:15:59 GMT, Daniel Jeliński wrote: >> Please review this patch that fixes the scope of 2 local variables to make >> sure they are in scope when they are used. >> >> The patch additionally fixes one `c++11-narrowing` Clang warning by >> explicitly casting string size (`siz

Re: RFR: 8314148: Fix variable scope in SunMSCAPI [v2]

2023-08-11 Thread Mark Powers
On Fri, 11 Aug 2023 20:15:59 GMT, Daniel Jeliński wrote: >> Please review this patch that fixes the scope of 2 local variables to make >> sure they are in scope when they are used. >> >> The patch additionally fixes one `c++11-narrowing` Clang warning by >> explicitly casting string size (`siz

Re: RFR: 8314148: Fix variable scope in SunMSCAPI [v2]

2023-08-11 Thread Daniel Jeliński
> Please review this patch that fixes the scope of 2 local variables to make > sure they are in scope when they are used. > > The patch additionally fixes one `c++11-narrowing` Clang warning by > explicitly casting string size (`size_t`) to `DWORD`. Daniel Jeliński has updated the pull request

Re: RFR: 8314148: Fix variable scope in SunMSCAPI

2023-08-11 Thread Daniel Jeliński
On Fri, 11 Aug 2023 16:53:41 GMT, Mark Powers wrote: >> Please review this patch that fixes the scope of 2 local variables to make >> sure they are in scope when they are used. >> >> The patch additionally fixes one `c++11-narrowing` Clang warning by >> explicitly casting string size (`size_t`

Re: RFR: 8314148: Fix variable scope in SunMSCAPI

2023-08-11 Thread Mark Powers
On Fri, 11 Aug 2023 06:36:42 GMT, Daniel Jeliński wrote: > Please review this patch that fixes the scope of 2 local variables to make > sure they are in scope when they are used. > > The patch additionally fixes one `c++11-narrowing` Clang warning by > explicitly casting string size (`size_t`)

RFR: 8314148: Fix variable scope in SunMSCAPI

2023-08-11 Thread Daniel Jeliński
Please review this patch that fixes the scope of 2 local variables to make sure they are in scope when they are used. The patch additionally fixes one `c++11-narrowing` Clang warning by explicitly casting string size (`size_t`) to `DWORD`. - Commit messages: - Fix variable scope