Re: RFR: 8315968: Move java.util.Digits to jdk.internal.util and refactor to reduce duplication [v19]

2023-09-12 Thread Roger Riggs
On Tue, 12 Sep 2023 13:27:29 GMT, 温绍锦 wrote: >> java.util.DecimalDigits::DIGITS and java.lang.StringLatin1.PACKED_DIGITS are >> duplicates, We need to move >> java.util.Digits/OctalDigits/DecimalDigits/HexDigits to the >> jdk.internal.util package, and modify these classes to public class, so

Re: RFR: 8315968: Move java.util.Digits to jdk.internal.util and refactor to reduce duplication [v19]

2023-09-12 Thread Claes Redestad
On Tue, 12 Sep 2023 13:27:29 GMT, 温绍锦 wrote: >> java.util.DecimalDigits::DIGITS and java.lang.StringLatin1.PACKED_DIGITS are >> duplicates, We need to move >> java.util.Digits/OctalDigits/DecimalDigits/HexDigits to the >> jdk.internal.util package, and modify these classes to public class, so

Re: RFR: 8315968: Move java.util.Digits to jdk.internal.util and refactor to reduce duplication [v19]

2023-09-12 Thread 温绍锦
On Tue, 12 Sep 2023 14:16:27 GMT, Roger Riggs wrote: > > The title has been updated, please help update the title of JIRA > > The description needs an update too. The description has also been updated - PR Comment: https://git.openjdk.org/jdk/pull/15651#issuecomment-1715880514

Re: RFR: 8315968: Move java.util.Digits to jdk.internal.util and refactor to reduce duplication [v19]

2023-09-12 Thread Chen Liang
On Tue, 12 Sep 2023 13:27:29 GMT, 温绍锦 wrote: >> Some codes in core libs are duplicated, including: >> java.util.DecimalDigits::DIGITS -> java.lang.StringLatin1.PACKED_DIGITS >> java.util.DecimalDigits::size -> java.lang.Long.stringSize >> >> We can reduce duplication through JavaLangAccess, whic

Re: RFR: 8315968: Move java.util.Digits to jdk.internal.util and refactor to reduce duplication [v19]

2023-09-12 Thread Roger Riggs
On Tue, 12 Sep 2023 14:13:06 GMT, 温绍锦 wrote: > The title has been updated, please help update the title of JIRA The description needs an update too. - PR Comment: https://git.openjdk.org/jdk/pull/15651#issuecomment-1715814638

Re: RFR: 8315968: Move java.util.Digits to jdk.internal.util and refactor to reduce duplication [v19]

2023-09-12 Thread 温绍锦
On Tue, 12 Sep 2023 13:49:09 GMT, Roger Riggs wrote: > Please update this PR title and description to indicate this refactoring to > move to jdk.internal.util. I can update the Jira title and description to > match after that. The title has been updated, please help update the title of JIRA -